[Bug 29050] New: Add punctuation in Unseen Renewals message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29050 Bug ID: 29050 Summary: Add punctuation in Unseen Renewals message Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Depends on: 24083 In the Checkouts tab of the patron record, the counts of renewals and unseen renewals need some punctuation. Right now they say something like "(W of X renewals remainingY of Z unseen renewals remaining." That needs at least a comma and a space in the middle, for ""(W of X renewals remaining, Y of Z unseen renewals remaining." Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 [Bug 24083] Koha should support "seen" vs "unseen" renewals -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29050 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |trivial Keywords| |Academy CC| |jonathan.druart+koha@gmail. | |com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29050 Koha Training Catalyst <koha-training@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29050 --- Comment #1 from Koha Training Catalyst <koha-training@catalyst.net.nz> --- Created attachment 137348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137348&action=edit Bug 29050: Added a punctuation between renewal messages Test plan: 1. First step is to go to administration > then system preferences 2. Set unseenrenewal to "allow" 3. Go to administatrion > circulation and fines rule 4. Set unseenrenewals count to any number 5. Check out an item to a patron and go to the checkouts tab 6. Renew the item 7. Notice that the renewal messages have no seperation 8. Apply the patch 9. Notice there is now a "&" in the spacing between renewal messages Sponsored-by: Catalyst IT -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29050 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137348|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 137350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137350&action=edit Bug 29050: Added a punctuation between renewal messages Test plan: 1. First step is to go to administration > then system preferences 2. Set unseenrenewal to "allow" 3. Go to administatrion > circulation and fines rule 4. Set unseenrenewals count to any number 5. Check out an item to a patron and go to the checkouts tab 6. Renew the item 7. Notice that the renewal messages have no seperation 8. Apply the patch 9. Notice there is now a "&" in the spacing between renewal messages Sponsored-by: Catalyst IT Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Does what it says it does, still needs independent sign off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29050 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29050 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29050 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137350|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 137385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137385&action=edit Bug 29050: Added a punctuation between renewal messages Test plan: 1. First step is to go to administration > then system preferences 2. Set unseenrenewal to "allow" 3. Go to administatrion > circulation and fines rule 4. Set unseenrenewals count to any number 5. Check out an item to a patron and go to the checkouts tab 6. Renew the item 7. Notice that the renewal messages have no seperation 8. Apply the patch 9. Notice there is now a "&" in the spacing between renewal messages Sponsored-by: Catalyst IT Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29050 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|Signed Off |Passed QA --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thank you for your patch, Nisha! Going straight to PQA for this one. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29050 --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 137403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137403&action=edit Bug 29050: (follow-up) Replace & with and See the terminology list https://wiki.koha-community.org/wiki/Terminology Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29050 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29050 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29050 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00 |22.11.00, 22.05.04 released in| | Status|Pushed to master |Pushed to stable CC| |lucas@bywatersolutions.com --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for 22.05.04 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29050 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.04 |22.11.00, 22.05.04, released in| |21.11.11 Status|Pushed to stable |Pushed to oldstable CC| |arthur.suzuki@biblibre.com --- Comment #8 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- pushed to 21.11.x for 21.11.11 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29050 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED CC| |victor@tuxayo.net --- Comment #9 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document, marking resolved. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org