[Bug 28828] New: (Bug 22399 follow-up) breaks value_builder/unimarc_field_4XX.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28828 Bug ID: 28828 Summary: (Bug 22399 follow-up) breaks value_builder/unimarc_field_4XX.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Since Bug 22399 changes in biblio editor, value builder unimarc_field_4XX.tt JavaScript code does not do its job anymore. This is because a div is added and this call is now wrong : var subfields = whichfield.parentNode.parentNode.getElementsByTagName('input'); It needs one more parent. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28828 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22399 Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 [Bug 22399] Improve responsive behavior of the basic marc editor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28828 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28828 --- Comment #1 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 123591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123591&action=edit Bug 28828: (Bug 22399 follow-up) impact on value_builder/unimarc_field_4XX.tt Since Bug 22399 changes in biblio editor, value builder unimarc_field_4XX.tt JavaScript code does not do its job anymore. This is because a div is added and this call is now wrong : var subfields = whichfield.parentNode.parentNode.getElementsByTagName('input'); It needs one more parent. Test plan : 1) Use a UNIMARC DB 2) Define value builder unimarc_field_4XX on 463$t 3) Create a record B1 with 200$a, 200$f 4) Create a new record B2 5) Click on value builder in 463$t 6) Search for record B1 7) Click on "Choose" => Without patch only 463$t is filled with a value => With patch 463 $t, $a, $0 and $9 are filled with a value -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28828 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|(Bug 22399 follow-up) |Bug 22399 breaks |breaks |value_builder/unimarc_field |value_builder/unimarc_field |_4XX.tt |_4XX.tt | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28828 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123591|0 |1 is obsolete| | --- Comment #2 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 123592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123592&action=edit Bug 28828: Bug 22399 impact on value_builder/unimarc_field_4XX.tt Since Bug 22399 changes in biblio editor, value builder unimarc_field_4XX.tt JavaScript code does not do its job anymore. This is because a div is added and this call is now wrong : var subfields = whichfield.parentNode.parentNode.getElementsByTagName('input'); It needs one more parent. Test plan : 1) Use a UNIMARC DB 2) Define value builder unimarc_field_4XX on 463$t 3) Create a record B1 with 200$a, 200$f 4) Create a new record B2 5) Click on value builder in 463$t 6) Search for record B1 7) Click on "Choose" => Without patch only 463$t is filled with a value => With patch 463 $t, $a, $0 and $9 are filled with a value -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28828 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28829 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28828 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28828 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123592|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 123594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123594&action=edit Bug 28828: Bug 22399 impact on value_builder/unimarc_field_4XX.tt Since Bug 22399 changes in biblio editor, value builder unimarc_field_4XX.tt JavaScript code does not do its job anymore. This is because a div is added and this call is now wrong : var subfields = whichfield.parentNode.parentNode.getElementsByTagName('input'); It needs one more parent. Test plan : 1) Use a UNIMARC DB 2) Define value builder unimarc_field_4XX on 463$t 3) Create a record B1 with 200$a, 200$f 4) Create a new record B2 5) Click on value builder in 463$t 6) Search for record B1 7) Click on "Choose" => Without patch only 463$t is filled with a value => With patch 463 $t, $a, $0 and $9 are filled with a value Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28828 --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 123642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123642&action=edit Bug 28828: (Alternate) find closest ul for valuebuilders Since Bug 22399 changes in biblio editor, value builder unimarc_field_4XX.tt JavaScript code does not do its job anymore. This is because a div is added and this call is now wrong : var subfields = whichfield.parentNode.parentNode.getElementsByTagName('input'); It needs one more parent. Test plan 1: 1) Use a UNIMARC DB 2) Define value builder unimarc_field_4XX on 463$t 3) Create a record B1 with 200$a, 200$f 4) Create a new record B2 5) Click on value builder in 463$t 6) Search for record B1 7) Click on "Choose" => Without patch only 463$t is filled with a value => With patch 463 $t, $a, $0 and $9 are filled with a value Test plan 2: 1) Use a MARC_21 DB 2) Define plugin mnarc21_linking_section.pl on 773$t 3) Make sure 773$t and other subfields are visible in intranet/editor 4) Create a new record in basic cataloging editor 5) Click on value builder in 773$t 6) Search fro a record 7) Click on "Choose" => Without patch fields are not fileld => With patch subfields are correctly filled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28828 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Looks like a second plugin is affected - I use 'closest' rather than several 'parentNode' as I think it makes the change clearer - what do you think Frido? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28828 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28738 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Bug 28738 is also affected - would love some help there simplifying the JS. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28828 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Bug 22399 breaks |Bug 22399 breaks |value_builder/unimarc_field |unimarc_field_4XX.tt and |_4XX.tt |marc21_linking_section.tt | |value builders -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28828 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123594|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28828 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123594|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28828 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123594|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28828 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123642|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 123666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123666&action=edit Bug 28828: Fix unimarc_field_4XX.tt and marc21_linking_section.tt value builders Find closest ul for value builders. Since Bug 22399 changes in biblio editor, value builder unimarc_field_4XX.tt JavaScript code does not do its job anymore. This is because a div is added and this call is now wrong: var subfields = whichfield.parentNode.parentNode.getElementsByTagName('input'); Test plan 1: 1) Use a UNIMARC DB 2) Define value builder unimarc_field_4XX on 463$t 3) Create a record B1 with 200$a, 200$f 4) Create a new record B2 5) Click on value builder in 463$t 6) Search for record B1 7) Click on "Choose" => Without patch only 463$t is filled with a value => With patch 463 $t, $a, $0 and $9 are filled with a value Test plan 2: 1) Use a MARC_21 DB 2) Define plugin marc21_linking_section.pl on 773$t 3) Make sure 773$t and other subfields are visible in intranet/editor 4) Create a new record in basic cataloging editor 5) Click on value builder in 773$t 6) Search fro a record 7) Click on "Choose" => Without patch fields are not fileld => With patch subfields are correctly filled Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28828 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Frido or David, could one of you have a final look here? I've chosen Nick's alternate and changed the bug title to reflect that this now fixes 2 different value builders. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28828 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123666|0 |1 is obsolete| | --- Comment #9 from David Nind <david@davidnind.com> --- Created attachment 123687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123687&action=edit Bug 28828: Fix unimarc_field_4XX.tt and marc21_linking_section.tt value builders Find closest ul for value builders. Since Bug 22399 changes in biblio editor, value builder unimarc_field_4XX.tt JavaScript code does not do its job anymore. This is because a div is added and this call is now wrong: var subfields = whichfield.parentNode.parentNode.getElementsByTagName('input'); Test plan 1: 1) Use a UNIMARC DB 2) Define value builder unimarc_field_4XX on 463$t 3) Create a record B1 with 200$a, 200$f 4) Create a new record B2 5) Click on value builder in 463$t 6) Search for record B1 7) Click on "Choose" => Without patch only 463$t is filled with a value => With patch 463 $t, $a, $0 and $9 are filled with a value Test plan 2: 1) Use a MARC_21 DB 2) Define plugin marc21_linking_section.pl on 773$t 3) Make sure 773$t and other subfields are visible in intranet/editor 4) Create a new record in basic cataloging editor 5) Click on value builder in 773$t 6) Search fro a record 7) Click on "Choose" => Without patch fields are not fileld => With patch subfields are correctly filled Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28828 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #10 from David Nind <david@davidnind.com> --- (In reply to Katrin Fischer from comment #8)
Hi Frido or David, could one of you have a final look here? I've chosen Nick's alternate and changed the bug title to reflect that this now fixes 2 different value builders.
I have run through the updated test plan and everything works as expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28828 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thanks a lot David! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28828 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28828 --- Comment #12 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28828 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|21.11.00 |21.11.00,21.05.03 released in| | --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28828 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|21.11.00,21.05.03 |21.11.00,21.05.03,20.11.09 released in| | --- Comment #14 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28828 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |victor@tuxayo.net Status|Pushed to oldstable |RESOLVED --- Comment #15 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28828 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 28738 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org