https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42335 --- Comment #1 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 198309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198309&action=edit Bug 42335: Add accessible labels to catalog search dropdown and cart links in staff interface To test: 1. Go to the staff interface main page 2. Inspect the top menu (#toplevelmenu) 3. Locate the catalog search dropdown icon and cart icon 4. Confirm both links have aria-label attributes 5. (Optional) Use a screen reader or accessibility inspector to verify labels are announced 6. Sign off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42335 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198309|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42335 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|25.05 |Main Severity|enhancement |normal Text to go in the| |This adds missing aria release notes| |labels to the staff | |interface header search | |dropdown menu and the cart. | |This means that screen | |readers get more | |information instead of just | |"link". CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Testing notes (using KTD and axe devTools in the browser): 1. axe DevTools shows an issue for search dropdown menu (Links must have discernible text). 2. After the patch, it is no longer shown as an issue. 3. axe DevTools doesn't identify any issues for the cart link (which shows you can't rely on automated tests completely). Change to a normal bug instead of an enhancement. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42335 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Brendan Lawlor <blawlor@clamsnet.org> --- I used NVDA to test. Before the patch: The search drop down is announced as 'button collapsed' After patch: The search drop down is announced as 'Show search options button collapsed' This fix is satisfactory, but there is still an issue with the shopping cart link. Before patch: The Cart link is announced as 'same page link' After using the cart the link is announced with the basket count like '3 same page link' or '0 same page link' After patch: The cart link is announced as 'View cart same page link' After using the cart the visual basket count is updated but it's not accessible to screen readers, it's always just announced as 'View cart same page link' The aria-label "View cart" overrides all inner content, which includes the basket count. That fails WCAG 2.1 Success Criterion 1.3.1 Info and Relationships because meaningful information is not accessible to screen readers. It's also a possible fail of WCAG 2.5.3 Label in Name Because the visual label does not match the accessible name Possible solution: Use a span with class sr-only, so that the accessible name becomes "3 items in cart link" which matches the visible information. <a class="nav-link" href="/cgi-bin/koha/basket/basket.pl?" id="cartmenulink"> <i class="fa fa-shopping-cart" aria-hidden=""true"></i> <span id="basketcount"> (0)</span> <span class="sr-only">items in cart</span> </a> This solution is nice because it doesn't depend on javascript. The other option would be to use the aria-label like you used but it would also have to be updated when basket.js updates the basketcount. I added (0) because the basket.js does not set the 0 until after you've used the cart the first time. Also I included the base url for the link to bring up another accessibility issue of using href="#". It's common in Koha for components that are controlled by javascript. The problem is the user expects a same page link, so it should not load a new page, open a new window or trigger an action. I am going to file a bug for that issue because it's really outside the scop of this one. In this case js opens the cart in a new window so it might be nice to include "(opens in a new window)" so the user can predict the context change. In this case this link is a little weird because when there's nothing in the cart it doesn't behave like a link, and the -- You are receiving this mail because: You are watching all bug changes.