[Bug 13364] New: Add a call number browser in item edition page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Bug ID: 13364 Summary: Add a call number browser in item edition page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: gmcharlt@gmail.com Reporter: simith.doliveira@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl When editing an item, the call number browser search for existing call number. If it shows a line is green between two call numbers, the call numbers searched is available. If the call number is highlighted in red, it means that it already exists. This can be used to avoid repeated call numbers in your collection. The call number browser also shows its position relative to the rest of the collection. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |simith.doliveira@inlibro.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored --- Comment #1 from simith.doliveira@inlibro.com --- Sponsored-by: CCSR ( http://www.ccsr.qc.ca ) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 --- Comment #2 from simith.doliveira@inlibro.com --- Created attachment 34041 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34041&action=edit Add a call number browser in item edition page -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 --- Comment #3 from simith.doliveira@inlibro.com --- To test : 1) Go to MARC bibliographic framework Home › Administration › MARC frameworks 2) Click in MARC structure (Default framework) 3) Search field 952 and click in subfields 4) Edit subfield o (Full call number) 5) Click Display more constraints 6) In Others Options, Plugin, Choose callnumber.pl and save changes 7) Search a record and edit its items Validate : three points (…) beside Full call number input 8) Click in … Validate : if it can not find the given call number, a green line is shown. Otherwise, the given call number is highlighted in red. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 Status|NEW |Needs Signoff CC| |eric.begin@inLibro.com, | |marjorie.barry-vila@ccsr.qc | |.ca, | |philippe.blouin@inlibro.com Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |paola.rossi@cineca.it --- Comment #4 from Paola Rossi <paola.rossi@cineca.it> --- I've applied the patch. Everything is OK until the 7-th step [included]. At 8) step, nothing happened. When my mouse is over the three points, I saw "Tag editor". I was on editing an already existent Y item for the X biblio: koha/cataloguing/additem.pl?op=edititem&biblionumber=X&itemnumber=Y#edititem&searchid=scs_1417518371030 So I pass the patch to "Failed QA" status. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #5 from simith.doliveira@inlibro.com --- Sorry Paola my bad, in 6) Choose cn_browser.pl not callnumber.pl as I wrote. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #6 from Paola Rossi <paola.rossi@cineca.it> --- I've applied the patch (head 12123). Simith says:
in 6) Choose cn_browser.pl not callnumber.pl as I wrote.
Thanks! So the "Call Numbers browser" pop-up has been opened as required. Choosing a full call number < MIN [or choosing a full call number > MAX], I saw no green row at the top of the table [or at the bottom of the table]. I think this is an error. So I pass the patch to "Failed QA" status. NB1. I've searched a value by the "Search call number:" input field, selecting "Search". I saw the error: An error has occurred! Error 404 This error means that the link was broken and that the page doesn't exist To report this error, you can email the Koha administrator. Use top menu bar to navigate to another part of Koha. NB2. In the Call numbers table : 10 has been listed before 2 10 has been listed before 1. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 --- Comment #7 from simith.doliveira@inlibro.com --- Created attachment 34108 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34108&action=edit fix patch - search call number does not work -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 --- Comment #8 from simith.doliveira@inlibro.com --- Created attachment 34109 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34109&action=edit fix patch - searching call number < MIN or > MAX -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #9 from simith.doliveira@inlibro.com --- Both problems (comment 6) should be corrected with the patches. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #10 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Preliminary QA comment: function Clic$function_name(i) { q = \$('[id^= \"tag_952_subfield_o\"]').val(); window.open(\"../cataloguing/plugin_launcher.pl?plugin_name=cn_browser.pl&popup&q=\"+q,\"cnbrowser\",\"width=500,height=400,toolbar=false,scrollbars=yes\"); Please do not do it like that. Now you hardcoded the field while it is passed to you in a parameter. Also normally we pass index and value to the plugin in the URL. If you include your parameter i in the URL with something like index=i you can do this: var q=\$('#'+i).val(); window.open(... index="+i+"& ... ) And if you pass index via sub plugin to the template too, you can use it there if needed also. (In a popup you would use it when putting back the value in the field.) Also I am not sure what you are doing with the 'popup' parameter. You put it in the URL without a value. Later you are checking the value of popup. This is actually useless? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|String patch |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 --- Comment #11 from simith.doliveira@inlibro.com --- Created attachment 34476 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34476&action=edit sub plugin_javascript adjust -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #12 from simith.doliveira@inlibro.com --- function function Clic$function_name(i) changed -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34041|0 |1 is obsolete| | --- Comment #13 from Paola Rossi <paola.rossi@cineca.it> --- Created attachment 34540 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34540&action=edit Bug 13364 - Add a call number browser in item edition page I've applied the patches against 3.19.00.000 head 13449 Everything is OK. I pass the patch to "Signed Off" status. NB: It has not been explicitly expressed by the usual sorting icons (2 vertical arrows), that the table was sortable selecting its 3 columns' titles: "Call Number", "Title", "Branch". So the user could miss that the resulting table was sortable. Anyway, if the user selected one of the 3 titles: - if the input value had been found (table with a red row with the shown value), the resulting sorted table was OK - otherwise, the green row lost its right position in the resulting sorted table. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34108|0 |1 is obsolete| | --- Comment #14 from Paola Rossi <paola.rossi@cineca.it> --- Created attachment 34541 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34541&action=edit Bug 13364 - fix patch - search call number does not work -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34109|0 |1 is obsolete| | --- Comment #15 from Paola Rossi <paola.rossi@cineca.it> --- Created attachment 34542 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34542&action=edit Bug 13364 - fix patch - searching call number < MIN or > MAX -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34476|0 |1 is obsolete| | --- Comment #16 from Paola Rossi <paola.rossi@cineca.it> --- Created attachment 34543 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34543&action=edit Bug 13364 - sub plugin_javascript adjust -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34540|0 |1 is obsolete| | Attachment #34541|0 |1 is obsolete| | Attachment #34542|0 |1 is obsolete| | Attachment #34543|0 |1 is obsolete| | --- Comment #17 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34586 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34586&action=edit [PASSED QA] Create a link to the last advanced search in search result page (OPAC) http://bugs.koha-community.org/show_bug.cgi?id=13307 Followed test plan, works as expected (together with other patches) Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 --- Comment #18 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34587 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34587&action=edit [PASSED QA] Fix Patch- Search boxes disappear when returning to advanced search http://bugs.koha-community.org/show_bug.cgi?id=13307 Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 --- Comment #19 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34588 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34588&action=edit [PASSED QA] Fix jquery.deseriable.min.js http://bugs.koha-community.org/show_bug.cgi?id=13307 Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 --- Comment #20 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34589 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34589&action=edit [PASSED QA] Bug 13307 [QA Followup] Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34540|1 |0 is obsolete| | CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34541|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34542|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34543|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34586|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34587|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34588|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34589|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Severity|normal |enhancement -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 --- Comment #21 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35067 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35067&action=edit Bug 13364 - QA Followup -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #22 from Jonathan Druart <jonathan.druart@biblibre.com> --- Kyle, Does this pass qa? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 --- Comment #23 from Jonathan Druart <jonathan.druart@biblibre.com> --- Note: The tablesorter jquery plugin has been removed from the src. Does not it possible to do the same thing using DataTables? +<table style="margin: auto;width:90%;" id="course_reserves"> => This is wrong -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, well spotted. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I asked Owen on IRC and he confirmed that we have removed the tablesorter plugin - I think we should avoid adding it back and having different implementations. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 --- Comment #26 from simith.doliveira@inlibro.com --- Created attachment 35549 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35549&action=edit Bug 13364 - fix tablesorter and squash When editing an item, the call number browser search for existing call number. If it shows a line is green between two calli numbers, the call numbers searched is available. If the call number is highlighted in red, it means that it already exists. This can be used to avoid repeated call numbers in your collection. The call number browser also shows its position relative to the rest of the collection. Sponsored-by: CCSR To test : 1) Go to MARC bibliographic framework Home › Administration › MARC frameworks 2) Click in MARC structure (Default framework) 3) Search field 952 and click in subfields 4) Edit subfield o (Full call number) 5) Click Display more constraints 6) In Others Options, Plugin, Choose callnumber.pl and save changes 7) Search a record and edit its items Validate : three points (…) beside Full call number input 8) Click in … Validate : if it can not find the given call number, a green line is shown. Otherwise, the given call number is highlighted in red. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34540|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34541|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34542|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34543|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35067|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35549|0 |1 is obsolete| | --- Comment #27 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 36194 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36194&action=edit Bug 13364 - fix tablesorter and squash Easy conflict on the css file fixed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #28 from Marc Véron <veron@veron.ch> --- I followed the test plan (comment #26) Selected callnumber.pl in step #6 -> did not work Selected cn_browser.pl in step #6 -> worked, shows Call Numbers browser Questions & remarks: 1) Is callnumber.pl obsolete? 2) Breadcrumb navigation and language selection appear in "Call number browser": I think this is not necessary in a popup window. 3) Capitalization of title? (Should be "Call numbers browser" instead of "Call Numbers browser") -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36194|0 |1 is obsolete| | --- Comment #29 from simith.doliveira@inlibro.com --- Created attachment 36235 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36235&action=edit Bug 13364 - fix tablesorter and squash When editing an item, the call number browser search for existing call number. If it shows a line is green between two calli numbers, the call numbers searched is available. If the call number is highlighted in red, it means that it already exists. This can be used to avoid repeated call numbers in your collection. The call number browser also shows its position relative to the rest of the collection. Sponsored-by: CCSR To test : 1) Go to MARC bibliographic framework Home › Administration › MARC frameworks 2) Click in MARC structure (Default framework) 3) Search field 952 and click in subfields 4) Edit subfield o (Full call number) 5) Click Display more constraints 6) In Others Options, Plugin, Choose cn_browser.pl and save changes 7) Search a record and edit its items Validate : three points (…) beside Full call number input 8) Click in … Validate : if it can not find the given call number, a green line is shown. Otherwise, the given call number is highlighted in red. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 --- Comment #30 from simith.doliveira@inlibro.com --- Corrections : 1) Breadcrumb navigation and language selection removed; 2) Title changed ("Call numbers browser" instead of "Call Numbers browser"); 3) Test texte correction : 6) cn_browser.pl instead of callnumber.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 --- Comment #31 from Marc Véron <veron@veron.ch> --- Created attachment 36249 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36249&action=edit [Signed-off] Bug 13364 - Add a call number browser in item edition page When editing an item, the call number browser search for existing call number. If it shows a line is green between two calli numbers, the call numbers searched is available. If the call number is highlighted in red, it means that it already exists. This can be used to avoid repeated call numbers in your collection. The call number browser also shows its position relative to the rest of the collection. Sponsored-by: CCSR To test : 1) Go to MARC bibliographic framework Home › Administration › MARC frameworks 2) Click in MARC structure (Default framework) 3) Search field 952 and click in subfields 4) Edit subfield o (Full call number) 5) Click Display more constraints 6) In Others Options, Plugin, Choose cn_browser.pl and save changes 7) Search a record and edit its items Validate : three points (…) beside Full call number input 8) Click in … Validate : if it can not find the given call number, a green line is shown. Otherwise, the given call number is highlighted in red. Followed test plan. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36235|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |brendan@bywatersolutions.co | |m --- Comment #32 from Brendan Gallagher <brendan@bywatersolutions.com> --- FAIL koha-tmpl/intranet-tmpl/prog/en/modules/tools/cn_browser.tt FAIL forbidden patterns forbidden pattern: To include datatables files, please use the include file (see bug 10868) (line 12) OK tt_valid OK valid_template -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 --- Comment #33 from simith.doliveira@inlibro.com --- Created attachment 36431 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36431&action=edit fix datatables.inc -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #34 from simith.doliveira@inlibro.com --- QA corrected -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36249|0 |1 is obsolete| | --- Comment #35 from Magnus Enger <magnus@enger.priv.no> --- Created attachment 36596 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36596&action=edit Bug 13364 - Add a call number browser in item edition page When editing an item, the call number browser search for existing call number. If it shows a line is green between two calli numbers, the call numbers searched is available. If the call number is highlighted in red, it means that it already exists. This can be used to avoid repeated call numbers in your collection. The call number browser also shows its position relative to the rest of the collection. Sponsored-by: CCSR To test : 1) Go to MARC bibliographic framework Home › Administration › MARC frameworks 2) Click in MARC structure (Default framework) 3) Search field 952 and click in subfields 4) Edit subfield o (Full call number) 5) Click Display more constraints 6) In Others Options, Plugin, Choose cn_browser.pl and save changes 7) Search a record and edit its items Validate : three points (…) beside Full call number input 8) Click in … Validate : if it can not find the given call number, a green line is shown. Otherwise, the given call number is highlighted in red. Followed test plan. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Magnus <magnus@enger.priv.no> Works as advertised. QA scripts pass. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36596|0 |1 is obsolete| | --- Comment #36 from Magnus Enger <magnus@enger.priv.no> --- Created attachment 36597 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36597&action=edit Bug 13364 - Add a call number browser in item edition page When editing an item, the call number browser search for existing call number. If it shows a line is green between two calli numbers, the call numbers searched is available. If the call number is highlighted in red, it means that it already exists. This can be used to avoid repeated call numbers in your collection. The call number browser also shows its position relative to the rest of the collection. Sponsored-by: CCSR To test : 1) Go to MARC bibliographic framework Home › Administration › MARC frameworks 2) Click in MARC structure (Default framework) 3) Search field 952 and click in subfields 4) Edit subfield o (Full call number) 5) Click Display more constraints 6) In Others Options, Plugin, Choose cn_browser.pl and save changes 7) Search a record and edit its items Validate : three points (…) beside Full call number input 8) Click in … Validate : if it can not find the given call number, a green line is shown. Otherwise, the given call number is highlighted in red. Followed test plan. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Magnus <magnus@enger.priv.no> Works as advertised. QA scripts pass. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36597|0 |1 is obsolete| | --- Comment #37 from Magnus Enger <magnus@enger.priv.no> --- Created attachment 36598 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36598&action=edit Bug 13364 - Add a call number browser in item edition page When editing an item, the call number browser search for existing call number. If it shows a line is green between two calli numbers, the call numbers searched is available. If the call number is highlighted in red, it means that it already exists. This can be used to avoid repeated call numbers in your collection. The call number browser also shows its position relative to the rest of the collection. Sponsored-by: CCSR To test : 1) Go to MARC bibliographic framework Home › Administration › MARC frameworks 2) Click in MARC structure (Default framework) 3) Search field 952 and click in subfields 4) Edit subfield o (Full call number) 5) Click Display more constraints 6) In Others Options, Plugin, Choose cn_browser.pl and save changes 7) Search a record and edit its items Validate : three points (…) beside Full call number input 8) Click in … Validate : if it can not find the given call number, a green line is shown. Otherwise, the given call number is highlighted in red. Followed test plan. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Magnus <magnus@enger.priv.no> Works as advertised. QA scripts pass. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36598|0 |1 is obsolete| | --- Comment #38 from Magnus Enger <magnus@enger.priv.no> --- Created attachment 36599 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36599&action=edit Bug 13364 - Add a call number browser in item edition page When editing an item, the call number browser search for existing call number. If it shows a line is green between two calli numbers, the call numbers searched is available. If the call number is highlighted in red, it means that it already exists. This can be used to avoid repeated call numbers in your collection. The call number browser also shows its position relative to the rest of the collection. Sponsored-by: CCSR To test : 1) Go to MARC bibliographic framework Home › Administration › MARC frameworks 2) Click in MARC structure (Default framework) 3) Search field 952 and click in subfields 4) Edit subfield o (Full call number) 5) Click Display more constraints 6) In Others Options, Plugin, Choose cn_browser.pl and save changes 7) Search a record and edit its items Validate : three points (…) beside Full call number input 8) Click in … Validate : if it can not find the given call number, a green line is shown. Otherwise, the given call number is highlighted in red. Followed test plan. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Magnus <magnus@enger.priv.no> Works as advertised. QA scripts pass. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36599|0 |1 is obsolete| | --- Comment #39 from Magnus Enger <magnus@enger.priv.no> --- Created attachment 36600 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36600&action=edit Bug 13364 - Add a call number browser in item edition page When editing an item, the call number browser search for existing call number. If it shows a line is green between two calli numbers, the call numbers searched is available. If the call number is highlighted in red, it means that it already exists. This can be used to avoid repeated call numbers in your collection. The call number browser also shows its position relative to the rest of the collection. Sponsored-by: CCSR To test : 1) Go to MARC bibliographic framework Home › Administration › MARC frameworks 2) Click in MARC structure (Default framework) 3) Search field 952 and click in subfields 4) Edit subfield o (Full call number) 5) Click Display more constraints 6) In Others Options, Plugin, Choose cn_browser.pl and save changes 7) Search a record and edit its items Validate : three points (…) beside Full call number input 8) Click in … Validate : if it can not find the given call number, a green line is shown. Otherwise, the given call number is highlighted in red. Followed test plan. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Magnus <magnus@enger.priv.no> Works as advertised. QA scripts pass. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36431|0 |1 is obsolete| | Attachment #36600|0 |1 is obsolete| | --- Comment #40 from Magnus Enger <magnus@enger.priv.no> --- Created attachment 36601 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36601&action=edit Bug 13364 - fix datatables.inc http://bugs.koha-community.org/show_bug.cgi?id=13364 Signed-off-by: Magnus <magnus@enger.priv.no> Works as advertised. QA scripts pass. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@enger.priv.no --- Comment #41 from Magnus Enger <magnus@enger.priv.no> --- (Sorry about the spam with the first patch! Git bz was timing out and I didn't realize it was actually attaching the first patch...) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36600|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 --- Comment #42 from Jonathan Druart <jonathan.druart@biblibre.com> --- Comment on attachment 36600 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36600 Bug 13364 - Add a call number browser in item edition page Review of attachment 36600: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13364&attachment=36600) ----------------------------------------------------------------- Is there a good reason to have the template file in the tools directory, instead of cataloguing/value_builder? The green line is always at the top of the table. If I am remember correctly, in the previous version it was inserted correctly. ::: cataloguing/value_builder/cn_browser.pl @@ +1,4 @@
+#!/usr/bin/perl + +use strict; +use warnings;
Prefer use Modern::Perl; @@ +9,5 @@
+use C4::Output; +use POSIX; +use C4::ClassSource; +use URI::Escape; +use Data::Dumper;
No needed. ::: koha-tmpl/intranet-tmpl/prog/en/modules/tools/cn_browser.tt @@ +12,5 @@
+<script type="text/javascript" src="[% interface %]/lib/jquery/plugins/jquery.dataTables.min.js"></script> +<script language="JavaScript"> +$(document).ready(function() +{ + $("#course_reserves").DataTable({"paging": false, "bFilter": false, "info": false});
Hum? Why did you choose this id? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 --- Comment #43 from simith.doliveira@inlibro.com --- Created attachment 36723 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36723&action=edit Bug 13364 - Add a call number browser in item edition page - QA fixed -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 --- Comment #44 from simith.doliveira@inlibro.com --- Concerning #42 : Is there a good reason to have the template file in the tools directory, instead of cataloguing/value_builder? - No, Moved. The green line is always at the top of the table. If I am remember correctly, in the previous version it was inserted correctly. - Bug fixed ::: cataloguing/value_builder/cn_browser.pl @@ +1,4 @@
+#!/usr/bin/perl + +use strict; +use warnings;
Prefer use Modern::Perl; - Fixed @@ +9,5 @@
+use C4::Output; +use POSIX; +use C4::ClassSource; +use URI::Escape; +use Data::Dumper;
No needed. - Fixed. use C4::ClassSource needed ::: koha-tmpl/intranet-tmpl/prog/en/modules/tools/cn_browser.tt @@ +12,5 @@
+<script type="text/javascript" src="[% interface %]/lib/jquery/plugins/jquery.dataTables.min.js"></script> +<script language="JavaScript"> +$(document).ready(function() +{ + $("#course_reserves").DataTable({"paging": false, "bFilter": false, "info": false});
Hum? Why did you choose this id? - In intranet-tmpl/prog/en/css/staff-global.css there is "div#course_reserves_wrapper > table#course_reserves" needed to the table. So I just use it (do not change staff-global.css file). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 --- Comment #45 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to simith.doliveira from comment #44)
+ $("#course_reserves").DataTable({"paging": false, "bFilter": false, "info": false});
Hum? Why did you choose this id?
- In intranet-tmpl/prog/en/css/staff-global.css there is "div#course_reserves_wrapper > table#course_reserves" needed to the table. So I just use it (do not change staff-global.css file).
Your last patch adds it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 --- Comment #46 from simith.doliveira@inlibro.com --- (In reply to comment #45) - Your last patch adds it. Yep, you are right. I don't remember why I put "course_reserves", maybe I was working with other bz at the same time. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #47 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to simith.doliveira from comment #46)
(In reply to comment #45)
- Your last patch adds it.
Yep, you are right. I don't remember why I put "course_reserves", maybe I was working with other bz at the same time.
So please resubmit a patch with a correct id for this table. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 --- Comment #48 from simith.doliveira@inlibro.com --- Created attachment 36782 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36782&action=edit Bug 13364 - Add a call number browser in item edition page - QA fixed II -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 --- Comment #49 from Marc Véron <veron@veron.ch> --- Created attachment 37192 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37192&action=edit [Signed-off] Bug 13364 - Add a call number browser in item edition page When editing an item, the call number browser search for existing call number. If it shows a line is green between two calli numbers, the call numbers searched is available. If the call number is highlighted in red, it means that it already exists. This can be used to avoid repeated call numbers in your collection. The call number browser also shows its position relative to the rest of the collection. Sponsored-by: CCSR To test : 1) Go to MARC bibliographic framework Home › Administration › MARC frameworks 2) Click in MARC structure (Default framework) 3) Search field 952 and click in subfields 4) Edit subfield o (Full call number) 5) Click Display more constraints 6) In Others Options, Plugin, Choose cn_browser.pl and save changes 7) Search a record and edit its items Validate : three points (…) beside Full call number input 8) Click in … Validate : if it can not find the given call number, a green line is shown. Otherwise, the given call number is highlighted in red. Followed test plan. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Magnus <magnus@enger.priv.no> Works as advertised. QA scripts pass. Tested together with other patches. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36600|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36601|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36601|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 --- Comment #50 from Marc Véron <veron@veron.ch> --- Created attachment 37193 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37193&action=edit [Signed-off] Bug 13364 - fix datatables.inc http://bugs.koha-community.org/show_bug.cgi?id=13364 Signed-off-by: Magnus <magnus@enger.priv.no> Works as advertised. QA scripts pass. Tested together with other patches, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36601|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 --- Comment #51 from Marc Véron <veron@veron.ch> --- Created attachment 37194 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37194&action=edit [Signed-off] Bug 13364 - Add a call number browser in item edition page - QA fixed Tested together with other patches. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36723|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 --- Comment #52 from Marc Véron <veron@veron.ch> --- Created attachment 37195 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37195&action=edit [Signed-off] Bug 13364 - Add a call number browser in item edition page - QA fixed II Tested together with oter patches. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36782|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com Summary|Add a call number browser |Add a call number browser |in item edition page |to add item page -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 --- Comment #53 from Jonathan Druart <jonathan.druart@biblibre.com> --- Comment on attachment 37195 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37195 [Signed-off] Bug 13364 - Add a call number browser in item edition page - QA fixed II Review of attachment 37195: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13364&attachment=37195) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/cn_browser.tt @@ +34,4 @@
</div> <br />
+<table id="cn_browser_table">
Yes fine, but a previous patch changed the css file and you don't update it here... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |jonathan.druart@biblibre.co |y.org |m --- Comment #54 from Jonathan Druart <jonathan.druart@biblibre.com> --- I will submit a follow-up if it's ready. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37192|0 |1 is obsolete| | Attachment #37193|0 |1 is obsolete| | Attachment #37194|0 |1 is obsolete| | Attachment #37195|0 |1 is obsolete| | --- Comment #55 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 38010 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38010&action=edit Bug 13364 - Add a call number browser in item edition page When editing an item, the call number browser search for existing call number. If it shows a line is green between two calli numbers, the call numbers searched is available. If the call number is highlighted in red, it means that it already exists. This can be used to avoid repeated call numbers in your collection. The call number browser also shows its position relative to the rest of the collection. Sponsored-by: CCSR To test : 1) Go to MARC bibliographic framework Home › Administration › MARC frameworks 2) Click in MARC structure (Default framework) 3) Search field 952 and click in subfields 4) Edit subfield o (Full call number) 5) Click Display more constraints 6) In Others Options, Plugin, Choose cn_browser.pl and save changes 7) Search a record and edit its items Validate : three points (…) beside Full call number input 8) Click in … Validate : if it can not find the given call number, a green line is shown. Otherwise, the given call number is highlighted in red. Followed test plan. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Magnus <magnus@enger.priv.no> Works as advertised. QA scripts pass. Tested together with other patches. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Bug 13364 - fix datatables.inc http://bugs.koha-community.org/show_bug.cgi?id=13364 Signed-off-by: Magnus <magnus@enger.priv.no> Works as advertised. QA scripts pass. Tested together with other patches, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Bug 13364 - Add a call number browser in item edition page - QA fixed Tested together with other patches. Signed-off-by: Marc Véron <veron@veron.ch> Bug 13364 - Add a call number browser in item edition page - QA fixed II Tested together with oter patches. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 --- Comment #56 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 38011 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38011&action=edit Bug 13364: Fix table id + software error change table id in css file + C4::Output is used (Undefined subroutine CGI::output_html_with_http_headers) Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #57 from Jonathan Druart <jonathan.druart@biblibre.com> --- I squashed the 4 patches (add + mv of the file in the same patch set) and perltidy on it. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 --- Comment #58 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 38018 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38018&action=edit Bug 13364: Remove unused JS functions -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 --- Comment #59 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 38019 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38019&action=edit Bug 13364: Use SQL placeholder -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #60 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Feature pushed to master. Thanks Simith! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 --- Comment #61 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 38894 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38894&action=edit Bug 13364: (QA followup) <body> missing id and class Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14737 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14737 [Bug 14737] Can't use cn_browser.pl cataloguing plugin without superlibrarian permissions -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13364 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org