http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8376 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8376 Gaetan Boisson <gaetan.boisson@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |gaetan.boisson@biblibre.com --- Comment #3 from Gaetan Boisson <gaetan.boisson@biblibre.com> --- Tested various exciting possiblities : - Exporting borrowers with or without headers - Exporting data with commas inside the fields - Exporting a specified set of fields - Specifying a field that doesn't exist (you'll just get an empty column in the csv) It all works really well. Signing off! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8376 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED CC| |robin@catalyst.net.nz --- Comment #4 from Robin Sheat <robin@catalyst.net.nz> --- Found an issue: if a record contains an invalid character (e.g. a newline), a blank line is output. It's possible to see that something went wrong by noting that $csv->string is empty/undefined. It's also possible to make it deal with these by putting {binary=>1} in the contructor for Text::CSV. I've added some code to improve handling of funny data, and announcing that something is wrong when it can't be handled. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8376 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8376 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA Comments: Works well, code clean. Marking as Passed QA. It would be great to specify a list of borrowernumber (or cardnumber) to export (with a file given in parameter for example). -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8376 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_10 --- Comment #7 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: passes perlcritic (In reply to comment #6)

It would be great to specify a list of borrowernumber (or cardnumber) to export (with a file given in parameter for example).

Other possible enhancements : * provide the separator in a parameter * add a WHERE clause to filter, for example, on a given zipcode, categorycode, email,... Another comment: we don't have a coding guideline for that, but I think we should: the help should be in POD, like what we have, for example, in: misc/maintenance/touch_all_biblios.pl use Pod::Usage; sub usage { pod2usage( -verbose => 2 ); exit; } i'll send a mail to koha-devel to propose this rule. Patch pushed, though -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8376 Sophie MEYNIEUX <sophie.meynieux@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |9045 -- You are receiving this mail because: You are watching all bug changes.