[Bug 33373] New: Use template wrapper for breadcrumbs: Circulation part 3
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33373 Bug ID: 33373 Summary: Use template wrapper for breadcrumbs: Circulation part 3 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Depends on: 32507 To continue the process started by Bug 32507, this patch will update more circulation templates so that they use the new template wrapper for breadcrumbs. - circ/request-article.tt - circ/reserveratios.tt - circ/returns.tt - circ/set-library.tt - circ/transfers_to_send.tt - circ/transferstoreceive.tt - circ/view_holdsqueue.tt - circ/waitingreserves.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32507 [Bug 32507] Use template wrapper to build breadcrumb navigation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33373 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33373 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 149036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149036&action=edit Bug 33373: Use template wrapper for breadcrumbs: Circulation part 3 This patch updates several circulation templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Circulation -> - Article requests -> Article request detail - Check in - Hold ratios - Transfers to send - Transfers to receive - Holds queue - Holds awaiting pickup - Set library -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33373 Andrew Auld <andrew.auld@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew.auld@ptfs-europe.com --- Comment #2 from Andrew Auld <andrew.auld@ptfs-europe.com> --- I can't complete this test as the 'Hold ratios' link throws the following error: CGI::Compile::ROOT::kohadevbox_koha_circ_reserveratios_2epl::reserveratios_2epl(): DBI Exception: DBD::mysql::st execute failed: 'koha_bug33158.reserves.reservedate' isn't in GROUP BY at /usr/share/perl5/CGI/Emulate/PSGI.pm line 30 at /usr/share/perl5/DBIx/Class/Exception.pm line 77 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33373 --- Comment #3 from Andrew Auld <andrew.auld@ptfs-europe.com> --- Everything else is tested and is fine for sign-off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33373 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Andrew Auld from comment #2)
I can't complete this test as the 'Hold ratios' link throws the following error:
CGI::Compile::ROOT::kohadevbox_koha_circ_reserveratios_2epl:: reserveratios_2epl(): DBI Exception: DBD::mysql::st execute failed
There is a bug with the hold ratios report when SQL mode is set to "Strict," which you can get around if you have access to editing koha-conf.xml bug not if you're using a sandbox -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33373 --- Comment #5 from Andrew Auld <andrew.auld@ptfs-europe.com> --- Aha, sorry. I am using sandboxes. I'll have to leave to someone able to test not on a sandbox. As I say, the rest works. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33373 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33373 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149036|0 |1 is obsolete| | --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 149098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149098&action=edit Bug 33373: Use template wrapper for breadcrumbs: Circulation part 3 This patch updates several circulation templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Circulation -> - Article requests -> Article request detail - Check in - Hold ratios - Transfers to send - Transfers to receive - Holds queue - Holds awaiting pickup - Set library Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33373 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33373 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149098|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 149312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149312&action=edit Bug 33373: Use template wrapper for breadcrumbs: Circulation part 3 This patch updates several circulation templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Circulation -> - Article requests -> Article request detail - Check in - Hold ratios - Transfers to send - Transfers to receive - Holds queue - Holds awaiting pickup - Set library Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33373 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33373 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33373 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33373 --- Comment #9 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org