https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42778 Bug ID: 42778 Summary: Editing SIP configuration through staff interface can silently change default behavior on upgraded systems Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: emily.lamancusa@montgomerycountymd.gov QA Contact: testopia@bugs.koha-community.org Depends on: 37839 I noticed and confirmed this bug for the setting "Holds get captured", but I'm not sure if it affects other settings as well. Before bug 37893, if a SIP account did not have a value defined in koha-conf for holds_get_captured, the default behavior was to capture holds. However, the staff interface editor for SIP accounts only has the options "Yes" and "No", and when the page loads, it selects the "No" radio button if the value is undefined. As a result, if a staff administrator edits any other field of the SIP account and saves changes, that undefined value (which previously did capture holds) gets silently set to "no", don't capture holds. I can confirm that the following settings do *not* have this bug, as the default behavior is "No" if the setting is undefined: allow additional materials checkout allow empty passwords format due date holds block checkin block previous checkout I'm not sure about the following settings - they should be tested: checked in ok CT always send CV always send 00 on success CV triggers alert disallow overpayment error detect overdues block checkout send patron home library in AF show checkin message show outstanding amount It would probably be safest to explicitly set the default values for these yes/no fields on upgrade (including the ones whose default is already "no" for future-proofing), as well as add a database update to main to set any undefined values to the correct defaults. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37839 [Bug 37839] /api endpoint stops working on strict firewall -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.