[Bug 41575] New: Tidy kohaTable block - pos
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41575 Bug ID: 41575 Summary: Tidy kohaTable block - pos Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41575 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41324 QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | Status|NEW |ASSIGNED Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41324 [Bug 41324] Tidy kohaTable block -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41575 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41575 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 191145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191145&action=edit Bug 41575: Tidy kohaTable - pos/pay.tt Patch from commit 3cc2f0c -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41575 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 191146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191146&action=edit Bug 41575: Tidy kohaTable - pos/register.tt Patch from commit 9dad5bf -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41575 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 191147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191147&action=edit Bug 41575: Tidy kohaTable - pos/registers.tt Patch from commit 935d4cd -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41575 --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 191148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191148&action=edit Bug 41575: pos - auto tidy Patch from commit fa9c00d -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41575 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |39715 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39715 [Bug 39715] Do not quote DataTables options -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41575 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |41562 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41562 [Bug 41562] Introduce the concept of "stores" for regular javascript -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41575 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41575 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191145|0 |1 is obsolete| | Attachment #191146|0 |1 is obsolete| | Attachment #191147|0 |1 is obsolete| | Attachment #191148|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 191410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191410&action=edit Bug 41575: Tidy kohaTable - pos/pay.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41575 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 191411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191411&action=edit Bug 41575: Tidy kohaTable - pos/register.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41575 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 191412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191412&action=edit Bug 41575: Tidy kohaTable - pos/registers.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41575 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 191413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191413&action=edit Bug 41575: pos - auto tidy Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41575 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191410|0 |1 is obsolete| | --- Comment #9 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 192371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192371&action=edit Bug 41575: Tidy kohaTable - pos/pay.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41575 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191411|0 |1 is obsolete| | --- Comment #10 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 192372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192372&action=edit Bug 41575: Tidy kohaTable - pos/register.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41575 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191412|0 |1 is obsolete| | --- Comment #11 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 192373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192373&action=edit Bug 41575: Tidy kohaTable - pos/registers.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41575 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191413|0 |1 is obsolete| | --- Comment #12 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 192374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192374&action=edit Bug 41575: pos - auto tidy Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41575 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41575 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192371|0 |1 is obsolete| | --- Comment #13 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 194766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194766&action=edit Bug 41575: Tidy kohaTable - pos/pay.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41575 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192372|0 |1 is obsolete| | --- Comment #14 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 194767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194767&action=edit Bug 41575: Tidy kohaTable - pos/register.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41575 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192373|0 |1 is obsolete| | --- Comment #15 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 194768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194768&action=edit Bug 41575: Tidy kohaTable - pos/registers.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41575 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192374|0 |1 is obsolete| | --- Comment #16 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 194769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194769&action=edit Bug 41575: pos - auto tidy Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41575 --- Comment #17 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 194770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194770&action=edit Bug 41575: (QA follow-up) Fix register description interpolation in cashup modal - The tidy replaced TT interpolation with a JS template literal expression but left it inside single quotes instead of using backticks or string concatenation - This caused the cashup confirmation dialog to show "Confirm cashup of" with no register name - The incorrect syntax also silently swallowed quote formatting that the auto tidy would normally have applied - Use string concatenation to match the surrounding code style Test plan: - Go to Point of sale, make a sale - Navigate to Cash summary - Click "Record cashup" on a register row - Verify the dialog says "Confirm cashup of <register name>" instead of "Confirm cashup of" Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41575 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41575 --- Comment #18 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41575 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |jacob.omara@openfifth.co.uk --- Comment #19 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Enhancement, not backporting. Scream at me if you feel strongly it should be backported. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org