[Bug 5788] New: Move ReservesMaxPickupDelay system preference to the Circulation Matrix.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5788 Bug #: 5788 Summary: Move ReservesMaxPickupDelay system preference to the Circulation Matrix. Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_4 Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Hold requests AssignedTo: kyle.m.hall@gmail.com ReportedBy: chris@bigballofwax.co.nz QAContact: koha-bugs@lists.koha-community.org CC: gmcharlt@gmail.com Blocks: 5609 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5788 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|kyle.m.hall@gmail.com |srdjan@catalyst.net.nz --- Comment #1 from Srdjan Jankovic <srdjan@catalyst.net.nz> 2011-07-22 07:24:46 UTC --- Created attachment 4711 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4711 patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5788 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5788 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent CC| |nengard@gmail.com Patch Status|--- |Failed QA --- Comment #2 from Nicole C. Engard <nengard@gmail.com> 2011-07-22 17:00:19 UTC --- The same as bug 5786 - the new column is there, but I can't save or add any changes to the circ matrix anymore. Also, if I read the code right, shouldn't there be an update database to remove the system preference? Nicole -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5788 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Failed QA |Needs Signoff --- Comment #3 from Nicole C. Engard <nengard@gmail.com> 2011-07-22 17:02:31 UTC --- Oops - I applied it wrong :) Will try again. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5788 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Failed QA --- Comment #4 from Nicole C. Engard <nengard@gmail.com> 2011-07-22 17:17:31 UTC --- Okay, after applying properly I can't add a new rule anymore after this is applied. I also can't update existing rules the way I used to. Nicole -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5788 --- Comment #5 from Srdjan Jankovic <srdjan@catalyst.net.nz> 2011-07-27 06:17:38 UTC --- Note: this has a database patch. Be sure to edit the updatedatabase.pl version numbers to make it apply, or alternatively run ALTER TABLE issuingrules ADD reservesmaxpickupdelay INTEGER; against the database -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5788 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Failed QA |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5788 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Failed QA --- Comment #6 from Nicole C. Engard <nengard@gmail.com> 2011-08-01 13:14:40 UTC --- I had done the database update the first time. I tried again just now and I can edit rules, but I can't add new rules with this patch. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5788 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4711|0 |1 is obsolete| | --- Comment #7 from Srdjan Jankovic <srdjan@catalyst.net.nz> 2011-08-02 03:34:40 UTC --- Created attachment 4807 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4807 patch Wrong merge with Rental Discount patch. Rebased. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5788 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Failed QA |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5788 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com Depends on| |5872 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5788 --- Comment #8 from Paul Poulain <paul.poulain@biblibre.com> 2011-08-02 03:54:25 UTC --- this feature is also included in 5872 (Enhancements to circulation management) 5872 does a lot more than just ReservesMaxPickupDelay to the Circulation Matrix: it also manage how many holds can be placed, and hold rules (on shelf yes/no and hold for patron of this branch only). -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5788 --- Comment #9 from Nicole C. Engard <nengard@gmail.com> 2011-08-02 04:23:34 UTC --- Srdjan, The patch applies and the rules are added just fine now, but I'm not sure how to test that it's actually working. Can you give me instructions for testing? I set a rule and then I confirmed a hold on the item. I then went in to the DB and changed the waiting date to be after before the number of days I set the max pickup delay to. I then checked the holds waiting pick up report and it did not move the hold to the holds over tab - that to me says it's not working, but I might not be testing right. A test plan would help me confirm that this works or doesn't work. Nicole -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5788 --- Comment #10 from Srdjan Jankovic <srdjan@catalyst.net.nz> 2011-08-02 04:44:55 UTC --- My understanding is that 5872 is an umbrella for various circulation matrix changes. I am not sure how you want to manage it, test each feature separately or all together. I will try to find that out. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5788 --- Comment #11 from Paul Poulain <paul.poulain@biblibre.com> 2011-08-02 08:07:42 UTC --- (In reply to comment #10)
My understanding is that 5872 is an umbrella for various circulation matrix changes. I am not sure how you want to manage it, test each feature separately or all together. I will try to find that out.
It's no more an umbrella (Ask chris for more details) If you want to see what it does, look at comment 26, it describes everything -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5788 --- Comment #12 from Paul Poulain <paul.poulain@biblibre.com> 2011-08-02 08:09:30 UTC --- oups comment 23, not 26 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5788 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |5786 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5788 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_4 |Rel_3_8 --- Comment #13 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-24 11:38:12 UTC --- Updating Version : This ENH will be for Koha 3.8 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5788 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|Rel_3_8 |master --- Comment #14 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-25 15:05:47 UTC --- Bug versionned for master. entries will be made against rel_3_8 once the patch has been applied (see thread about that on koha-devel yesterday) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5788 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Patch Status|Needs Signoff |Failed QA --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-12-21 05:35:18 UTC --- Patch still applies on current master. Problems found: - no change to kohastructure Question: - why was this line removed from an older update? $dbh->do("UPDATE `systempreferences` SET type='Integer' WHERE variable='ReservesMaxPickupDelay'"); -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5788 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Failed QA |Needs Signoff --- Comment #16 from Srdjan Jankovic <srdjan@catalyst.net.nz> 2011-12-21 07:51:28 UTC --- I understand the confusion, I was confused myself. The removed line is the only place in the code where ReservesMaxPickupDelay is mentioned. Hence nothing to change, and I removed the line. As per bug 5786, if you want to test them one at the time, please decide on the order because first one to have patch pushed will invalidate testing of the other two. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5788 Bug 5788 depends on bug 5872, which changed state. Bug 5872 Summary: Enhancements to circulation (see comment 23 for details) http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5872 What |Old Value |New Value ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution| |WONTFIX -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5788 Sophie MEYNIEUX <sophie.meynieux@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sophie.meynieux@biblibre.co | |m --- Comment #17 from Sophie MEYNIEUX <sophie.meynieux@biblibre.com> 2012-02-03 16:40:18 UTC --- The patch add the column "Holds max pickup delay" in issuing rules table. I can add new rules but can't edit them I didn't find how to test how this new value is used -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5788 --- Comment #18 from Srdjan Jankovic <srdjan@catalyst.net.nz> 2012-02-06 00:50:38 UTC --- Rules cannot be edited. They can only be deleted and reentered. It is a problem, and not the only one with the issuing rules if I nay add. But that is not part of this bug and should be raised as a separate bug. As for the testing, this replaced "ReservesMaxPickupDelay" sys pref, so it should behave the same, only on the granular level. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
Rules cannot be edited. They can only be deleted and reentered. It is a problem, and not the only one with the issuing rules if I nay add. But that is not part of this bug and should be raised as a separate bug. You're right. There is something in biblibre/master that has been submitted in our very large
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5788 --- Comment #19 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-06 12:42:44 UTC --- (In reply to comment #18) patch about circulation rules, that is not outdated. In this patch, there is also something to modify a rule just by clicking on the number you want to modify. For now, it's lost and only add/delete is possible -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5788 delaye <stephane.delaye@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |stephane.delaye@biblibre.co | |m --- Comment #20 from delaye <stephane.delaye@biblibre.com> --- I have the new column in the table of holds rules ==> ok But when I return the copy who have been reserved this message Software error: Could not find a letter Called 'HOLD_PRINT' in the 'reserved' module at / home/koha/src/C4/Reserves.pm line 1740. After F5 the message disappears then the request is well recorded in table reserves but without expirationdate select * from reserves where borrowernumber='7853'\G *************************** 1. row *************************** borrowernumber: 7853 reservedate: 2012-03-13 biblionumber: 5 constrainttype: a branchcode: MAURES notificationdate: NULL reminderdate: NULL cancellationdate: NULL reservenotes: priority: 0 found: W timestamp: 2012-03-13 14:47:03 itemnumber: 67 waitingdate: 2012-03-13 expirationdate: NULL lowestPriority: 0 PS : HOLD_PRINT is in the table letter... -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5788 --- Comment #21 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- That's strange. can you please * paste the output of "select * from letter where module='reserves' and code='HOLD_PRINT';" * check what is in the apache error log after the first submission that throws an error Because the notice is the last thing that gets done the hold is successful the first time, only the server error is thrown. reserves records are always created with expirationdate null -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5788 --- Comment #22 from delaye <stephane.delaye@biblibre.com> --- log apache [Tue Mar 13 14:44:35 2012] placerequest.pl: Use of uninitialized value in string eq at /home/koha/src/reserve/p lacerequest.pl line 115. [Tue Mar 13 14:44:35 2012] placerequest.pl: Use of uninitialized value $reqbib[0] in string ne at /home/koha/sr c/reserve/placerequest.pl line 118. [Tue Mar 13 14:44:36 2012] request.pl: Use of uninitialized value in string eq at /home/koha/src/reserve/reques t.pl line 254. [Tue Mar 13 14:44:36 2012] request.pl: Use of uninitialized value in string eq at /home/koha/src/reserve/reques t.pl line 519. [Tue Mar 13 14:44:48 2012] returns.pl: DBD::mysql::st execute failed: Unknown column 'branchcode' in 'where cla use' at /home/koha/src/C4/Letters.pm line 133. [Tue Mar 13 14:44:48 2012] returns.pl: DBD::mysql::st fetchrow_hashref failed: fetch() without execute() at /ho me/koha/src/C4/Letters.pm line 134. [Tue Mar 13 14:44:48 2012] returns.pl: No circulation CHECKIN letter at /home/koha/src/C4/Letters.pm line 436. [Tue Mar 13 14:44:52 2012] returns.pl: DBD::mysql::st execute failed: Unknown column 'branchcode' in 'where cla use' at /home/koha/src/C4/Letters.pm line 133. [Tue Mar 13 14:44:52 2012] returns.pl: DBD::mysql::st fetchrow_hashref failed: fetch() without execute() at /ho me/koha/src/C4/Letters.pm line 134. [Tue Mar 13 14:44:52 2012] returns.pl: No reserves HOLD_PRINT letter at /home/koha/src/C4/Letters.pm line 436. [Tue Mar 13 14:44:52 2012] returns.pl: Could not find a letter called 'HOLD_PRINT' in the 'reserves' module at /home/koha/src/C4/Reserves.pm line 1740. [Tue Mar 13 14:46:38 2012] placerequest.pl: Use of uninitialized value in string eq at /home/koha/src/reserve/p lacerequest.pl line 115. [Tue Mar 13 14:46:38 2012] placerequest.pl: Use of uninitialized value $reqbib[0] in string ne at /home/koha/sr c/reserve/placerequest.pl line 118. [Tue Mar 13 14:46:39 2012] request.pl: Use of uninitialized value in string eq at /home/koha/src/reserve/reques ************** output "select * from letter where module='reserves' and code='HOLD_PRINT';" | reserves | HOLD_PRINT | Réservation disponible pour retrait (papier) | Réservation disponible à la banque de retrait du site <<branches.branchname>> | <<branches.branchname>> <<branches.branchaddress1>> <<branches.branchaddress2>> Le service des réservations <<borrowers.firstname>> <<borrowers.surname>> <<borrowers.address>> <<borrowers.city>> <<borrowers.zipcode>> <<borrowers.firstname>> <<borrowers.surname>> <<borrowers.cardnumber>> Votre réservation est disponible pour retrait depuis le <<reserves.waitingdate>>: Titre: <<biblio.title>> Auteur: <<biblio.author>> Numéro de fascicule: <<items.copynumber>> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5788 --- Comment #23 from delaye <stephane.delaye@biblibre.com> --- after update database i test again the patch i can't add a new rule in the table issuingrules (Administration koha/Rules Loan and hold) log apach [Thu Mar 15 14:04:51 2012] smart-rules.pl: DBD::mysql::st execute failed: Unknown column 'reservesmaxpickupdelay' in 'field list' at /home/koha/src/admin/smart-rules.pl line 132. [Thu Mar 15 14:05:23 2012] smart-rules.pl: DBD::mysql::st execute failed: Unknown column 'reservesmaxpickupdelay' in 'field list' at /home/koha/src/admin/smart-rules.pl line 132. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5788 --- Comment #24 from delaye <stephane.delaye@biblibre.com> --- I can 't apply in a sandbox for test i have this message Applying: bug_5788: Moved ReservesMaxPickupDelay syspref to issue rules Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging admin/smart-rules.pl Auto-merging installer/data/mysql/updatedatabase.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt Failed to merge in the changes. Patch failed at 0001 bug_5788: Moved ReservesMaxPickupDelay syspref to issue rules When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, ins -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5788 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4807|0 |1 is obsolete| | --- Comment #25 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 8551 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8551&action=edit patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5788 --- Comment #26 from delaye <stephane.delaye@biblibre.com> --- Falling back to patching base and 3-way merge... Auto-merging admin/smart-rules.pl CONFLICT (content): Merge conflict in admin/smart-rules.pl Auto-merging installer/data/mysql/kohastructure.sql Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt Failed to merge in the changes. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5788 --- Comment #27 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Can you please try again, I did not get any conflicts: srdjan@ozzy:~/koha/dev ((88efb10...))$ git am attachment.cgi\?id\=8551 Applying: bug_5788: Added reservesmaxpickupdelay to circ matrix -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5788 --- Comment #28 from delaye <stephane.delaye@biblibre.com> --- In the account of the patron who has reserved the book does not display the withdrawal deadline. How do I know if the number of days specified in the holds rules is taken into account? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5788 --- Comment #29 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- This bug was not for implementing the rule itself, but for moving ReservesMaxPickupDelay syspref to issuing_rules table. This rule has never been implemented. Please correct me if this is wrong. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5788 --- Comment #30 from Owen Leonard <oleonard@myacpl.org> --- Is this bug still valid? What does this patch do? Does it not work independently of some other enhancement? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5788 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #31 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- It is sort of valid, probably needs rebasing, however this is being tested together with 5876 and 5787 by Bywater, and there will be a parch for all 3 of them together. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5788 Melia Meggs <melia@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |melia@bywatersolutions.com --- Comment #32 from Melia Meggs <melia@bywatersolutions.com> --- A new patch coming soon for this!! I want to provide test plans to facilitate community testing. This patch moves ReservesMaxPickUpDelay from system preferences to the circ matrix. It should behave the same way in the circ matrix as it currently behaves as a sys pref. To test: Set ReservesMaxPickUpDelay to 1 Place a hold Check to make sure the item moves from the Holds Waiting tab to the Holds Over tab after 1 day -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5788 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|5786 | Depends on|5872 |5786 --- Comment #33 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- This bug will be resolved in unified patch on bug 5786 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5788 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8551|0 |1 is obsolete| | --- Comment #34 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Comment on attachment 8551 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8551 patch Integrated with 5786, 5787 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5788 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED CC| |julian.maurice@biblibre.com Resolution|--- |DUPLICATE --- Comment #35 from Julian Maurice <julian.maurice@biblibre.com> --- As it was merged with bug 5786, I think the appropriate status is RESOLVED - DUPLICATE *** This bug has been marked as a duplicate of bug 5786 *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5788 Bug 5788 depends on bug 5786, which changed state. Bug 5786 Summary: Move AllowOnShelfHolds and OpacItemHolds system preferences to the Circulation Matrix http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |CLOSED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org