[Bug 17852] New: Multiple URLs (856) in list email are broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17852 Bug ID: 17852 Summary: Multiple URLs (856) in list email are broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Lists Assignee: gmcharlt@gmail.com Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Same bug as bug 14614, but for list emails send from staff and intranet. If there are multiple URLs (865 fields), the URLs get squashed together into 'one URL' in the email sent and are broken therefore. Same fix as for the other bugs should work nicely here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17852 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14614 Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17852 Caitlin Goodger <caitlingoodger.student@wegc.school.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17852 --- Comment #1 from Caitlin Goodger <caitlingoodger.student@wegc.school.nz> --- Created attachment 59111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59111&action=edit Bug 17852; Multiple URLs (856) in list email are broken. Test Plan 1: Add multiple urls to a biblographic record 2: Add the biblographic record to a list and then email it. 3: See that the links are broken and have been merged into one. 4: Apply patch 5: Send the list again and see that the links work -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17852 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Caitlin, this is good, but can you please take a look at the corresponding file for the OPAC (koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendshelf.tt)? It needs the same fix and I could then test and sign-off on both fixes together. Thx! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17852 Zoe Schoeler <crazy.mental.onion@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |crazy.mental.onion@gmail.co | |m Assignee|gmcharlt@gmail.com |crazy.mental.onion@gmail.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17852 Caitlin Goodger <caitlingoodger.student@wegc.school.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caitlingoodger.student@wegc | |.school.nz Assignee|crazy.mental.onion@gmail.co |caitlingoodger.student@wegc |m |.school.nz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17852 --- Comment #3 from Caitlin Goodger <caitlingoodger.student@wegc.school.nz> --- Created attachment 59197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59197&action=edit Bug 17852 Follow up.Multiple URLs (856) in list email are broken This is a follow-up to my previous patch. This fixes it on the OPAC and the previous one was from the intranet Test Plan 1: Add multiple urls to a biblographic record 2: Add the biblographic record to a list and then email it from the OPAC 3: See that the links are broken and have been merged into one. 4: Apply patch 5: Send the list again and see that the links work -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17852 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59111|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 59527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59527&action=edit [SIGNED-OFF] Bug 17852; Multiple URLs (856) in list email are broken. Test Plan 1: Add multiple urls to a biblographic record 2: Add the biblographic record to a list and then email it. 3: See that the links are broken and have been merged into one. 4: Apply patch 5: Send the list again and see that the links work Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17852 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59197|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 59528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59528&action=edit [SIGNED-OFF] Bug 17852 Follow up.Multiple URLs (856) in list email are broken This is a follow-up to my previous patch. This fixes it on the OPAC and the previous one was from the intranet Test Plan 1: Add multiple urls to a biblographic record 2: Add the biblographic record to a list and then email it from the OPAC 3: See that the links are broken and have been merged into one. 4: Apply patch 5: Send the list again and see that the links work Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17852 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17852 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17852 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59527|0 |1 is obsolete| | Attachment #59528|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 60462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60462&action=edit Bug 17852; Multiple URLs (856) in list email are broken. Test Plan 1: Add multiple urls to a biblographic record 2: Add the biblographic record to a list and then email it. 3: See that the links are broken and have been merged into one. 4: Apply patch 5: Send the list again and see that the links work Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17852 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 60463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60463&action=edit Bug 17852 Follow up.Multiple URLs (856) in list email are broken This is a follow-up to my previous patch. This fixes it on the OPAC and the previous one was from the intranet Test Plan 1: Add multiple urls to a biblographic record 2: Add the biblographic record to a list and then email it from the OPAC 3: See that the links are broken and have been merged into one. 4: Apply patch 5: Send the list again and see that the links work Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17852 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Caitlin! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17852 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- These patches have been pushed to 16.11.x and will be in 16.11.04. Thx Caitlin! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17852 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Bug, not enhancement :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17852 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #11 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.10 release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17852 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #12 from Julian Maurice <julian.maurice@biblibre.com> --- Pushed to 3.22.x, will be in 3.22.18 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org