[Bug 18518] New: The staff interface "blink" for different actions after upgrading to Firefox 53
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18518 Bug ID: 18518 Summary: The staff interface "blink" for different actions after upgrading to Firefox 53 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Browser compatibility Assignee: oleonard@myacpl.org Reporter: francois.charbonnier@inlibro.com QA Contact: testopia@bugs.koha-community.org After upgrading to firefox 53 (ubuntu 14.04) I noticed the interface "blinks" when I check out an item (on Koha 16.05) I tried this with firefox 52, the interface stays still. Marc Veron reproduced the issue on the current master : - On the staff client main page, click on 'Patrons' - While loading the page, I see very shortly a yellow message "Add patrons to" (I took a video and stepped through it to be able to read the text). - Then the page refreshes and displays as expected. - I get the same when I am on the page Home > Patrons and click 'Search'. I get it with Firefox 53.0 (Windows) I do not get it with Firefox ESR 45.3.0 (Debian) Marc suggests the message "Add patrons to" should not be triggered. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18518 Francois Charbonnier <francois.charbonnier@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philippe.blouin@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18518 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #1 from Marc Véron <veron@veron.ch> --- Update: I could reproduce with Firefox ESR 45.3.0 (Debian) as well by slowing it down (turned on syspref DumpTemplateVarsIntranet, it consumes quite a lot of time). I think the problem is related to document.ready It contains hide() functions at several places. Maybe they could be rearranged (moved up to the top) where applicable. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18518 --- Comment #2 from Marc Véron <veron@veron.ch> --- OK, there are several elements hiding / unhiding, one of them is the patron lists dialog. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18518 --- Comment #3 from Marc Véron <veron@veron.ch> --- Created attachment 62927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62927&action=edit Bug 18518: Hide patron list dialog by default This patch hides the patron list dialog by default to prevent it to display shortly when koha/members/member.pl is called. There are more reasons for the blinking of the page, but at least the yellow patron list dialog does no longer display without having to. To test: - Slow down system by enabling syspref DumpTemplateVarsIntranet - Try to reproduce issue, see a yellow dialog come up for a very short time when member.pl is displayed (e.g. with a search) - Apply patch - Go to patron page - Try to reproduce. Page still blinks, but the dialog as one of the elements that produce bilnking does no longer show up - Verify that patron list functionality works as before (Select some patrons and add them to a patron list). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18518 --- Comment #4 from Marc Véron <veron@veron.ch> --- The second reason for the blinking is that the form for the search filters shortly displays and then hides again. It moves the whole page down and up again. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18518 --- Comment #5 from Marc Véron <veron@veron.ch> --- It seems that the mechanism in following file is broken: koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc To visualise, add a delay to all functions toggle(), e.g. toggle 500 You will see that the page first displays with the filter fields set to visible, and then they are turned off by the toggle function. I can not find out how to fix. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18518 --- Comment #6 from Blou <philippe.blouin@inlibro.com> --- So the Koha code is not optimal. But why does is suddenly show up in the new Firefox ? It's just slower? We'll be happy to signoff if you find a solution, Marc. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18518 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #7 from Marc Véron <veron@veron.ch> --- (In reply to Blou from comment #6)
So the Koha code is not optimal. But why does is suddenly show up in the new Firefox ? It's just slower?
We'll be happy to signoff if you find a solution, Marc.
Hi Blou The patch removes one of the issues (the yellow dialog shortly shining up). For the other issue (comment #5) I did not find out how to fix. Maybe it is a good idea you reach out to ICR. Marc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18518 Philippe Audet-Fortin <philippe.audet-fortin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62927|0 |1 is obsolete| | --- Comment #8 from Philippe Audet-Fortin <philippe.audet-fortin@inlibro.com> --- Created attachment 63039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63039&action=edit Bug 18518: Hide patron list dialog by default This patch hides the patron list dialog by default to prevent it to display shortly when koha/members/member.pl is called. There are more reasons for the blinking of the page, but at least the yellow patron list dialog does no longer display without having to. To test: - Slow down system by enabling syspref DumpTemplateVarsIntranet - Try to reproduce issue, see a yellow dialog come up for a very short time when member.pl is displayed (e.g. with a search) - Apply patch - Go to patron page - Try to reproduce. Page still blinks, but the dialog as one of the elements that produce bilnking does no longer show up - Verify that patron list functionality works as before (Select some patrons and add them to a patron list). Signed-off-by: paudet <paudet@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18518 --- Comment #9 from Marc Véron <veron@veron.ch> --- (In reply to Philippe Audet-Fortin from comment #8)
Created attachment 63039 [details] [review] Bug 18518: Hide patron list dialog by default
(...)
Signed-off-by: paudet <paudet@inlibro.com>
Philippe, did you forget to switch to signed off? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18518 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18518 --- Comment #10 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Oh I've proposed also a patch on Bug 18551. I've also hidden the table. Should I rebase my bug on this one or provide a followup in this one ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18518 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18551 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18518 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |DUPLICATE --- Comment #11 from Marc Véron <veron@veron.ch> --- (In reply to Fridolin SOMERS from comment #10)
Oh I've proposed also a patch on Bug 18551.
I've also hidden the table.
Should I rebase my bug on this one or provide a followup in this one ?
It's OK for me to mark this bug as duplicate of 18551 *** This bug has been marked as a duplicate of bug 18551 *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18518 Philippe Audet-Fortin <philippe.audet-fortin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philippe.audet-fortin@inlib | |ro.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org