[Bug 17484] New: Searching with date range limit (lower and upper) does not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17484 Bug ID: 17484 Summary: Searching with date range limit (lower and upper) does not work Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P2 Component: OPAC Assignee: oleonard@myacpl.org Reporter: koha@univ-lyon3.fr QA Contact: testopia@bugs.koha-community.org When you do a search through advanced search with a publication date range limit (like 2002-2006 by example) according the example given in the legend, you get no results even if there must be ones. It's ok for one-bound limits like -2002 or 2006-, but for two bounds limits you must wrap the hypen with spaces to get results, which is not consistent with the legend. Whitout spaces the query sent to zebra is done by opac-search.pl script like this : kw,wrdl,rtrn=MY_SEARCH and yr,st-numeric,ge=2002 and yr,st-numeric,le=2006 Seems that Zebra does not understand that syntax. With spaces, it is turned out like this : kw,wrdl,rtrn=MY_SEARCH and yr,st-numeric=2002 - 2006 and it works. It also works without spaces if you run a ccl query directly from the opac : ccl=kw,wrdl,rtrn=archipel and yr,st-numeric=2002-2006 May be it's a question of zebra config or zebra version, not completely sure of this (cf bug 12897), I propose this patch nevertheless as an eventuel solution. Test plan : 1) do a search from advanced search with some results 2) redo the same putting a date limit with two bounds separated by an hypen without spaces : you get no results 3) apply the patch 4) redo stage 2 : you get the expected results -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17484 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha@univ-lyon3.fr --- Comment #1 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Created attachment 56726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56726&action=edit Bug_17484 Searching with date range limit (lower and upper) does not work -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17484 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17484 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell@ptfs-europe. | |com --- Comment #2 from Colin Campbell <colin.campbell@ptfs-europe.com> --- This change in Yaz --- 5.15.0 2015/11/11 CCL: fix r=o, r=r WRT inherited attributes YAZ-864 appears that it may be the point at which the syntax was tightened up -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17484 Janet McGowan <janet.mcgowan@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janet.mcgowan@ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17484 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56726|0 |1 is obsolete| | --- Comment #3 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Created attachment 56742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56742&action=edit Proposed patch Tested on two systems one exhibiting the bug and one not on both date ranges now work as advertised -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17484 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #4 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Signed Off bug - patch fixes problem -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17484 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- You should make the same changes for the intranet script (catalogue/search.pl) as well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17484 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56742|0 |1 is obsolete| | --- Comment #6 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Created attachment 56842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56842&action=edit Bug 17484 - Searching with date range limit (lower and upper) does not work added same modification on staff interface -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17484 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17484 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17484 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17484 --- Comment #7 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 57606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57606&action=edit Bug_17484 Search with date range limit (lower and upper) does not work If the period is entered without spaces wrapping the hyphen You can't get any result Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> I can't reproduce the error, search still works after applying the patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17484 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko@abunchofthings.net Attachment #56842|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17484 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I do not recreate the error (whereas I did when I tried it last month). I am using kohadevbox, and yaz 4.2.30-4. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17484 --- Comment #9 from Colin Campbell <colin.campbell@ptfs-europe.com> --- (In reply to Jonathan Druart from comment #8)
I do not recreate the error (whereas I did when I tried it last month).
I am using kohadevbox, and yaz 4.2.30-4.
If the change I listed above is the one causing the old code to cease to work you need a yaz version > 5.15 to manifest the problem. This bears out what I've observed in a number of sites later yaz manifests the problem earlier ones dont. Fix works for all -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17484 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17484 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57606|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57622&action=edit Bug_17484 Search with date range limit (lower and upper) does not work If the period is entered without spaces wrapping the hyphen You can't get any result Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> I can't reproduce the error, search still works after applying the patch Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17484 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Colin Campbell from comment #9)
(In reply to Jonathan Druart from comment #8)
I do not recreate the error (whereas I did when I tried it last month).
I am using kohadevbox, and yaz 4.2.30-4.
If the change I listed above is the one causing the old code to cease to work you need a yaz version > 5.15 to manifest the problem. This bears out what I've observed in a number of sites later yaz manifests the problem earlier ones dont. Fix works for all
It looks like jessie, stretch and sid are all using 4.2.30 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17484 --- Comment #12 from Mirko Tietgen <mirko@abunchofthings.net> --- (In reply to Jonathan Druart from comment #11)
It looks like jessie, stretch and sid are all using 4.2.30
You can get 5.x from IndexData, but it's not going to be in Debian anytime soon I guess. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17484 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Koha Team Lyon 3! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17484 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #14 from Julian Maurice <julian.maurice@biblibre.com> --- Pushed to 3.22.x, will be in 3.22.13 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17484 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #15 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.06 release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org