[Bug 39288] New: Improve the patron search description display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39288 Bug ID: 39288 Summary: Improve the patron search description display Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com
From bug 38116 comment 25:
I am not going to block this, but I feel the display could be a little nicer for the additional search criteria. Also not sure about capitalization here and itching to change the upper cases... Patrons found for: Card number starting with 't' Library=Riverside, Category=School -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39288 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |38116 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38116 [Bug 38116] Patrons search description should be built from DT's search settings -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39288 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39288 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 179115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179115&action=edit Bug 39288: lowercase fields in patron search description This patch lowercases all the fields in the patron search description Patrons found for: Card number starting with 't' Library=Riverside, Category=School will now be Patrons found for: card number starting with 't' library=Riverside, category=School -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39288 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39288 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39288 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179115|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 179143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179143&action=edit Bug 39288: lowercase fields in patron search description This patch lowercases all the fields in the patron search description Patrons found for: Card number starting with 't' Library=Riverside, Category=School will now be Patrons found for: card number starting with 't' library=Riverside, category=School Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39288 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39288 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179143|0 |1 is obsolete| | --- Comment #3 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 179796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179796&action=edit Bug 39288: lowercase fields in patron search description This patch lowercases all the fields in the patron search description Patrons found for: Card number starting with 't' Library=Riverside, Category=School will now be Patrons found for: card number starting with 't' library=Riverside, category=School Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39288 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA QA Contact|testopia@bugs.koha-communit |baptiste.wojtkowski@biblibr |y.org |e.com Version|unspecified |Main --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I have doubts about this patch. I believe this won't work for translations: let field = patron_search_form.find(".searchfieldstype_filter").find("option:selected").text().toLowerCase(); If for example "category" is translatable, then it need to be upper case in German for example. So maybe we need to re-think here :( -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39288 --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Katrin Fischer from comment #4)
I have doubts about this patch. I believe this won't work for translations:
let field = patron_search_form.find(".searchfieldstype_filter").find("option:selected"). text().toLowerCase();
If for example "category" is translatable, then it need to be upper case in German for example. So maybe we need to re-think here :(
I don't understand what you mean. The option's text will be translated already. We only lower case it. Is that a problem? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39288 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |WONTFIX --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Discussed with Joubu in Mattermost: sadly it won't work OK in every language to lower case, so we will abandon this patch. I am sorry, when requesting it I was not aware about the mechanics pulling the strings from the pull downs with JS. I thought it was only about changing some strings in a template :( -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org