[Bug 23307] New: Add columns configuration to cataloguing/z3950_search.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23307 Bug ID: 23307 Summary: Add columns configuration to cataloguing/z3950_search.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Depends on: 23304 I would like to add columns configuration to the DataTable which shows Z39.50 search results in the cataloging module. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23304 [Bug 23304] Reindent cataloguing/z3950_search.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23307 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23307 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 91492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91492&action=edit Bug 23307: Add columns configuration to cataloguing/z3950_search.tt This patch adds columns configuration to the DataTable which displays Z39.50 search results in the cataloging module. The Z39.50 results screen has its own server-side paging system, so I added some code to copy the page number information ("Page 2 / 6") to the DataTable toolbar for a more consistent appearance. The wording of that information has also been modified for consistency's sake. To test, apply the patch and restart Plack (or restart_all on kohadevbox) - Go to Cataloging -> New from Z39.50/SRU. - Perform a Z39.50 search which will return multiple pages of results. - Confirm that the DataTable controls work correctly: Search, columns show/hide, export. - Confirm that the page number information is correct as you navigate through pages of results. - Go to Administration -> Columns settings. - Confirm that the columns configuration settings for the z3950_search table in the "Cataloging" section works correctly. Changes made here should be reflected in the table of Z39.50 search results. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23307 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23307 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91492|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23307 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23307 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 91535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91535&action=edit Bug 23307: Add columns configuration to cataloguing/z3950_search.tt This patch adds columns configuration to the DataTable which displays Z39.50 search results in the cataloging module. The Z39.50 results screen has its own server-side paging system, so I added some code to copy the page number information ("Page 2 / 6") to the DataTable toolbar for a more consistent appearance. The wording of that information has also been modified for consistency's sake. To test, apply the patch and restart Plack (or restart_all on kohadevbox) - Go to Cataloging -> New from Z39.50/SRU. - Perform a Z39.50 search which will return multiple pages of results. - Confirm that the DataTable controls work correctly: Search, columns show/hide, export. - Confirm that the page number information is correct as you navigate through pages of results. - Go to Administration -> Columns settings. - Confirm that the columns configuration settings for the z3950_search table in the "Cataloging" section works correctly. Changes made here should be reflected in the table of Z39.50 search results. - Test other tables which use columns configuration to confirm that the changes made in this patch doesn't disrupt their behavior. Test that any custom columns configuration are applied. For example: - Administration -> Libraries - Reports -> Saved reports - Circulation -> Holds queue -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23307 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91535|0 |1 is obsolete| | --- Comment #3 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 91879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91879&action=edit Bug 23307: Add columns configuration to cataloguing/z3950_search.tt This patch adds columns configuration to the DataTable which displays Z39.50 search results in the cataloging module. The Z39.50 results screen has its own server-side paging system, so I added some code to copy the page number information ("Page 2 / 6") to the DataTable toolbar for a more consistent appearance. The wording of that information has also been modified for consistency's sake. To test, apply the patch and restart Plack (or restart_all on kohadevbox) - Go to Cataloging -> New from Z39.50/SRU. - Perform a Z39.50 search which will return multiple pages of results. - Confirm that the DataTable controls work correctly: Search, columns show/hide, export. - Confirm that the page number information is correct as you navigate through pages of results. - Go to Administration -> Columns settings. - Confirm that the columns configuration settings for the z3950_search table in the "Cataloging" section works correctly. Changes made here should be reflected in the table of Z39.50 search results. - Test other tables which use columns configuration to confirm that the changes made in this patch doesn't disrupt their behavior. Test that any custom columns configuration are applied. For example: - Administration -> Libraries - Reports -> Saved reports - Circulation -> Holds queue Signed-off-by: George Williams <george@nekls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23307 George Williams (NEKLS) <george@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |george@nekls.org --- Comment #4 from George Williams (NEKLS) <george@nekls.org> --- I was able to follow the test plan without encountering any errors. I'd add, though, that it would be nice if the "Actions" column could be dropped from the export (it's about 200 characters wide and there's no way to turn it off and it adds no value to the export) and if the "Additional fields" column could be included in options with the "Column settings" button if AdditionalFieldsInZ3950ResultSearch is configured. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23307 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23307 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91879|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 92080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92080&action=edit Bug 23307: Add columns configuration to cataloguing/z3950_search.tt This patch adds columns configuration to the DataTable which displays Z39.50 search results in the cataloging module. The Z39.50 results screen has its own server-side paging system, so I added some code to copy the page number information ("Page 2 / 6") to the DataTable toolbar for a more consistent appearance. The wording of that information has also been modified for consistency's sake. To test, apply the patch and restart Plack (or restart_all on kohadevbox) - Go to Cataloging -> New from Z39.50/SRU. - Perform a Z39.50 search which will return multiple pages of results. - Confirm that the DataTable controls work correctly: Search, columns show/hide, export. - Confirm that the page number information is correct as you navigate through pages of results. - Go to Administration -> Columns settings. - Confirm that the columns configuration settings for the z3950_search table in the "Cataloging" section works correctly. Changes made here should be reflected in the table of Z39.50 search results. - Test other tables which use columns configuration to confirm that the changes made in this patch doesn't disrupt their behavior. Test that any custom columns configuration are applied. For example: - Administration -> Libraries - Reports -> Saved reports - Circulation -> Holds queue Signed-off-by: George Williams <george@nekls.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23307 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23307 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23307 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to George Williams (NEKLS) from comment #4)
I was able to follow the test plan without encountering any errors.
I'd add, though, that it would be nice if the "Actions" column could be dropped from the export (it's about 200 characters wide and there's no way to turn it off and it adds no value to the export) and if the "Additional fields" column could be included in options with the "Column settings" button if AdditionalFieldsInZ3950ResultSearch is configured.
This looks like a distinct bug to me.. lets get that recorded. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23307 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Submitted as bug 23441 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23307 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |fridolin.somers@biblibre.co | |m --- Comment #9 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Enhancement not pushed to 19.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23307 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23441 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23441 [Bug 23441] Export should not include the 'actions' column in Z3950 results. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org