[Bug 26752] New: OPAC list download button broken by Bootstrap 4 upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26752 Bug ID: 26752 Summary: OPAC list download button broken by Bootstrap 4 upgrade Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 20168 The "Download" link on the OPAC list contents page was broken by the Bootstrap 4 upgrade. I think it relied on a feature of Bootstrap 2.x which allowed one to specify a link target in the modal trigger which would be loaded via AJAX. I think rather than restoring the AJAX version it's probably better to create a dropdown menu matching the one in the OPAC cart. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26752 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26752 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 112041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112041&action=edit Bug 26752: Convert OPAC list download modal to dropdown This patch modifies the OPAC list page so that download options are shown in a dropdown menu instead of a modal dialog. This solves a bug introduced by the Bootstrap 4 upgrade and makes it consistent with the cart interface. To test, apply the patch and view the contents of a list in the OPAC which has multiple items on it. - In the toolbar at the top of the list contents table the "Download" button should now be a dropdown menu. - Selecting any of the download options should trigger a download prompt. - Test with and without some CSV profiles which have been configured for use in the OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26752 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112041|0 |1 is obsolete| | --- Comment #2 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 112229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112229&action=edit Bug 26752: Convert OPAC list download modal to dropdown This patch modifies the OPAC list page so that download options are shown in a dropdown menu instead of a modal dialog. This solves a bug introduced by the Bootstrap 4 upgrade and makes it consistent with the cart interface. To test, apply the patch and view the contents of a list in the OPAC which has multiple items on it. - In the toolbar at the top of the list contents table the "Download" button should now be a dropdown menu. - Selecting any of the download options should trigger a download prompt. - Test with and without some CSV profiles which have been configured for use in the OPAC Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26752 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |julian.maurice@biblibre.com --- Comment #3 from Julian Maurice <julian.maurice@biblibre.com> --- I confirm that there is a bug in master, and that the patch fixes it -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26752 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26752 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112229|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 112246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112246&action=edit Bug 26752: Convert OPAC list download modal to dropdown This patch modifies the OPAC list page so that download options are shown in a dropdown menu instead of a modal dialog. This solves a bug introduced by the Bootstrap 4 upgrade and makes it consistent with the cart interface. To test, apply the patch and view the contents of a list in the OPAC which has multiple items on it. - In the toolbar at the top of the list contents table the "Download" button should now be a dropdown menu. - Selecting any of the download options should trigger a download prompt. - Test with and without some CSV profiles which have been configured for use in the OPAC Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26752 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26752 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26752 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- missing dependencies for 20.05.x, no backport -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26752 Bug 26752 depends on bug 20168, which changed state. Bug 20168 Summary: Update of the OPAC bootstrap template to bootstrap v4 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org