[Bug 19537] New: Authorities search doesn' t correctly populate subfield $2 source of heading
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19537 Bug ID: 19537 Summary: Authorities search doesn't correctly populate subfield $2 source of heading Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl There is code intended to check theindicators and 008 for an authority and update subfield 2, but it doesn't work -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19537 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19537 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 68677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68677&action=edit Bug 19537: Correct addition of source subfield from authorities To test: 1 - Find or create a subject authority 2 - Define 008/11 as 's' or 'r' 3 - Add 2nd indicator '7' to main heading 4 - Open or create a bibliographic record 5 - Link to the authority created above 6 - Subfield $2 is not set 7 - Apply patch 8 - Repeat linking, subfield $2 should be set Assignee: nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19537 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19537 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19537 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18904 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19537 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19537 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68677|0 |1 is obsolete| | --- Comment #2 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 68809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68809&action=edit Bug 19537: Correct addition of source subfield from authorities To test: 1 - Find or create a subject authority 2 - Define 008/11 as 's' or 'r' 3 - Add 2nd indicator '7' to main heading 4 - Open or create a bibliographic record 5 - Link to the authority created above 6 - Subfield $2 is not set 7 - Apply patch 8 - Repeat linking, subfield $2 should be set Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19537 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19537 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68809|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 68903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68903&action=edit Bug 19537: Correct addition of source subfield from authorities To test: 1 - Find or create a subject authority 2 - Define 008/11 as 's' or 'r' 3 - Add 2nd indicator '7' to main heading 4 - Open or create a bibliographic record 5 - Link to the authority created above 6 - Subfield $2 is not set 7 - Apply patch 8 - Repeat linking, subfield $2 should be set Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19537 --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 68904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68904&action=edit Bug 19537: (QA Follow-up) Consistent structures The subfield_loop structure should contain things like: $VAR1 = { 'marc_subfield' => 'v', 'marc_values' => [ 'form' ] }; This patches replaces the list by an array ref to restore consistency, although Template Toolkit does not really care. Both work. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19537 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Removing enh label. This is a bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19537 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68904|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 68905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68905&action=edit Bug 19537: (QA Follow-up) Consistent structures The subfield_loop structure should contain things like: $VAR1 = { 'marc_subfield' => 'v', 'marc_values' => [ 'form' ] }; This patches replaces the list by an array ref to restore consistency, although Template Toolkit does not really care. Both work. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19537 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18904 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904 [Bug 18904] Advanced editor - Rancor - Add authority support -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19537 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org