[Bug 5834] New: Holds link missing when 942$c is not for loan
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5834 Bug #: 5834 Summary: Holds link missing when 942$c is not for loan Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All URL: /cgi-bin/koha/catalogue/search.pl OS/Version: All Status: NEW Severity: normal Priority: P5 Component: Staff Client AssignedTo: paul.poulain@biblibre.com ReportedBy: katrin.fischer@bsz-bw.de QAContact: koha-bugs@lists.koha-community.org CC: gmcharlt@gmail.com Created attachment 3255 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3255 screenshot When 942$c is set to a not for loan itemtype, the holds link in staff search results is not shown, although item-level_itypes is set to 'specific item'. Instead of the hold link the result list shows 'No holds allowed', no matter which item types the attached items are. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5834 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-03-07 00:41:38 UTC --- Created attachment 3256 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3256 Proposed patch Adds check for sys pref item-level_itypes. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5834 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff AssignedTo|paul.poulain@biblibre.com |katrin.fischer@bsz-bw.de -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5834 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |nengard@gmail.com --- Comment #2 from Nicole C. Engard <nengard@gmail.com> 2011-03-07 19:26:26 UTC --- I have applied this patch and my bib record is showing that it can be put on hold even after i change the system preference and have the bib set to a not for loan type and the item to a for loan type. I'm wondering if I tested wrong or if this has failed QA. Can someone else test. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5834 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-03-09 06:14:54 UTC --- Hi Nicole, what were the settings you tested it with? Have you seen the comments on the patch file? Basically the aim is to make it ignore the 942$c when using item-level_itypes = speficic item. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5834 --- Comment #4 from Nicole C. Engard <nengard@gmail.com> 2011-03-09 22:23:25 UTC --- I followed the test parameters you put in the patch. I'll try it again later. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5834 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3256|0 |1 is obsolete| | --- Comment #5 from Jared Camins-Esakov <jcamins@cpbibliography.com> 2011-03-19 21:16:29 UTC --- Created attachment 3360 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3360 Signed-off patch Signed off on Katrin's patch. Note that this patch changes the Results display, not the Details display. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5834 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jcamins@cpbibliography.com Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5834 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Signed Off |Patch Pushed --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> 2011-03-21 07:53:01 UTC --- Pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5834 Mark Gavillet <mark.gavillet@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED CC| |mark.gavillet@ptfs-europe.c | |om Resolution| |FIXED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org