[Bug 15857] New: Add test mode to process_message_queue.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15857 Bug ID: 15857 Summary: Add test mode to process_message_queue.pl Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org It would be nice for testing and migration purposes if we could run process_message_queue.pl but have the emails go to a testing address instead of the patron's email address, and have SMS messages go to a testing phone number instead of the patron's sms number. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15857 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15857 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 48222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48222&action=edit Bug 15857 - Add test mode to process_message_queue.pl It would be nice for testing and migration purposes if we could run process_message_queue.pl but have the emails go to a testing address instead of the patron's email address, and have SMS messages go to a testing phone number instead of the patron's sms number. Test Plan: 1) Apply this patch 2) Add some stuff to the message queue however you wish 3) Run process_message_queue.pl with the addition parameters --test --test-email your@email.com 4) Note that you recieve those emails, and not the address listed in the message_queue table! 5) Bonus points: If you have an SMS service, repeat the test with SMS notices and --test-sms -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15857 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15857 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #2 from Marc Véron <veron@veron.ch> --- With patch applied, I get (with and without test mode): "state" variable @_ masks earlier declaration in same scope at /usr/share/kohaclone/C4/Letters.pm line 1282. "my" variable $message masks earlier declaration in same scope at /usr/share/kohaclone/C4/Letters.pm line 1298. syntax error at /usr/share/kohaclone/C4/Letters.pm line 1237, near ") if" syntax error at /usr/share/kohaclone/C4/Letters.pm line 1246, near "}" Global symbol "$message" requires explicit package name at /usr/share/kohaclone/C4/Letters.pm line 1250. syntax error at /usr/share/kohaclone/C4/Letters.pm line 1256, near "}" Can't use global @_ in "my" at /usr/share/kohaclone/C4/Letters.pm line 1261, near "= @_" syntax error at /usr/share/kohaclone/C4/Letters.pm line 1279, near "}" (Might be a runaway multi-line << string starting on line 1265) Can't use global @_ in "my" at /usr/share/kohaclone/C4/Letters.pm line 1282, near "= @_" syntax error at /usr/share/kohaclone/C4/Letters.pm line 1295, near "}" syntax error at /usr/share/kohaclone/C4/Letters.pm line 1344, near "}" Can't use global @_ in "my" at /usr/share/kohaclone/C4/Letters.pm line 1347, near "= @_" /usr/share/kohaclone/C4/Letters.pm has too many errors. Compilation failed in require at misc/cronjobs/process_message_queue.pl line 28. BEGIN failed--compilation aborted at misc/cronjobs/process_message_queue.pl line 28. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15857 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- Could you hashref that huge parameter list while you are at it? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15857 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48222|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 49114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49114&action=edit Bug 15857 - Add test mode to process_message_queue.pl It would be nice for testing and migration purposes if we could run process_message_queue.pl but have the emails go to a testing address instead of the patron's email address, and have SMS messages go to a testing phone number instead of the patron's sms number. Test Plan: 1) Apply this patch 2) Add some stuff to the message queue however you wish 3) Run process_message_queue.pl with the addition parameters --test --test-email your@email.com 4) Note that you recieve those emails, and not the address listed in the message_queue table! 5) Bonus points: If you have an SMS service, repeat the test with SMS notices and --test-sms -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15857 --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to M. Tompsett from comment #3)
Could you hashref that huge parameter list while you are at it?
Fixed! Could you specify which sub's parameter list you are referring to? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15857 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |srdjan@catalyst.net.nz --- Comment #6 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- _send_message_by_email( $message, $params ) and _send_message_by_sms( $message, $params ) rather than exploding individual params. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15857 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Kyle does Srdjan's comment require a follow-up, or is this still 'Needs Signoff?' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15857 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE CC| |katrin.fischer@bsz-bw.de Status|In Discussion |RESOLVED --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I believe that bug 8000 added the test mode intended here. *** This bug has been marked as a duplicate of bug 8000 *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org