[Bug 17215] New: Cardnumbers of patrons created using LDAP Replication not using autoMemberNum if configured
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17215 Bug ID: 17215 Summary: Cardnumbers of patrons created using LDAP Replication not using autoMemberNum if configured Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: ldjamison@marywood.edu QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com When using LDAP and leveraging the 'replicate' flag, patrons who are replicated have their cardnumber assigned equal to their LDAP username. This is an inconsistency when the 'autoMemberNum' System Preference is set to 'Do'. When 'autoMemberNum' is set to 'Don't' then replicate should act as it currently does. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17215 --- Comment #1 from Lee Jamison <ldjamison@marywood.edu> --- Created attachment 54973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54973&action=edit Assigns numerical cardnumber if autoMemberNum is enabled This patch modifies Auth_with_ldap.pm to use the autoMemberNum System Preference if it's enabled. To test: 1. Set the autoMemberNum System Preference to "Don't". 2. Login to the OPAC with an LDAP account that does not currently exist as a patron record. 3. Check the patron record's cardnumber. 4. the cardnumber should equal the patron's LDAP username. 5. Delete the patron record. 6. Apply the patch. 7. Set the autoMemberNum System Preference to "Do". 8. Login to the OPAC with an LDAP account that does not currently exist as a patron record. 9. Check the patron record's cardnumber. 10. The cardnumber should now be the next highest cardnumber based on autoMemberNum. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17215 Lee Jamison <ldjamison@marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17215 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17215 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 55048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55048&action=edit Implemented autoMemberNum in C4::Auth_with_ldap.pm https://bugs.koha-community.org/show_bug.cgi?id=17215 Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17215 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |nick@bywatersolutions.com --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- QA tools complaints: FAIL forbidden patterns forbidden pattern: tab char (line 245) forbidden pattern: tab char (line 247) forbidden pattern: tab char (line 242) forbidden pattern: tab char (line 243) forbidden pattern: tab char (line 241) forbidden pattern: tab char (line 248) forbidden pattern: tab char (line 244) forbidden pattern: tab char (line 246) Tested using LDAP server here: http://www.forumsys.com/en/tutorials/integration-how-to/ldap/online-ldap-tes... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17215 --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Just pasting in from my koha-conf.xml to ease testing setup for anyone else: <useldapserver>1</useldapserver><!-- see C4::Auth_with_ldap for extra configs you must add if you want to turn this on --> <ldapserver id="ldapserver"> <hostname>ldap://ldap.forumsys.com/</hostname> <port>389</port> <base>dc=example,dc=com</base> <user>cn=read-only-admin,dc=example,dc=com</user> <!-- DN, if not anonymous --> <pass>password</pass> <!-- password, if not anonymous --> <replicate>1</replicate> <!-- add new users from LDAP to Koha database --> <update>0</update> <!-- update existing users in Koha database --> <auth_by_bind>1</auth_by_bind> <!-- set to 1 to authenticate by binding instead of password comparison, e.g., to use Active Directory --> <principal_name>uid=%s,dc=example,dc=com</principal_name> <mapping> <!-- match koha SQL field names to your LDAP record field names --> <userid is="uid" ></userid> <categorycode is="banana">YA</categorycode> <branchcode is="apple">LPL</branchcode> <!-- <password is="userpassword" ></password>--> </mapping> </ldapserver> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17215 Lee Jamison <ldjamison@marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54973|0 |1 is obsolete| | --- Comment #5 from Lee Jamison <ldjamison@marywood.edu> --- Created attachment 55058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55058&action=edit Bug 17215 - converted tabs to whitespace To test: 1. Set the autoMemberNum System Preference to "Don't". 2. Login to the OPAC with an LDAP account that does not currently exist as a patron record. 3. Check the patron record's cardnumber. 4. the cardnumber should equal the patron's LDAP username. 5. Delete the patron record. 6. Apply the patch. 7. Set the autoMemberNum System Preference to "Do". 8. Login to the OPAC with an LDAP account that does not currently exist as a patron record. 9. Check the patron record's cardnumber. 10. The cardnumber should now be the next highest cardnumber based on autoMemberNum. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17215 Lee Jamison <ldjamison@marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17215 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> --- Hi Lee Thanks for marking this signed off. Would you please be able to add a signoff to the patch (git commit --amend -s) And then obsolete the old ones. Thanks heaps -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17215 --- Comment #7 from Lee Jamison <ldjamison@marywood.edu> --- Sorry about that Chris! Still learning the procedures! I just signed off on it so I'll upload the signed off patch now! Thanks for the info! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17215 Lee Jamison <ldjamison@marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55048|0 |1 is obsolete| | Attachment #55058|0 |1 is obsolete| | --- Comment #8 from Lee Jamison <ldjamison@marywood.edu> --- Created attachment 55092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55092&action=edit Bug 17215 - converted tabs to whitespace To test: 1. Set the autoMemberNum System Preference to "Don't". 2. Login to the OPAC with an LDAP account that does not currently exist as a patron record. 3. Check the patron record's cardnumber. 4. the cardnumber should equal the patron's LDAP username. 5. Delete the patron record. 6. Apply the patch. 7. Set the autoMemberNum System Preference to "Do". 8. Login to the OPAC with an LDAP account that does not currently exist as a patron record. 9. Check the patron record's cardnumber. 10. The cardnumber should now be the next highest cardnumber based on autoMemberNum. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17215 --- Comment #9 from Lee Jamison <ldjamison@marywood.edu> --- I noticed that my last update didn't indicate that the patch was signed off on (still working on figuring out how to do that when I do the git commit/signoff - sorry!). So I'll add it in here manually for archival purposes. Created attachment 55092 Bug 17215 - converted tabs to whitespace https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17215 Signed-off-by: Lee Jamison <ldjamison@marywood.edu> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17215 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55092|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 55264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55264&action=edit Bug 17215 - Cardnumbers of patrons created using LDAP Replication not using autoMemberNum if configured To test: 1. Set the autoMemberNum System Preference to "Don't". 2. Login to the OPAC with an LDAP account that does not currently exist as a patron record. 3. Check the patron record's cardnumber. 4. the cardnumber should equal the patron's LDAP username. 5. Delete the patron record. 6. Apply the patch. 7. Set the autoMemberNum System Preference to "Do". 8. Login to the OPAC with an LDAP account that does not currently exist as a patron record. 9. Check the patron record's cardnumber. 10. The cardnumber should now be the next highest cardnumber based on autoMemberNum. Signed-off-by: Lee Jamison <ldjamison@marywood.edu> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17215 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=6782 CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I have revived by 6782 yesterday and it would fix this bug. Could someone confirm? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17215 --- Comment #12 from Lee Jamison <ldjamison@marywood.edu> --- If I may add my thoughts, 6782's scope is specific to autoMemberNum in regards to the patron creation form. However, 17215 bypasses the patron creation form altogether when Auth_with_ldap.pm triggers. Also, when reviewing the Diff of each bug's latest patch both bugs apply completely different changes. 17215 ONLY modifies C4::Auth_with_ldap while 6782 modifies C4::Members, memberentrygen.tt, and memberentry.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17215 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- The patch from bug 6782 moves the autoMemberNum check to the AddMember subroutine. That means that the cardnumber will be auto-generated at this point. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17215 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |ldjamison@marywood.edu |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17215 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Could someone confirm this is still needed after bug 6782? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17215 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de, | |martin.renvoize@ptfs-europe | |.com --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Patch still applies, sadly, can't test LDAP with my local setup. Maybe try sending an e-mail to the list about this? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17215 --- Comment #16 from Lee Jamison <ldjamison@marywood.edu> --- (In reply to Katrin Fischer from comment #15)
Patch still applies, sadly, can't test LDAP with my local setup. Maybe try sending an e-mail to the list about this?
Are you able to try Nick's LDAP test in Comment 4? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17215 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17215 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Should this be Signed off? I see lots of lines in the patch! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17215 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17215 --- Comment #18 from Lee Jamison <ldjamison@marywood.edu> --- Can anyone confirm if this is still relevant? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17215 Lee Jamison <ldjamison@marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17215 Wanda <janik.hilser@systemli.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|CLOSED |REOPENED CC| |janik.hilser@systemli.org --- Comment #19 from Wanda <janik.hilser@systemli.org> --- I have reopened the bug as the problem was not fixed. It is still the case that the userId is taken as the cardnumber should a patron be created via LDAP. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17215 Janik <janik.hilser@icloud.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|ldjamison@marywood.edu |janik.hilser@icloud.com Status|REOPENED |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17215 Janik <janik.hilser@icloud.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17215 Janik <janik.hilser@icloud.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29930 Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17215 --- Comment #20 from Janik <janik.hilser@icloud.com> --- The bug seems fixed with patch 29930: https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130926&action=diff When creating a new user, an empty cardnumber is now used and thus the setting 'autoMemberNum' is also considered during patron creation To test: 1. Set the autoMemberNum System Preference to "Don't". 2. Login to the OPAC with an LDAP account that does not currently exist as a patron record. 3. Check the patron record's cardnumber. 4. the cardnumber should equal the patron's LDAP username. 5. Delete the patron record. 6. Apply the patch. 7. Set the autoMemberNum System Preference to "Do". 8. Login to the OPAC with an LDAP account that does not currently exist as a patron record. 9. Check the patron record's cardnumber. 10. The cardnumber should now be the next highest cardnumber based on autoMemberNum. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17215 Janik <janik.hilser@icloud.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17215 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29930 CC| |kyle@bywatersolutions.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29930 [Bug 29930] Auth with LDAP: Update tag leads to unwanted updates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17215 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17215 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org