[Bug 20517] New: Use the "sort bin" field in SIP2 Checkin Response
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20517 Bug ID: 20517 Summary: Use the "sort bin" field in SIP2 Checkin Response Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: magnus@libriotech.no QA Contact: testopia@bugs.koha-community.org CC: colin.campbell@ptfs-europe.com The SIP2 Checkin Response (10) can have a "variable-length optional field" for "sort bin", labelled "CL". In the description of the SIP2 protocol, this field is described as follows: "sort bin - CL - variable-length field. This field should contain a bin number that indicates how the items should be sorted. The maximum practical number of sort bins for a patron using 3M SelfCheck system is probably only 3 or 4, but many digits are allowed to accommodate some sort of fantastic sorting device using a hierarchical bin numbering scheme." I have a customer who wants to use this field to display messages on the screen of self service machines that tell users to put items in a separate bin based on itemtype, location etc. The idea is to add a syspref that can contain something like this: itemtype:ILL:1 location:CLOSEDSTACKS:2 - The first field is an item field. - The second field is a value to look for in the given item field - The third field is the value given to the CL field in the SIP2 Checkin Response if the value in the second field matches the item on hand. It should also be possible to set the CL field for items that need to be transferred after they have been returned, that is for items that are returned at another library than the homebranch. This will probably be another syspref. If the returned item needs to be transferred to the homebranch, CL is set to the value of the syspref. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20517 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |magnus@libriotech.no |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20517 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |christophe.croullebois@bibl | |ibre.com --- Comment #1 from Christophe Croullebois <christophe.croullebois@biblibre.com> --- Hello Magnus, we have in Biblibre a specific dev on this topic. We do not use it to indicate to the user where to put the item, but to be used by a sorting machine. I think it is the same, because we put the number of sort bin expected in the CL field. It is more complex than your suggestion, we use two config files .yaml, the first just have the bin number in case of an hold on the item. The second one is more complex, you can use conditions with eq/neq and/or to chose the number of the sortbin based on all 995$ subfields (item fields in Unimarc). So the Library can give many conditions for each sortbin based on all item's Marc subfield. We do not submit this dev because we thought it was not sure it will be agreed by the community. Anyway if you want to examine it I could send it to you. Best regards -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20517 --- Comment #2 from Magnus Enger <magnus@libriotech.no> --- Christophe! That sounds like an excellent enhancement to me! If you submit it, I will try to sign off! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20517 --- Comment #3 from Christophe Croullebois <christophe.croullebois@biblibre.com> --- Created attachment 75126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75126&action=edit Use of the "sort bin" field in SIP2 Checkin Response -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20517 --- Comment #4 from Christophe Croullebois <christophe.croullebois@biblibre.com> --- (In reply to Magnus Enger from comment #2)
Christophe! That sounds like an excellent enhancement to me! If you submit it, I will try to sign off!
Hello Magnus, I have just rebased the patch, as you will see examples in sortbin_reserves.yaml and sortbin_transform.yaml are in French as it was for our use. If this patch seems relevant I maybe could do some changes but I prefer to have advices before because I have not many time. Best regards -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20517 --- Comment #5 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Patch changes the path to the ILS modules - needs to not do that to apply to master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20517 --- Comment #6 from Christophe Croullebois <christophe.croullebois@biblibre.com> --- (In reply to Colin Campbell from comment #5)
Patch changes the path to the ILS modules - needs to not do that to apply to master.
Hi Colin, thx I will change that. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20517 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75126|0 |1 is obsolete| | --- Comment #7 from Christophe Croullebois <christophe.croullebois@biblibre.com> --- Created attachment 75369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75369&action=edit Use of the "sort bin" field in SIP2 Checkin Response -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20517 --- Comment #8 from Magnus Enger <magnus@libriotech.no> --- Just adding a quick note that another way to set the sort bin could be to let plugins do it - that would allow for even more dynamic rules etc. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20517 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20517 --- Comment #9 from Magnus Enger <magnus@libriotech.no> --- Created attachment 103689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103689&action=edit Bug 20517 - Use the "sort bin" field in SIP2 Checkin Response This bug adds the SIP2SortBinMapping to make it possible to tell the Koha SIP2 server to include a sort_bin/CL field in the Checkin Response, if appropriate. To test: - Check out an item and return it via SIP2: $ telnet localhost 8023 9300CNterm1|COterm1|CPCPL| 09N20200422 12430020200422 124300APCPL|AOCPL|AB001|AC| (Where 001 in |AB001| is the barcode of the item in question) - Check there is no CL field in the last response - Apply the patch, fill in SIP2SortBinMapping with e.g.: CPL:itype:BK:3 - Repeat the first step - Check the respons contains a CL field with a value of 3 (or what you put in the config). The field should look like |CL3| - Signe ye offe -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20517 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75369|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20517 --- Comment #10 from Magnus Enger <magnus@libriotech.no> --- I have been putting this off for so long, but I finally found some time to make a patch of my own simple solution. If anyone wants to make a full patch of Christophe's more complex solution that is fine by me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20517 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #11 from Magnus Enger <magnus@libriotech.no> --- Need to revise this a bit. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20517 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20517 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103689|0 |1 is obsolete| | --- Comment #12 from Magnus Enger <magnus@libriotech.no> --- Created attachment 106291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106291&action=edit Bug 20517 - Use the "sort bin" field in SIP2 Checkin Response This bug adds the SIP2SortBinMapping to make it possible to tell the Koha SIP2 server to include a sort_bin/CL field in the Checkin Response, if appropriate. To test: - Check out an item and return it via SIP2: $ telnet localhost 8023 9300CNterm1|COterm1|CPCPL| 09N20200422 12430020200422 124300APCPL|AOCPL|AB001|AC| (Where 001 in |AB001| is the barcode of the item in question) - Check there is no CL field in the last response - Apply the patch, fill in SIP2SortBinMapping with e.g.: CPL:itype:BK:3 - Repeat the first step - Check the respons contains a CL field with a value of 3 (or what you put in the config). The field should look like |CL3| - Signe ye offe 2020-06-25: Pass an item to _get_sort_bin, not a checkout. Rebase. https://bugs.koha-community.org/show_bug.cgi?id=20571 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20517 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- We now have a few local sort bind handlers here, so I have a better understanding of the wider requirements than I did the first time I came across this bug. I have a couple of refinements that I think could help. I think we could do with being able to define the comparison operator rather than always being equality. We have a customer who uses classmark/callnumber for their sorting and as such rather than 'eq' they need '<' comparisons. Also, I think it would be helpful to be able to call item methods not just refer to the internal hashref data.. think 'effective_itemtype'. There may be a use for some special comparison options on the right hand side.. for example one may wish to compare permanent_location to current checking branch to filter items that need transfer into their own bin. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20517 --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Also.. we need unit tests for this. Working on some follow-ups -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20517 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106291|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 129846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129846&action=edit Bug 20517 - Use the "sort bin" field in SIP2 Checkin Response This bug adds the SIP2SortBinMapping to make it possible to tell the Koha SIP2 server to include a sort_bin/CL field in the Checkin Response, if appropriate. To test: - Check out an item and return it via SIP2: $ telnet localhost 8023 9300CNterm1|COterm1|CPCPL| 09N20200422 12430020200422 124300APCPL|AOCPL|AB001|AC| (Where 001 in |AB001| is the barcode of the item in question) - Check there is no CL field in the last response - Apply the patch, fill in SIP2SortBinMapping with e.g.: CPL:itype:BK:3 - Repeat the first step - Check the respons contains a CL field with a value of 3 (or what you put in the config). The field should look like |CL3| - Signe ye offe 2020-06-25: Pass an item to _get_sort_bin, not a checkout. Rebase. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20517 --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 129847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129847&action=edit Bug 20517: Add unit tests This patch adds some unit tests for the new _get_sort_bin function. We're testing that rules are applied in order and that the different comparison operators work as expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20517 --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 129848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129848&action=edit Bug 20517: Add support for specifying comparitor This patch adds support for specifying the comparison operator used in the sort bin method. It allows for more complex cases where one may wish to sort on groups of callnumbers for example. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20517 --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 129849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129849&action=edit Bug 20517: Use the "sort bin" field in SIP2 Checkin Response This bug adds the SIP2SortBinMapping to make it possible to tell the Koha SIP2 server to include a sort_bin/CL field in the Checkin Response, if appropriate. To test: - Check out an item and return it via SIP2: $ telnet localhost 8023 9300CNterm1|COterm1|CPCPL| 09N20200422 12430020200422 124300APCPL|AOCPL|AB001|AC| (Where 001 in |AB001| is the barcode of the item in question) - Check there is no CL field in the last response - Apply the patch, fill in SIP2SortBinMapping with e.g.: CPL:itype:BK:3 - Repeat the first step - Check the respons contains a CL field with a value of 3 (or what you put in the config). The field should look like |CL3| - Signe ye offe 2020-06-25: Pass an item to _get_sort_bin, not a checkout. Rebase. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20517 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129847|0 |1 is obsolete| | --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 129850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129850&action=edit Bug 20517: Add unit tests This patch adds some unit tests for the new _get_sort_bin function. We're testing that rules are applied in order and that the different comparison operators work as expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20517 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129848|0 |1 is obsolete| | --- Comment #20 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 129851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129851&action=edit Bug 20517: Add support for specifying comparitor This patch adds support for specifying the comparison operator used in the sort bin method. It allows for more complex cases where one may wish to sort on groups of callnumbers for example. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20517 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129846|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20517 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129849|0 |1 is obsolete| | --- Comment #21 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 129852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129852&action=edit Bug 20517: Use the "sort bin" field in SIP2 Checkin Response This bug adds the SIP2SortBinMapping to make it possible to tell the Koha SIP2 server to include a sort_bin/CL field in the Checkin Response, if appropriate. To test: - Check out an item and return it via SIP2: $ telnet localhost 8023 9300CNterm1|COterm1|CPCPL| 09N20200422 12430020200422 124300APCPL|AOCPL|AB001|AC| (Where 001 in |AB001| is the barcode of the item in question) - Check there is no CL field in the last response - Apply the patch, fill in SIP2SortBinMapping with e.g.: CPL:itype:BK:3 - Repeat the first step - Check the respons contains a CL field with a value of 3 (or what you put in the config). The field should look like |CL3| - Signe ye offe 2020-06-25: Pass an item to _get_sort_bin, not a checkout. Rebase. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20517 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129850|0 |1 is obsolete| | --- Comment #22 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 129853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129853&action=edit Bug 20517: Add unit tests This patch adds some unit tests for the new _get_sort_bin function. We're testing that rules are applied in order and that the different comparison operators work as expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20517 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129851|0 |1 is obsolete| | --- Comment #23 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 129854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129854&action=edit Bug 20517: Add support for specifying comparitor This patch adds support for specifying the comparison operator used in the sort bin method. It allows for more complex cases where one may wish to sort on groups of callnumbers for example. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20517 --- Comment #24 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 129855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129855&action=edit Bug 20517: (QA follow-up) Fix return undef. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20517 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20517 Emmanuel Bétemps <e.betemps@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |e.betemps@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20517 jmbroust <jean-manuel.broust@univ-lyon2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jean-manuel.broust@univ-lyo | |n2.fr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20517 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129852|0 |1 is obsolete| | Attachment #129853|0 |1 is obsolete| | Attachment #129854|0 |1 is obsolete| | Attachment #129855|0 |1 is obsolete| | --- Comment #25 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 132555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132555&action=edit Bug 20517: Use the "sort bin" field in SIP2 Checkin Response This bug adds the SIP2SortBinMapping to make it possible to tell the Koha SIP2 server to include a sort_bin/CL field in the Checkin Response, if appropriate. To test: - Check out an item and return it via SIP2: $ telnet localhost 8023 9300CNterm1|COterm1|CPCPL| 09N20200422 12430020200422 124300APCPL|AOCPL|AB001|AC| (Where 001 in |AB001| is the barcode of the item in question) - Check there is no CL field in the last response - Apply the patch, fill in SIP2SortBinMapping with e.g.: CPL:itype:BK:3 - Repeat the first step - Check the respons contains a CL field with a value of 3 (or what you put in the config). The field should look like |CL3| - Signe ye offe 2020-06-25: Pass an item to _get_sort_bin, not a checkout. Rebase. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Current status: Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20517 --- Comment #26 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 132556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132556&action=edit Bug 20517: Add unit tests This patch adds some unit tests for the new _get_sort_bin function. We're testing that rules are applied in order and that the different comparison operators work as expected. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20517 --- Comment #27 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 132557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132557&action=edit Bug 20517: Add support for specifying comparitor This patch adds support for specifying the comparison operator used in the sort bin method. It allows for more complex cases where one may wish to sort on groups of callnumbers for example. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20517 --- Comment #28 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 132558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132558&action=edit Bug 20517: (QA follow-up) Fix return undef. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20517 --- Comment #29 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 132559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132559&action=edit Bug 20517: (follow-up) Add explanation to syspref and fix QA issues I added explanatory text to staff interface on the preference to explain how it works Removed a debug warn in the _get_sort_bin routine changed comparitor => comparator fixed a missing call in the tests Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20517 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #30 from Nick Clemens <nick@bywatersolutions.com> --- Martin's follow-ups here added a decent bit of functionality, so this needs another QA run. I love this enhancement, I think partners will find it useful, but I have a few concerns: 1 - In a larger consortium this could start to have performance impacts as we iterate through all the lines 2 - We are moving from SIPConfig to syspref control - I like this, but as above it removes config per SIP login to global 3 - The syntax is non-standard, I would love to see this use YAML, that could allow for things like 'field_value:X' and 'compare_field:holdingbranch' rather than '\$holdingbranch' I don't think these are blockers, as it is this is simple and straightforward, so I don't want to mess with that. Leaving for another QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20517 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20517 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20517 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132555|0 |1 is obsolete| | Attachment #132556|0 |1 is obsolete| | Attachment #132557|0 |1 is obsolete| | Attachment #132558|0 |1 is obsolete| | Attachment #132559|0 |1 is obsolete| | --- Comment #31 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 132591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132591&action=edit Bug 20517: Use the "sort bin" field in SIP2 Checkin Response This bug adds the SIP2SortBinMapping to make it possible to tell the Koha SIP2 server to include a sort_bin/CL field in the Checkin Response, if appropriate. To test: - Check out an item and return it via SIP2: $ telnet localhost 8023 9300CNterm1|COterm1|CPCPL| 09N20200422 12430020200422 124300APCPL|AOCPL|AB001|AC| (Where 001 in |AB001| is the barcode of the item in question) - Check there is no CL field in the last response - Apply the patch, fill in SIP2SortBinMapping with e.g.: CPL:itype:BK:3 - Repeat the first step - Check the respons contains a CL field with a value of 3 (or what you put in the config). The field should look like |CL3| - Signe ye offe 2020-06-25: Pass an item to _get_sort_bin, not a checkout. Rebase. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20517 --- Comment #32 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 132592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132592&action=edit Bug 20517: Add unit tests This patch adds some unit tests for the new _get_sort_bin function. We're testing that rules are applied in order and that the different comparison operators work as expected. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20517 --- Comment #33 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 132593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132593&action=edit Bug 20517: Add support for specifying comparitor This patch adds support for specifying the comparison operator used in the sort bin method. It allows for more complex cases where one may wish to sort on groups of callnumbers for example. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20517 --- Comment #34 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 132594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132594&action=edit Bug 20517: (QA follow-up) Fix return undef. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20517 --- Comment #35 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 132595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132595&action=edit Bug 20517: (follow-up) Add explanation to syspref and fix QA issues I added explanatory text to staff interface on the preference to explain how it works Removed a debug warn in the _get_sort_bin routine changed comparitor => comparator fixed a missing call in the tests Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20517 --- Comment #36 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 132596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132596&action=edit Bug 20517: (QA follow-up) Add ability to override syspref with account level settings in SIP config file Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20517 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20517 --- Comment #37 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20517 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20517 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20058 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20517 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |Caroline Cyr La Rose contact| | CC| |caroline.cyr-la-rose@inlibr | |o.com Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/665 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20517 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34737 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34737 [Bug 34737] Enhance SIP2SortBinMapping to support additional match conditions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20517 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23@gmail.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org