[Bug 25520] New: Change wording on SMS phone number set up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25520 Bug ID: 25520 Summary: Change wording on SMS phone number set up Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: kelly@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com The wording in the staff interface when a staff member is adding an SMS number is confusing. Could we show two different formats to enter a phone number? For example: SMS number should be in the format 9876543210 or +11234567890 On the OPAC, I believe it looks clearer to users: Please enter numbers only. (123) 456-7890 would be entered as 1234567890. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25520 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25520 David Roberts <david.roberts@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |david.roberts@ptfs-europe.c | |om Assignee|koha-bugs@lists.koha-commun |david.roberts@ptfs-europe.c |ity.org |om -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25520 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Assignee|david.roberts@ptfs-europe.c |david@davidnind.com |om | --- Comment #1 from David Nind <david@davidnind.com> --- The current text is different now: - Staff interface: "Please enter numbers only. Prefix the number with + or 00 if including the country code." - OPAC: "Please enter numbers only. Prefix the number with + if including the country code." They are a little more consistent, but have got out of sync. I would suggest changing the OPAC text to the same as the staff interface - adding "..or 00..". History of recent changes: - Bug 26299: both staff interface and OPAC changed to "Please enter numbers only. Prefix the number with + if including the country code.", change made in 20.11 - Bug 30026: staff interface changed from above to "Please enter numbers only. Prefix the number with + or 00 if including the country code.", changed addded "..or 00..", change made in 22.11.00, 22.05.03 (see comments 9 to 11) Testing notes: 1. Set SMSSendDriver to Email 2. To enter an SMS number in the staff interface: 2.1 Go to Patrons > + New patron > Patron. 2.2 Scroll down to the 'Patron messaging preferences' section at the end of the page. 2.3 Note that the hint is "Please enter numbers only. Prefix the number with + or 00 if including the country code.". 2.3 Results for entering different numbers and formats: 987654321 => accepted edit and add some letters => letters are removed as you enter them edit and try and add some dashes 987-654-321 => the dashes are removed edit and try and add some brackets (987) 999-654-321 => the brackets are removed edit and try and add some spaces 987 654 321 => the spaces are removed +64003987654321 => accepted 003987654321 => accepted 3. To enter an SMS number in the OPAC: 3.1 Go to OPAC > Your account (may have to log in). 3.2 Select the 'Messaging' tab/section. 3.3 Note that the hint is "Please enter numbers only. Prefix the number with + if including the country code.". 3.3 Results for entering different numbers and formats: 987654321 => accepted edit and add some letters => letters are removed as you enter them edit and try and add some dashes 987-654-321 => the dashes are removed edit and try and add some brackets (987) 999-654-321 => the brackets are removed edit and try and add some spaces 987 654 321 => the spaces are removed +64003987654321 => accepted 003987654321 => accepted -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25520 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25520 --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 167367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167367&action=edit Bug 25520: Fix the SMS number input hint on the OPAC messaging page This makes the hint when entering an SMS number on the OPAC messaging settings page the same as the staff interface hint: "Please enter numbers only. Prefix the number with + or 00 if including the country code." For some countries using either +XX or 00XX are accepted, for example: +49 or 0049. Test plan: 1. Set the SMSSendDriver system preference to Email 2. View the current hint for entering an SMS number in the staff interface: 2.1 Go to Patrons > + New patron > Patron. 2.2 Scroll down to the 'Patron messaging preferences' section at the end of the page. 2.3 Note that the hint is "Please enter numbers only. Prefix the number with + or 00 if including the country code.". 3. View the current hint for entering an SMS number in the OPAC: 3.1 Go to the OPAC > Your account (log in if required). 3.2 Select the 'Messaging' tab/section. 3.3 Note that the hint is "Please enter numbers only. Prefix the number with + if including the country code.". 3.4 The difference: "..or 00.." is missing. 4. Apply the patch. 5. Refresh the OPAC messaging page. 6. The hint text for the OPAC is now the same as the staff interface. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25520 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Severity|enhancement |trivial Text to go in the| |This fixes the hint when release notes| |entering an SMS number on | |the OPAC messaging settings | |page - it is now the same | |as the staff interface | |patron hint. Keywords| |Sandbox -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25520 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26299, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30026 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25520 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25520 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167367|0 |1 is obsolete| | --- Comment #3 from Sam Lau <samalau@gmail.com> --- Created attachment 167409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167409&action=edit Bug 25520: Fix the SMS number input hint on the OPAC messaging page This makes the hint when entering an SMS number on the OPAC messaging settings page the same as the staff interface hint: "Please enter numbers only. Prefix the number with + or 00 if including the country code." For some countries using either +XX or 00XX are accepted, for example: +49 or 0049. Test plan: 1. Set the SMSSendDriver system preference to Email 2. View the current hint for entering an SMS number in the staff interface: 2.1 Go to Patrons > + New patron > Patron. 2.2 Scroll down to the 'Patron messaging preferences' section at the end of the page. 2.3 Note that the hint is "Please enter numbers only. Prefix the number with + or 00 if including the country code.". 3. View the current hint for entering an SMS number in the OPAC: 3.1 Go to the OPAC > Your account (log in if required). 3.2 Select the 'Messaging' tab/section. 3.3 Note that the hint is "Please enter numbers only. Prefix the number with + if including the country code.". 3.4 The difference: "..or 00.." is missing. 4. Apply the patch. 5. Refresh the OPAC messaging page. 6. The hint text for the OPAC is now the same as the staff interface. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Sam Lau <samalau@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25520 --- Comment #4 from David Nind <david@davidnind.com> --- Thanks for the sign-off Sam! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25520 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25520 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167409|0 |1 is obsolete| | --- Comment #5 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 167459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167459&action=edit Bug 25520: Fix the SMS number input hint on the OPAC messaging page This makes the hint when entering an SMS number on the OPAC messaging settings page the same as the staff interface hint: "Please enter numbers only. Prefix the number with + or 00 if including the country code." For some countries using either +XX or 00XX are accepted, for example: +49 or 0049. Test plan: 1. Set the SMSSendDriver system preference to Email 2. View the current hint for entering an SMS number in the staff interface: 2.1 Go to Patrons > + New patron > Patron. 2.2 Scroll down to the 'Patron messaging preferences' section at the end of the page. 2.3 Note that the hint is "Please enter numbers only. Prefix the number with + or 00 if including the country code.". 3. View the current hint for entering an SMS number in the OPAC: 3.1 Go to the OPAC > Your account (log in if required). 3.2 Select the 'Messaging' tab/section. 3.3 Note that the hint is "Please enter numbers only. Prefix the number with + if including the country code.". 3.4 The difference: "..or 00.." is missing. 4. Apply the patch. 5. Refresh the OPAC messaging page. 6. The hint text for the OPAC is now the same as the staff interface. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25520 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com QA Contact|testopia@bugs.koha-communit |matt.blenkinsop@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25520 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25520 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for all the hard work! Pushed to main for the next 24.11.00 release as RM Assistant -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25520 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.11.00 |24.11.00,24.05.02 released in| | CC| |lucas@bywatersolutions.com Status|Pushed to main |Pushed to stable --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25520 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to stable |Pushed to oldstable Version(s)|24.11.00,24.05.02 |24.11.00,24.05.02,23.11.07 released in| | --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.07 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25520 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25520 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #9 from wainuiwitikapark@catalyst.net.nz --- Not backporting to 23.05.x unless requested -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25520 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #10 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org