https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43389 --- Comment #3 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 205234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205234&action=edit Bug 43389: Remove conditional TT tags from holdings table thead The item tables are built with TT's IFs conditions inside their `thead`, changing the number of rendered columns depending on system preferences and permissions. This is the pattern already fixed by bug 42332. Column visibility is now driven by the existing table_settings 'visibility_condition' mechanism. A 'create_analytics' column was added to admin/columns_settings.yml for the "Create analytics" header Test plan: On a bibliographic record with items (catalogue/detail.pl), toggle each of these system preferences one at a time and reload the page: LocalCoverImages, EnableItemGroups, EasyAnalyticalRecords, UseCourseReserves. Confirm the matching column appears/disappears in both the "Holdings" and "Other holdings" tabs, with no JS errors in the console. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.