[Bug 41368] New: Tools/ManageMarcImport_spec.ts is failing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41368 Bug ID: 41368 Summary: Tools/ManageMarcImport_spec.ts is failing Initiative type: --- Sponsorship --- status: Product: Project Infrastructure Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Continuous Integration Assignee: tomascohen@gmail.com Reporter: lucas@bywatersolutions.com To recreate: 1. cypress run --spec t/cypress/integration/Tools/ManageMarcImport_spec.ts 2. It fails -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41368 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41368 --- Comment #1 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 190126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190126&action=edit Bug 41368: Set new values directly in DOM To test: 1. APPLY PATCH, yarn build 2. cypress run --spec t/cypress/integration/Tools/ManageMarcImport_spec.ts 3. it passes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41368 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Assignee|tomascohen@gmail.com |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41368 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190126|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41368 --- Comment #2 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 190131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190131&action=edit Bug 41368: Fix View batch click To test: 1. APPLY PATCH 2. yarn build 3. cypress run --spec t/cypress/integration/Tools/ManageMarcImport_spec.ts 4. It should now pass -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41368 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |41177 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41177 [Bug 41177] Breadcrumbs should have aria-disabled attribute if its the current page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41368 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41368 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190131|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 190143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190143&action=edit Bug 41368: Fix View batch click To test: 1. APPLY PATCH 2. yarn build 3. cypress run --spec t/cypress/integration/Tools/ManageMarcImport_spec.ts 4. It should now pass Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41368 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- It does not fail for me without the patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41368 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |40046 --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- we had random failures reported on bug 41368. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40046 [Bug 40046] Remove wait and screenshot from Tools/ManageMarcImport_spec.ts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41368 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- we had random failures reported on bug 40046. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41368 Bug 41368 depends on bug 41177, which changed state. Bug 41177 Summary: Breadcrumbs should have aria-disabled attribute if its the current page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41177 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41368 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41368 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190143|0 |1 is obsolete| | --- Comment #7 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 192623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192623&action=edit Bug 41368: Fix View batch click To test: 1. APPLY PATCH 2. yarn build 3. cypress run --spec t/cypress/integration/Tools/ManageMarcImport_spec.ts 4. It should now pass Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41368 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #8 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #4)
It does not fail for me without the patch.
It did for me ;-) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41368 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |26.05.00 release notes| | Status|Passed QA |Pushed to main --- Comment #9 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Pushed to main for 26.05.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41368 --- Comment #10 from Jonathan Druart <jonathan.druart@gmail.com> --- Still failing Koha_Main/3683 20:06:17 <testcase name="loads the manage MARC import page upload a MARC record" time="0.000" classname="upload a MARC record"> 20:06:17 <failure message="Timed out retrying after 10000ms: Expected to find content: 'View batch' within the element: <div#job_callback> but never did." type="AssertionError"><![CDATA[AssertionError: Timed out retrying after 10000ms: Expected to find content: 'View batch' within the element: <div#job_callback> but never did. 20:06:17 at Context.eval (webpack://koha/./t/cypress/integration/Tools/ManageMarcImport_spec.ts:75:32)]]></failure> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41368 --- Comment #11 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 196533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196533&action=edit Bug 41368: Fix ManageMarcImport Cypress test timing issue Replace the `#job_callback` existence check (which passed immediately since the div is always present in the DOM) with a wait on the progress bar gaining `bg-success` class. This class is added by job_progress.js only when the background job has genuinely finished, ensuring the finish_callback has already fired and "View batch" is present before Cypress tries to click it -- eliminating the 10s timeout race on slow CI. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41368 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196533|0 |1 is obsolete| | Attachment #192623|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41368 --- Comment #12 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 196534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196534&action=edit Bug 41368: Fix ManageMarcImport Cypress test timing issue Replace the `#job_callback` existence check (which passed immediately since the div is always present in the DOM) with a wait on the progress bar gaining `bg-success` class. This class is added by job_progress.js only when the background job has genuinely finished, ensuring the finish_callback has already fired and "View batch" is present before Cypress tries to click it -- eliminating the 10s timeout race on slow CI. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41368 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196534|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41368 --- Comment #13 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 196535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196535&action=edit Bug 41368: Fix ManageMarcImport Cypress test timing issue Replace the no-op `#job_callback` existence check with a recursive `cy.wait('@jobPoll')` that loops through each `/api/v1/jobs/*` poll response (arriving every ~1s) until it sees `status: finished`. This avoids any fixed timeout — the test proceeds as soon as the API signals completion, however long that takes on a given machine. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41368 --- Comment #14 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Pushed Martin's patch to main, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41368 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|26.05.00 | release notes| | Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41368 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #15 from Fridolin Somers <fridolin.somers@biblibre.com> --- I see it is in 25.11.04 and 24.11.14 but I dont see it in 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41368 --- Comment #16 from Jonathan Druart <jonathan.druart@gmail.com> --- Koha_Main/3783 17:48:09 Running: Tools/ManageMarcImport_spec.ts (53 of 58) 17:48:09 <?xml version="1.0" encoding="UTF-8"?> 17:48:09 <testsuites name="Mocha Tests" time="19.881" tests="3" failures="1"> 17:48:09 <testsuite name="Root Suite" timestamp="2026-05-23T17:47:49" tests="0" file="t/cypress/integration/Tools/ManageMarcImport_spec.ts" time="0.000" failures="0"> 17:48:12 </testsuite> 17:48:12 <testsuite name="Breadcrumb tests" timestamp="2026-05-23T17:47:49" tests="1" time="2.596" failures="0"> 17:48:12 <testcase name="Breadcrumb tests Breadcrumbs" time="2.629" classname="Breadcrumbs"> 17:48:12 </testcase> 17:48:12 </testsuite> 17:48:12 <testsuite name="loads the manage MARC import page" timestamp="2026-05-23T17:47:51" tests="2" time="17.197" failures="1"> 17:48:12 <testcase name="loads the manage MARC import page loads the manage MARC import page" time="2.174" classname="loads the manage MARC import page"> 17:48:12 </testcase> 17:48:12 <testcase name="loads the manage MARC import page upload a MARC record" time="0.000" classname="upload a MARC record"> 17:48:12 <failure message="Timed out retrying after 10000ms: `cy.wait()` timed out waiting `10000ms` for the 2nd request to the route: `jobPoll`. No request ever occurred. 17:48:12 17:48:12 https://on.cypress.io/wait" type="CypressError"><![CDATA[CypressError: Timed out retrying after 10000ms: `cy.wait()` timed out waiting `10000ms` for the 2nd request to the route: `jobPoll`. No request ever occurred. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41368 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@openfifth.co.u | |k Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41368 --- Comment #17 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Created attachment 199750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199750&action=edit Bug 41368: Job progress fix waitForJobFinished previously had no handling for failed jobs or non-200 responses — if the job API returned anything unexpected, the recursive cy.wait() would silently stall waiting for a 2nd poll that never came, producing a confusing timeout. Adds an explicit "failed" status check and updates the intercept to reproduce the exact CI failure (Apache returning 503 during reset_all). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41368 --- Comment #18 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Created attachment 199751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199751&action=edit Bug 41368: Add tests Apply tests patch only, run: yarn cypress run --spec t/cypress/integration/Tools/ManageMarcImport_spec.ts Confirm it fails with the same error as Jenkins: Timed out retrying after 10000ms: `cy.wait()` timed out waiting `10000ms` for the 2nd request to the route: `jobPoll`. No request ever occurred. Apply fix patch. Run again. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41368 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42733 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42733 [Bug 42733] Tools/ManageMarcImport_spec.ts is failing (again) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41368 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199751|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41368 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199750|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41368 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #19 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Follow-up patches moved to bug 42733 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41368 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Version(s)|26.05.00 |26.05.00,25.11.04,25.05.12 released in| | Status|Pushed to main |Pushed to stable --- Comment #20 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Backported to 25.05.x for 25.05.12 - test was passing before applying patch but still applying for the sake of jenkins tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41368 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41368 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41368 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |Needs documenting --- Comment #21 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 41177 not in 24.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org