[Bug 35582] New: Advanced search languages should be listed with selected UI language descriptions shown first if available
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35582 Bug ID: 35582 Summary: Advanced search languages should be listed with selected UI language descriptions shown first if available Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: lmstrand@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Languages are being showed by their localized name first in the advanced search language limit dropdowns and the user's intranet language selection's description follows next (or defaults to English). It's hard to select the language you want from the list if the languages' descriptions are written in the way they are written in the country the language is being used, Suomi (Finnish) or ལྷ་སའི་སྐད་ (Standard Tibetan) for example. They should be listed by the language description that matches the user's selected language in the intranet first and then the local name, like Finnish (Suomi), Standard Tibetan (ལྷ་སའི་སྐད)་ if the intranet language selection is English for example. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35582 --- Comment #1 from Lari Strand <lmstrand@gmail.com> --- Created attachment 159892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159892&action=edit Bug 35582 - Show advanced search languages with selected intranet language descriptions first -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35582 Lari Strand <lmstrand@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35582 --- Comment #2 from Lari Strand <lmstrand@gmail.com> --- We are also using an intranetUserJS-string to alphabetize and prioritize the languages which obviously does not work as intended if the native description is showing first instead of the selected UI language's description. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35582 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |lucas@bywatersolutions.com --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- Lari, The patch seems to work but could you provide a test plan? Also, please mind the the QA tool: Processing additional checks * Commit title does not start with 'Bug XXXXX: ' - 80ed34f406 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35582 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I agree with the idea, but there is a problem: The translations are are not handled by po files, but are stored in the database and we only have very few translations in the standard files. And there is no way to add translations apart from using SQL. So a lot of people might see a list sorted by the English translations/descriptions. Just to be aware of. For testing French and German should work reasonably well. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35582 Lari Strand <lmstrand@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159892|0 |1 is obsolete| | --- Comment #5 from Lari Strand <lmstrand@gmail.com> --- Created attachment 160621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160621&action=edit Bug 35582: Advanced search languages should be listed with selected UI language descriptions shown first if available -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35582 --- Comment #6 from Lari Strand <lmstrand@gmail.com> --- To test: 1) Go to advanced search and bring up the language pulldowns from the Limits section 2) Notice the languages are shown with their native description first 3) Apply patch 4) Bring up the languages dropdowns and notice the localized language translations are shown first if the language (selected intranet language) has a local translation in language_descriptions table, otherwise defaulting to the English translation. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35582 Lari Strand <lmstrand@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #7 from Lari Strand <lmstrand@gmail.com> --- I can provide full Finnish and Swedish translations for the language codes if interested. I seems a couple of language codes are missing altogether from the English language descriptions in 23x. Here's a few: afa | Afroasiatic languages bua | Buriat fro | French, Old (ca. 842-1400) haw | Hawaiian lad | Ladino nai | North American Indian languages tmh | Tamashek wol | Wolof I can open another ticket for this / these. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35582 --- Comment #8 from Lari Strand <lmstrand@gmail.com> --- Seems a couple of language codes are missing altogether
from the English language descriptions in 23x. Here's a few:
afa | Afroasiatic languages bua | Buriat fro | French, Old (ca. 842-1400) haw | Hawaiian lad | Ladino nai | North American Indian languages tmh | Tamashek wol | Wolof
Sorry these were missing from our Finnish/Swedish translations. English translations that seem to be missing: afa, chu, den, haw, sqn -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35582 --- Comment #9 from Lari Strand <lmstrand@gmail.com> --- Just found the ticket about adding more language codes/translations: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33134 I'll join/follow the discussion there. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35582 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- The patch still needs the test plan to be added to the commit message. Can you take a look at the perltidy warning shown by the qa tool? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35582 --- Comment #11 from Lari Strand <lmstrand@gmail.com> --- The qa tool complains about this row: $language_subtag_registry->{language_description}.=" ($native_description)"; If I delete the row from the commit, the qa passes. The line is like a copy-paste from the old code line: $language_subtag_registry->{language_description}.=" ($language_descriptions->{description})" if $language_descriptions->{description}; I can't get it to pass validation without breaking the code. It's still valid perl and perltidy in VSCode doesn't want to touch the row (using perltidyrc from https://git.koha-community.org/Koha-community/Koha/src/commit/7e8f41cce9353a... if I recall). How do we move forward from this? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35582 --- Comment #12 from Lari Strand <lmstrand@gmail.com> --- If I run the whole file through pertidy the qa tool is happy. There's 211 dirty lines in the file according to qa tool before the commit. Don't know how many messy lines got "fixed" by perltidy, but the qa tool is happy if there's less of them than before the commit it seems. Isn't this a problem with the qa tool for falsely reporting my committed line as messy rather that it actually being a messy new line? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35582 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Lari Strand from comment #12)
If I run the whole file through pertidy the qa tool is happy. There's 211 dirty lines in the file according to qa tool before the commit. Don't know how many messy lines got "fixed" by perltidy, but the qa tool is happy if there's less of them than before the commit it seems. Isn't this a problem with the qa tool for falsely reporting my committed line as messy rather that it actually being a messy new line?
I think the truth is in the middle. If I tidy just the if-else block the tests pass too. The lines show as changed in the patch - I guess that's what triggers. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35582 Lari Strand <lmstrand@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35582 Lari Strand <lmstrand@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160621|0 |1 is obsolete| | --- Comment #14 from Lari Strand <lmstrand@gmail.com> --- Created attachment 162293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162293&action=edit Bug 35582: Show advanced search languages with selected intranet language descriptions first To test: 1. Check language dropdowns in advanced search, notice localized names of the languages are shown first in the menus, then the selected ui language translations if available or the english translation 2. Apply patch 3. Check language dropdowns, notice the selected ui language's translations are shown first for the languages (if missing, english translation), then the localized language's name. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35582 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35582 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162293|0 |1 is obsolete| | --- Comment #15 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 162302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162302&action=edit Bug 35582: Show advanced search languages with selected intranet language descriptions first To test: 1. Check language dropdowns in advanced search, notice localized names of the languages are shown first in the menus, then the selected ui language translations if available or the english translation 2. Apply patch 3. Check language dropdowns, notice the selected ui language's translations are shown first for the languages (if missing, english translation), then the localized language's name. Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35582 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@ptfs-europe.co | |m --- Comment #16 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- prove t/db_dependent/Languages.t pass Had to install arab, finish and french, added "ara|fin|fre" to AdvancedSearchLanguages, only then was able to test the advanced search language dropdown. Everything works as described. Makes sense. Perhaps this same enhancement could/should be considered for INTRA/OPAC (req opaclanguagesdisplay) language pickers (default at bottom of page) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35582 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35582 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35582 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162302|0 |1 is obsolete| | --- Comment #17 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 165692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165692&action=edit Bug 35582: Show advanced search languages with selected intranet language descriptions first To test: 1. Check language dropdowns in advanced search, notice localized names of the languages are shown first in the menus, then the selected ui language translations if available or the english translation 2. Apply patch 3. Check language dropdowns, notice the selected ui language's translations are shown first for the languages (if missing, english translation), then the localized language's name. Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35582 --- Comment #18 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 165693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165693&action=edit Bug 35582: Supress possible warning Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35582 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35582 --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35582 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|24.05.00 |24.05.00,23.11.06 released in| | CC| |fridolin.somers@biblibre.co | |m --- Comment #20 from Fridolin Somers <fridolin.somers@biblibre.com> --- Nice small enhancement, I backport Pushed to 23.11.x for 23.11.06 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35582 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00,23.11.06 |24.05.00,23.11.06,23.05.12 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #21 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 23.05.x for upcoming 23.05.12 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35582 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #22 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 unless requested -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org