[Bug 24243] New: Bad characters in AMRC cause internal server error when searching catalog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24243 Bug ID: 24243 Summary: Bad characters in AMRC cause internal server error when searching catalog Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Koha::Biblio::Metadata::record can throw an exception, it must always be caught If CoinsInOpac is enabled we call 'get_coins' on the search results - get_coins calls for the record. On the staff details page this exception is handled but not in opac results. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24243 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Bad characters in AMRC |Bad characters in MARC |cause internal server error |cause internal server error |when searching catalog |when searching catalog -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24243 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |danielle@bywatersolutions.c | |om, | |jonathan.druart@bugs.koha-c | |ommunity.org, | |liz@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24243 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23846 Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24243 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24243 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 96295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96295&action=edit Bug 24243: Do not explode if invalid metadata when searching catalogue If the bibliographic record metadata cannot be decoded, the get_coins call should catch the exception raised by Koha::Biblio::Metadata->record to not explode Error is: "Invalid data, cannot decode objec" Test plan: 0/ Do not apply the patch 1/ Search for record at the OPAC 2/ Note one of the biblionumber from the first page result 3/ Set to empty string the biblio_metadata to make the error appears: update biblio_metadata set metadata="" where biblionumber=42; 4/ Try the same search => You get an internal server error 5/ Apply the patch, restart plack and try again => It now works, ie. it does not explode -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24243 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com --- Comment #2 from Liz Rea <wizzyrea@gmail.com> --- this happens in the record exporter as well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24243 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24243 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96295|0 |1 is obsolete| | --- Comment #3 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 96340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96340&action=edit Bug 24243: Do not explode if invalid metadata when searching catalogue If the bibliographic record metadata cannot be decoded, the get_coins call should catch the exception raised by Koha::Biblio::Metadata->record to not explode Error is: "Invalid data, cannot decode objec" Test plan: 0/ Do not apply the patch 1/ Search for record at the OPAC 2/ Note one of the biblionumber from the first page result 3/ Set to empty string the biblio_metadata to make the error appears: update biblio_metadata set metadata="" where biblionumber=42; 4/ Try the same search => You get an internal server error 5/ Apply the patch, restart plack and try again => It now works, ie. it does not explode Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24243 --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Shouldn't we log the error? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24243 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Nick Clemens from comment #4)
Shouldn't we log the error?
There is a check in search_for_data_inconsistencies.pl, so I'd say it's not needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24243 --- Comment #6 from Liz Rea <wizzyrea@gmail.com> ---
From a troubleshooting point of view, that would be nice.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24243 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- There will be a warning on the detail page of the problematic record anyway (from bug 23846) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24243 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24243 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96340|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 96573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96573&action=edit Bug 24243: Do not explode if invalid metadata when searching catalogue If the bibliographic record metadata cannot be decoded, the get_coins call should catch the exception raised by Koha::Biblio::Metadata->record to not explode Error is: "Invalid data, cannot decode objec" Test plan: 0/ Do not apply the patch 1/ Search for record at the OPAC 2/ Note one of the biblionumber from the first page result 3/ Set to empty string the biblio_metadata to make the error appears: update biblio_metadata set metadata="" where biblionumber=42; 4/ Try the same search => You get an internal server error 5/ Apply the patch, restart plack and try again => It now works, ie. it does not explode Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24243 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Maybe we should think about displaying a more specific error, currently in the intranet you see: The record you requested does not exist (2). It's not quite correct. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24243 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24243 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24243 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |lucas@bywatersolutions.com --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 19.11.x for 19.11.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24243 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable --- Comment #12 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 19.05.x for 19.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24243 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.01 released in| | CC| |joy@bywatersolutions.com --- Comment #13 from Joy Nelson <joy@bywatersolutions.com> --- Pushed to 19.11.01 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org