http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7442 --- Comment #1 from Adrien SAURAT <adrien.saurat@biblibre.com> 2012-01-13 13:46:34 UTC --- Created attachment 7135 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7135 proposed patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7442 --- Comment #2 from Adrien SAURAT <adrien.saurat@biblibre.com> 2012-01-13 14:51:22 UTC --- [MT8560] I tested with an UNIMARC db. Would it be also ok with MARC21 ? (the code about the biblio 600 field is not modified, only the authority 200$a and 200$b) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7442 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jcamins@cpbibliography.com --- Comment #4 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- (In reply to comment #3)

I think you need to wrap this in a check for the marcflavour and only do this if it is UNIMARC

Agreed. I don't think there is an analogous problem in MARC21, or, if there is, I have never seen it. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7442 Adrien SAURAT <adrien.saurat@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7135|0 |1 is obsolete| | --- Comment #6 from Adrien SAURAT <adrien.saurat@biblibre.com> --- Created attachment 9410 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9410&action=edit proposed patch #2 Now with encapsulation for UNIMARC. I know little about the differences between the different formats so I separated the code almost totally, but if someone sees a way to refactor safely just tell me I'll make a new patch. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7442 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P3 CC| |katrin.fischer@bsz-bw.de Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7442 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr Depends on| |4838 --- Comment #8 from Frédéric Demians <frederic@tamil.fr> --- Adrien, don't you think that this patch will break bug 4838? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7442 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7442 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9410|0 |1 is obsolete| | --- Comment #10 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 19776 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19776&action=edit Bug 7442 - Crash when selecting an authority with 200$x or 200$y I worked on a way to correct this bug and keeping the " -- " possible in authority summary. I've chosen to use " | " as multiple headings separator. If this must be configurable, I'll do so. See commit message. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7442 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7442 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19776|0 |1 is obsolete| | --- Comment #12 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 19778 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19778&action=edit [SIGNED-OFF] Bug 7442 - Crash when selecting an authority with 200$x or 200$y I can confirm the problem and the solution. I have tested the patch on a large DB with authorities having multiples headings. There is no regression on bug 4838 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7442 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7442 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I had problems last time to test this, because I was not able to create authorities in my UNIMARC installation. Could you please provide some instructions? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7442 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Fridolyn, I have my own UNIMARC installation with the data from the sandbox. My problem is I need to create a test case to see if this works correctly and my cataloguing skills in UNIMARC are limited. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7442 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Fridolyn, see comment 14 - I need instructions on how to correctly catalog a UNIMARC authority with the required fields to reproduce this problem. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7442 --- Comment #20 from Chris Cormack <chris@bigballofwax.co.nz> --- (In reply to Fridolyn SOMERS from comment #19)

(In reply to Katrin Fischer from comment #18)

...

Fridolyn, see comment 14 - I need instructions on how to correctly catalog a UNIMARC authority with the required fields to reproduce this problem. Don't you have existing authorities ?

They don't use UNIMARC in Germany, so no. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7442 --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 23152 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23152&action=edit [PASSED QA] Bug 7442 - Crash when selecting an authority with 200$x or 200$y

From a biblio record, if one wants to add a 600$a information, a pop-up appears. On this new window, on search terms typed and validated, a table result is displayed, with a column "Get It!" allowing the selection of an authority. From here, different cases:

1) If we have a simple authority with 200$a and 200$b subfields, a link "choose" is displayed, working correctly. 2) If the authority has different occurences of 200$a/200$b, numeric links (1 2 and so on) are displayed, one for each occurence. In the example of my screenshot, the line with a "Paul, Korky -- Pauline, Korkette" summary possesses two links : "1" will add "Paul, Korky" whereas "2" will add "Pauline, Korkette" (couldn't come up with a better name ;)). 3) If the authority has 200$x or 200$y subfields defined, several links are also created, when it should not be the case. In our example, "Niclausse, Paul -- Expositions" will create a link "1" for "Niclausse, Paul" and a link "2" for "Expositions". Clicking on the 2nd link leads to the following error: Software error: Can't call method "subfields" on an undefined value at /home/asaurat/workspace/versions/community/authorities/blinddetail-biblio-search.pl line 86. Only the cases 1 and 2 should be handled. The creation of links for subfields like 200$x or 200$y should be removed. This problem is caused by the use of " -- " has separator of authorities with several headings, but also in some heading between main part and subdivisions. This patch corrects this by using an arry in authorities summary so that presentation is computed in template. I've choosen to use the pipe separator between authorities with several headings. This may be changed to be configurable. Test plan : - Edit an authority type summary : for example subject (heading on 250) : summary "[250a][ -- 250x]" - Create an authority A1 with one heading and a subdivision : for example a subject : 250$a "History" 250$x "20th century" - Create an authority A2 with several headings. for example a subject : 250$a "History" 250$a "Legends" - Rebuild Zebra queue - Go to OPAC and click on "Authority search" and search on "History" => You will find A1 and A2 : History -- 20th century History | Legends - Go to intranet autorities search and search on "History" => You will find A1 and A2 : History -- 20th century History | Legends - Edit a record using this autorities type as thesaurus : for example on 606$a - Click on thesaurus link and search on "History" => You will find A1 and A2 : History -- 20th century ; 0 times ; choose ; Edit authority History | Legends ; 0 times ; 1 2 ; Edit authority - Click on link "2" to chosse "Legends" => You get "Legends" in heading field : for example 606$a Signed-off-by: Frédéric Demians <f.demians@tamil.fr> I can confirm the problem and the solution. I have tested the patch on a large DB with authorities having multiples headings. There is no regression on bug 4838. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. Without the patch I couldn't choose between multiple headings in the authority plugin, but with the patch it works as described. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7442 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7442 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19779|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7442 --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Note: I couldn't reproduce the crash! But without the patches I can't pick between the 2 different headings, so I think this patch is still valid and needed. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7442 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7442 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #28 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14.x, will be in 3.14.12 -- You are receiving this mail because: You are watching all bug changes.