[Bug 38118] New: Removed empty columns on holdings table on details page are not restored when new items loaded
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38118 Bug ID: 38118 Summary: Removed empty columns on holdings table on details page are not restored when new items loaded Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com The holdings table removes empty columns when loading the first page via API, however, it does not restore them when items are searched or paged To recreate: 1 - Find/Add a bib record with no items 2 - Add 20 items from Centerville Edit ->Edit items -> enter CENTER1 into barcode ->'Add multiple copies' -> 20 3 - Add 20 items from Fairview as above but enter 'FAIR1' for barcode and 'FAIR ITEM' as callnumber 4 - Add 1 item from Midway with barcode MIDWAY1 5 - Edit a midway patron to grant 'catalogue' and 'edit_items' permission - NOT edit_any_item 6 - Sign in as the patron above 7 - Find the record 8 - Note there is no callnumebr or actions/edit colum 9 - Go to page 2 of items - no callnumber visible though fairview items have them 10 - Go to page 3 - no edit column, though you should be able to edit -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38118 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33568 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 [Bug 33568] Use the REST API to display items on the staff biblio detail view -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38118 Carolyn Hughesman <chughesman@cclsny.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chughesman@cclsny.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38118 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38118 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 172526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172526&action=edit Bug 38118: Display columns if not empty in drawCallback Instead of updating only when DT init is complete we are going to update the visibility when the table will be redrawn. Test plan: 1 - Find/Add a bib record with no items 2 - Add 20 items from Centerville Edit ->Edit items -> enter CENTER1 into barcode ->'Add multiple copies' -> 20 3 - Add 20 items from Fairview as above but enter 'FAIR1' for barcode and 'FAIR ITEM' as callnumber 4 - Add 1 item from Midway with barcode MIDWAY1 5 - Edit a midway patron to grant 'catalogue' and 'edit_items' permission - NOT edit_any_item 6 - Sign in as the patron above 7 - Find the record 8 - Note there is callnumber and actions/edit columns 9 - Go to page 2 of items - callnumber visible 10 - Go to page 3 - edit column -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38118 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com Assignee|koha-bugs@lists.koha-commun |jonathan.druart@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38118 Esther Melander <esther.melander@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |esther.melander@bywatersolu | |tions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38118 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172526|0 |1 is obsolete| | --- Comment #2 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 172541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172541&action=edit Bug 38118: Display columns if not empty in drawCallback Instead of updating only when DT init is complete we are going to update the visibility when the table will be redrawn. Test plan: 1 - Find/Add a bib record with no items 2 - Add 20 items from Centerville Edit ->Edit items -> enter CENTER1 into barcode ->'Add multiple copies' -> 20 3 - Add 20 items from Fairview as above but enter 'FAIR1' for barcode and 'FAIR ITEM' as callnumber 4 - Add 1 item from Midway with barcode MIDWAY1 5 - Edit a midway patron to grant 'catalogue' and 'edit_items' permission - NOT edit_any_item 6 - Sign in as the patron above 7 - Find the record 8 - Note there is callnumber and actions/edit columns 9 - Go to page 2 of items - callnumber visible 10 - Go to page 3 - edit column Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38118 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Status|Needs Signoff |Signed Off --- Comment #3 from Victor Grousset/tuxayo <victor@tuxayo.net> --- It works! :) Assuming that's expected to have now the Checkouts, Renewals, Local uses now be visible also. -----
8 - Note there is callnumber and actions/edit columns
Not on page 1, I assume step 9 et 10 take precedence on this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38118 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38118 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172541|0 |1 is obsolete| | --- Comment #4 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 172583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172583&action=edit Bug 38118: Display columns if not empty in drawCallback Instead of updating only when DT init is complete we are going to update the visibility when the table will be redrawn. Test plan: 1 - Find/Add a bib record with no items 2 - Add 20 items from Centerville Edit ->Edit items -> enter CENTER1 into barcode ->'Add multiple copies' -> 20 3 - Add 20 items from Fairview as above but enter 'FAIR1' for barcode and 'FAIR ITEM' as callnumber 4 - Add 1 item from Midway with barcode MIDWAY1 5 - Edit a midway patron to grant 'catalogue' and 'edit_items' permission - NOT edit_any_item 6 - Sign in as the patron above 7 - Find the record 8 - Note there is callnumber and actions/edit columns 9 - Go to page 2 of items - callnumber visible 10 - Go to page 3 - edit column Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38118 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38118 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38118 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38118 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38240 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38240 [Bug 38240] Filtering resulting in no result will hide filters -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38118 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Needs rebased for 24.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38118 --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 174763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174763&action=edit [24.05] Bug 38118: Display columns if not empty in drawCallback Instead of updating only when DT init is complete we are going to update the visibility when the table will be redrawn. Test plan: 1 - Find/Add a bib record with no items 2 - Add 20 items from Centerville Edit ->Edit items -> enter CENTER1 into barcode ->'Add multiple copies' -> 20 3 - Add 20 items from Fairview as above but enter 'FAIR1' for barcode and 'FAIR ITEM' as callnumber 4 - Add 1 item from Midway with barcode MIDWAY1 5 - Edit a midway patron to grant 'catalogue' and 'edit_items' permission - NOT edit_any_item 6 - Sign in as the patron above 7 - Find the record 8 - Note there is callnumber and actions/edit columns 9 - Go to page 2 of items - callnumber visible 10 - Go to page 3 - edit column -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38118 --- Comment #8 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Lucas Gass (lukeg) from comment #6)
Needs rebased for 24.05.x
Done but haven't tested it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38118 --- Comment #9 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Jonathan Druart from comment #8)
(In reply to Lucas Gass (lukeg) from comment #6)
Needs rebased for 24.05.x
Done but haven't tested it.
And don't forget bug 38240. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38118 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38485 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38485 [Bug 38485] Update column visibility on holdings table correctly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38118 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|24.11.00 |24.11.00,24.05.06 released in| | --- Comment #10 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcomign 24.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38118 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38118 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 33568 not in 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38118 Bug 38118 depends on bug 33568, which changed state. Bug 33568 Summary: Use the REST API to display items on the staff biblio detail view https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org