https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25951 Nicolas Legrand <nicolas.legrand@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25951 Nicolas Legrand <nicolas.legrand@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Nicolas Legrand <nicolas.legrand@bulac.fr> --- mhmm... I should add some tests. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25951 Nicolas Legrand <nicolas.legrand@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106649|0 |1 is obsolete| | --- Comment #3 from Nicolas Legrand <nicolas.legrand@bulac.fr> --- Created attachment 107129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107129&action=edit Bug 25951: Koha::Objects using the DBIx::Class relationships in Koha::Hold and Koha::Item Those changes focus on intranet pages /reserve/request.pl, circ/waitingreserves.pl and opac page koha/opac-user.pl. Plan test: 1. run `prove t/db_dependent/Koha/Item/RelatedObjects.t ; prove t/db_dependent/Koha/Holds.pm`, all should be ok 2. apply patch 3. rerun `prove t/db_dependent/Koha/Item/RelatedObjects.t ; prove t/db_dependent/Koha/Holds.pm`, all should be ok 4. make a hold on a checkouted item and check it in. It should be in waiting reserves now. 5. go have a look to /reserve/request.pl, circ/waitingreserves.pl, koha/opac-user.pl (while logged as the user having the hold) pages. 6. it should be errorless, you should see the library names and the forms should prompt the correct branchcode. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25951 --- Comment #4 from Nicolas Legrand <nicolas.legrand@bulac.fr> --- Bad test plan, tests should be in a different patch... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25951 Nicolas Legrand <nicolas.legrand@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107129|0 |1 is obsolete| | --- Comment #6 from Nicolas Legrand <nicolas.legrand@bulac.fr> --- Created attachment 107131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107131&action=edit Bug 25951: Koha::Objects using the DBIx::Class relationships in Koha::Hold and Koha::Item Those changes focus on intranet pages /reserve/request.pl, circ/waitingreserves.pl and opac page koha/opac-user.pl. Test plan: 1. Apply the tests patch and do its test plan 2. apply this patch 3. rerun `prove t/db_dependent/Koha/Item/RelatedObjects.t ; prove t/db_dependent/Koha/Holds.pm`, all should be ok 4. make a hold on a checkouted item and check it in. It should be in waiting reserves now. 5. go have a look to /reserve/request.pl, circ/waitingreserves.pl, koha/opac-user.pl (while logged as the user having the hold) pages. 6. it should be errorless, you should see the library names and the forms should prompt the correct branchcode. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25951 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Assignee|koha-bugs@lists.koha-commun |nicolas.legrand@bulac.fr |ity.org | --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- 1. I would not create a separate test file RelatedObjects.t code can be moved to a subtest of Koha/Items.t 2. On your way, you could create a Koha::Hold->library and ->patron. ->branch and ->borrower will call ->library and ->patron branch and borrower could be marked as deprecated 3. In holds-table.inc, + Item in transit to <strong> [% HOLD.branch.branchname | html %]</strong> <input type="hidden" name="pickup" value="[% HOLD.branchcode | html %]" /> It's weird to access HOLD.branch.branchname and HOLD.branchcode (better HOLD.branch.branchcode to highlight it's the same object we access). I think it make more sense to have a "library" variable, [% SET library = HOLD.branch %] then reuse library for branchcode and branchname attributes. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25951 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Failing QA regarding last comment. -- You are receiving this mail because: You are watching all bug changes.