[Bug 34438] New: OPAC self registration form does not include lang ( Preferred language for notices ) field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34438 Bug ID: 34438 Summary: OPAC self registration form does not include lang ( Preferred language for notices ) field Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org To recreate: 1. Install a language pack ( sudo koha-translate -i es-ES ) 2. Turn on the system preference TranslateNotices 3. The lang field now appears when registering a patron from the staff interface but not on the OPAC self registration form. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34438 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34438 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 154001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154001&action=edit Bug 34438: Add lang field to OPAC patron self registration form -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34438 --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 154002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154002&action=edit Bug 34438: Add lang to borrower_modification table To test: 1. Install a language pack ( sudo koha-translate -i es-ES ) 2. Turn on the system preference TranslateNotices 3. The lang field now appears when registering a patron from the staff interface but not on the OPAC self registration form. 4. Apply patch, updatedatabase, restart_all 5. Go to the OPAC self reg form and notice the Preferred language for notices: 6. Use the PatronSelfRegistrationBorrowerUnwantedField and PatronSelfRegistrationBorrowerMandatoryField to make sure you can make the field requied/hidden. 7. Login to the OPAC and go to patron details, make sure you can modify the Preferred language for notices field successfully. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34438 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34438 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@biblibre.co | |m --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 28362 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34438 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34438 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34438 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34438 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154001|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 155775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155775&action=edit Bug 34438: Add lang field to OPAC patron self registration form Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34438 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154002|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 155776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155776&action=edit Bug 34438: Add lang to borrower_modification table To test: 1. Install a language pack ( sudo koha-translate -i es-ES ) 2. Turn on the system preference TranslateNotices 3. The lang field now appears when registering a patron from the staff interface but not on the OPAC self registration form. 4. Apply patch, updatedatabase, restart_all 5. Go to the OPAC self reg form and notice the Preferred language for notices: 6. Use the PatronSelfRegistrationBorrowerUnwantedField and PatronSelfRegistrationBorrowerMandatoryField to make sure you can make the field requied/hidden. 7. Login to the OPAC and go to patron details, make sure you can modify the Preferred language for notices field successfully. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34438 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #6 from David Nind <david@davidnind.com> --- Hi Lucas. I've signed off, but I did notice this with the OPAC for 7: - You can easily change the preferred language for notices under OPAC account > Messaging. - However, if you attempt to change it under OPAC account > Personal details, you get a message "Thank you. Your updates have been submitted. A librarian will review your updates before applying them." and it appears in the staff interface under Patrons requesting modifications. I'm not sure whether this is expected, or needs updating. David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34438 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Maybe it's not good to have it in 2 spots by default. Should we include an update to hide it for existing installations? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34438 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34438 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Lucas, * Rebase was easy, so I did it myself, but: * The Schema change should be a separate DO NOT PUSH style patch. * Change in kohastructure.sql is missing I like this - please fix! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34438 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #8)
Hi Lucas,
* Rebase was easy, so I did it myself, but: * The Schema change should be a separate DO NOT PUSH style patch. * Change in kohastructure.sql is missing
I like this - please fix!
... and please perltidy! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34438 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155775|0 |1 is obsolete| | Attachment #155776|0 |1 is obsolete| | --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 158152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158152&action=edit Bug 34438: Schema changes [DO NOT PUSH] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34438 --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 158153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158153&action=edit Bug 34438: Database update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34438 --- Comment #12 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 158154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158154&action=edit Bug 34438: Add lang field to OPAC patron self registration form Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34438 --- Comment #13 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 158155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158155&action=edit Bug 34438: ( follow-up ): Amend kohastructure.sql -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34438 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #14 from Lucas Gass <lucas@bywatersolutions.com> --- Fixed and back to NSO. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34438 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34438 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158152|0 |1 is obsolete| | --- Comment #15 from David Nind <david@davidnind.com> --- Created attachment 158156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158156&action=edit Bug 34438: Schema changes [DO NOT PUSH] Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34438 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158153|0 |1 is obsolete| | --- Comment #16 from David Nind <david@davidnind.com> --- Created attachment 158157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158157&action=edit Bug 34438: Database update Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34438 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158154|0 |1 is obsolete| | --- Comment #17 from David Nind <david@davidnind.com> --- Created attachment 158158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158158&action=edit Bug 34438: Add lang field to OPAC patron self registration form Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34438 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158155|0 |1 is obsolete| | --- Comment #18 from David Nind <david@davidnind.com> --- Created attachment 158159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158159&action=edit Bug 34438: ( follow-up ): Amend kohastructure.sql Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34438 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|OPAC self registration form |OPAC self registration form |does not include lang ( |does not include lang |Preferred language for |(preferred language for |notices ) field |notices) field -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34438 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Please fix: WARN Koha/Schema/Result/BorrowerModification.pm WARN tidiness The file is less tidy than before (bad/messy lines before: 176, now: 178) WARN installer/data/mysql/atomicupdate/bug_34438.pl WARN tidiness The file is less tidy than before (bad/messy lines before: 0, now: 2) OK installer/data/mysql/kohastructure.sql OK koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt FAIL opac/opac-memberentry.pl FAIL valid "my" variable $defaultCategory masks earlier declaration in same scope Processing additional checks * Commit title does not contain 'follow-up' correctly spelt - 61e1edc84b -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34438 --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I believe this line should have been deleted in the rebase: +my $defaultCategory = Koha::Patron::Categories->find(C4::Context->preference('PatronSelfRegistrationDefaultCategory')); -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34438 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|katrin.fischer@bsz-bw.de |testopia@bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34438 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158156|0 |1 is obsolete| | --- Comment #21 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 158181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158181&action=edit Bug 34438: Schema changes [DO NOT PUSH] Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34438 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158157|0 |1 is obsolete| | --- Comment #22 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 158182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158182&action=edit Bug 34438: Database update Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34438 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158158|0 |1 is obsolete| | --- Comment #23 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 158183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158183&action=edit Bug 34438: Add lang field to OPAC patron self registration form Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34438 --- Comment #24 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 158184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158184&action=edit Bug 34438: (follow-up): Amend kohastructure.sql Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34438 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158159|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34438 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34438 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34438 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158181|0 |1 is obsolete| | --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158196&action=edit Bug 34438: Schema changes [DO NOT PUSH] Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34438 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158182|0 |1 is obsolete| | --- Comment #26 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158197&action=edit Bug 34438: Database update Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34438 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158183|0 |1 is obsolete| | --- Comment #27 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158198&action=edit Bug 34438: Add lang field to OPAC patron self registration form Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34438 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158184|0 |1 is obsolete| | --- Comment #28 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158199&action=edit Bug 34438: (follow-up): Amend kohastructure.sql Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34438 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34438 --- Comment #29 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34438 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Needs documenting --- Comment #30 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 23.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34438 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This adds the 'preferred release notes| |language' to the patron | |self registration form when | |`TranslateNotices` is | |activated. The field can be | |hidden using the | |`PatronSelfRegistrationBorr | |owerUnwantedField` and | |`PatronSelfRegistrationBorr | |owerMandatoryField` system | |preferences if not needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34438 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/836 CC| |caroline.cyr-la-rose@inlibr | |o.com Status|Needs documenting |RESOLVED Resolution|--- |FIXED Documentation| |Caroline Cyr La Rose contact| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34438 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41942 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41942 [Bug 41942] Hiding primary contact method hides lang with PatronSelfModificationBorrowerUnwantedField -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org