[Bug 37490] New: add test to detect when yarn.lock is not updated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37490 Bug ID: 37490 Summary: add test to detect when yarn.lock is not updated Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: mtj@kohaaloha.com QA Contact: testopia@bugs.koha-community.org details to come... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37490 --- Comment #1 from Mason James <mtj@kohaaloha.com> --- Created attachment 169693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169693&action=edit Bug 37490: add a test to detect when yarn.lock is not updated to test... 1/ set koha repo to state where yarn.lock is not updated $ git reset --hard 67db70d4 2/ run test, observe FAIL $ prove ./xt/verify-yarnlock.t ./xt/verify-yarnlock.t .. error Your lockfile needs to be updated, but yarn was run with `--frozen-lockfile`. ./xt/verify-yarnlock.t .. 1/1 # Failed test 'verify yarn.lock file is updated correctly' ... Result: FAIL 3/ set koha repo to state where yarn.lock is updated $ yarn install 4/ note yarn.lock is now updated $ git status ... modified: yarn.lock 5/ run test, observe SUCCESS $ prove -v ./xt/verify-yarnlock.t ./xt/verify-yarnlock.t .. ok 1 - verify yarn.lock file is updated correctly All tests successful. Files=1, Tests=1, 1 wallclock secs ( 0.02 usr 0.01 sys + 1.16 cusr 0.27 csys = 1.46 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37490 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37490 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Templates |Test Suite Assignee|oleonard@myacpl.org |chris@bigballofwax.co.nz See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=37302 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37490 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris@bigballofwax.co.nz |mtj@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37490 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37490 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169693|0 |1 is obsolete| | --- Comment #2 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 169698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169698&action=edit Bug 37490: add a test to detect when yarn.lock is not updated to test... 1/ set koha repo to state where yarn.lock is not updated $ git reset --hard 67db70d4 2/ run test, observe FAIL $ prove ./xt/verify-yarnlock.t ./xt/verify-yarnlock.t .. error Your lockfile needs to be updated, but yarn was run with `--frozen-lockfile`. ./xt/verify-yarnlock.t .. 1/1 # Failed test 'verify yarn.lock file is updated correctly' ... Result: FAIL 3/ set koha repo to state where yarn.lock is updated $ yarn install 4/ note yarn.lock is now updated $ git status ... modified: yarn.lock 5/ run test, observe SUCCESS $ prove -v ./xt/verify-yarnlock.t ./xt/verify-yarnlock.t .. ok 1 - verify yarn.lock file is updated correctly All tests successful. Files=1, Tests=1, 1 wallclock secs ( 0.02 usr 0.01 sys + 1.16 cusr 0.27 csys = 1.46 CPU) Result: PASS Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37490 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|add test to detect when |Add test to detect when |yarn.lock is not updated |yarn.lock is not updated -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37490 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169698|0 |1 is obsolete| | --- Comment #3 from Mason James <mtj@kohaaloha.com> --- Created attachment 169967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169967&action=edit Bug 37490: Add a test to detect when yarn.lock is not updated to test... 1/ set koha repo to state where yarn.lock is not updated $ git reset --hard 67db70d4 2/ run test, observe FAIL $ prove ./xt/verify-yarnlock.t ./xt/verify-yarnlock.t .. error Your lockfile needs to be updated, but yarn was run with `--frozen-lockfile`. ./xt/verify-yarnlock.t .. 1/1 # Failed test 'verify yarn.lock file is updated correctly' ... Result: FAIL 3/ set koha repo to state where yarn.lock is updated $ yarn install 4/ note yarn.lock is now updated $ git status ... modified: yarn.lock 5/ run test, observe SUCCESS $ prove -v ./xt/verify-yarnlock.t ./xt/verify-yarnlock.t .. ok 1 - verify yarn.lock file is updated correctly All tests successful. Files=1, Tests=1, 1 wallclock secs ( 0.02 usr 0.01 sys + 1.16 cusr 0.27 csys = 1.46 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37490 --- Comment #4 from Mason James <mtj@kohaaloha.com> --- NOTE: i improved the test to handle running inside KTD, and using KTD's existing .cache/yarn and node_modules dirs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37490 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=37303 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37490 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37490 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169967|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 170540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170540&action=edit Bug 37490: Add a test to detect when yarn.lock is not updated to test... 1/ set koha repo to state where yarn.lock is not updated $ git reset --hard 67db70d4 2/ run test, observe FAIL $ prove ./xt/verify-yarnlock.t ./xt/verify-yarnlock.t .. error Your lockfile needs to be updated, but yarn was run with `--frozen-lockfile`. ./xt/verify-yarnlock.t .. 1/1 # Failed test 'verify yarn.lock file is updated correctly' ... Result: FAIL 3/ set koha repo to state where yarn.lock is updated $ yarn install 4/ note yarn.lock is now updated $ git status ... modified: yarn.lock 5/ run test, observe SUCCESS $ prove -v ./xt/verify-yarnlock.t ./xt/verify-yarnlock.t .. ok 1 - verify yarn.lock file is updated correctly All tests successful. Files=1, Tests=1, 1 wallclock secs ( 0.02 usr 0.01 sys + 1.16 cusr 0.27 csys = 1.46 CPU) Result: PASS Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37490 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Never a bad idea to have more tests and catch these cases. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37490 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Ok, this test is failing for me on main... HELP? # Failed test 'verify yarn.lock file is updated correctly' # at /kohadevbox/koha/xt/verify-yarnlock.t line 45. # got: '256' # expected: '0' # Looks like you failed 1 test of 1. /kohadevbox/koha/xt/verify-yarnlock.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/1 subtests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37490 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Also: could someone explain when yarn.lock needs updating and how this is done? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37490 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #8)
Also: could someone explain when yarn.lock needs updating and how this is done?
I retried it and it passes now! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37490 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37490 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37490 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com Version(s)|24.11.00 | released in| | --- Comment #11 from Jonathan Druart <jonathan.druart@gmail.com> --- I am wondering if this is working correctly. kohadev-koha@kohadevbox:koha$ prove xt/verify-yarnlock.t [skip lot of warnings] error "eslint-plugin-prettier##prettier@>=3.0.0" doesn't satisfy found match of "prettier@2.7.1" [skip lot of warnings] error Found 1 errors. xt/verify-yarnlock.t .. 1/1 # Failed test 'verify yarn.lock file is updated correctly' # at xt/verify-yarnlock.t line 45. # got: '256' # expected: '0' # Looks like you failed 1 test of 1. xt/verify-yarnlock.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/1 subtests Test Summary Report ------------------- xt/verify-yarnlock.t (Wstat: 256 (exited 1) Tests: 1 Failed: 1) Failed test: 1 Non-zero exit status: 1 Files=1, Tests=1, 31 wallclock secs ( 0.07 usr 0.08 sys + 26.96 cusr 23.01 csys = 50.12 CPU) Result: FAIL I was wondering what could happen and first I've removed my local node_modules (/kohadevbox/koha/node_modules) Then the tests passed! You can recreate easily, go on the host and run `yarn install` to generate the node_modes dir, then run the tests. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37490 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Version(s)| |24.11.00,24.05.06 released in| | Status|Pushed to main |Pushed to stable --- Comment #12 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37490 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|24.11.00,24.05.06 |24.11.00,24.05.06,23.11.11 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #13 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37490 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #14 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 unless requested -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37490 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED CC| |david@davidnind.com --- Comment #15 from David Nind <david@davidnind.com> --- No changes required to the manual. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org