[Bug 9253] New: If an item is reserved, at the opac it is marked as available
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9253 Bug ID: 9253 Summary: If an item is reserved, at the opac it is marked as available Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: jonathan.druart@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9253 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|oleonard@myacpl.org |jonathan.druart@biblibre.co | |m Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9253 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 13978 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13978&action=edit Bug 9253: Mark items "On hold" at the opac If an item is reserved, at the opac it is marked as available. Test plan: - Reserve an item for a patron - See the intranet display page for the reserved notice. The item is marked as "on hold" - See the opac display page for the reserved notice. The item is marked as "available" - apply the patch - See the opac diplay page for the reserved notice. The item is marked as "on hold" -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9253 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9253 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9253 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13978|0 |1 is obsolete| | --- Comment #2 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 14105 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14105&action=edit Bug 9253: Mark items "On hold" at the opac If an item is reserved, at the opac it is marked as available. Test plan: - Reserve an item for a patron - See the intranet display page for the reserved notice. The item is marked as "on hold" - See the opac display page for the reserved notice. The item is marked as "available" - apply the patch - See the opac diplay page for the reserved notice. The item is marked as "on hold" Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Patch has described effect on OPAC. Opposed to the test plan I have 'available' in intranet though. Not in the scope of this patch so signed off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9253 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |mirko@abunchofthings.net -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9253 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am a bit worried about the consequences of this. I think this can only work for item level holds. Also, when does the status change? When the item is placed on hold or when the item is checked in and waiting for the patron? I feel like it should be the latter. I think libraries allow patrons to check out the item as long as it has not been pulled from the shelf, but not quite sure here. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9253
Paul Poulain <paul.poulain@biblibre.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |paul.poulain@biblibre.com
--- Comment #4 from Paul Poulain <paul.poulain@biblibre.com> ---
(In reply to comment #3)
> I am a bit worried about the consequences of this. I think this can only
> work for item level holds.
You're right and wrong. This work only when the *item* is on hold. So either :
- a "1st available" has been placed, and an item has been checked in (to the
reserve is now attached to an item)
- a item level hold has been placed
> Also, when does the status change?
The onhold flag is set by
if( $reserve_status eq "Reserved"){ $itm->{'onhold'} = 1; }
$reserve_status is defined by
my ($reserve_status) = C4::Reserves::CheckReserves($itm->{itemnumber});
However, one thing that worry me is that the rules for opac-detail.pl display
are not the same as the rules for staff detail.pl display:
In staff display, it seems that the items.reservedate is used to have a display
of hold-er & hold status. Jonathan, am I right ? Why use a different method in
the staff interface ?
> When the item is placed on hold or when the item is checked in and waiting
> for the patron? I feel like it should be the latter.
> I think libraries allow patrons to check out the item as long as it has not
> been pulled from the shelf, but not quite sure here.
I think we must :
* be consistent between staff & opac
* can display that an item is reserved as soon as possible. use case = 9AM,
patron A places a hold, 10AM, patron B check OPAC and see the document is
"available", 11AM, the item become "waiting" for patron A, 11:10AM, patron B
arrives at the library and becomes angry because the item is no more
available... We can't warn an item is reserved when the hold is "1st
available", but as soon as we've an item, we should.
--
You are receiving this mail because:
You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9253 --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #4)
Jonathan, am I right ? Why use a different method in the staff interface ?
I don't know. The only thing I know is that the opac template does not take into account the on hold status. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9253 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact| |m.de.rooy@rijksmuseum.nl --- Comment #6 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- QA: Looking at this one now.. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9253 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #7 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- QA Comment: I am sorry, but IMO this should not be pushed in this state. There already is a small discrepancy between opac and staff in this area. If we change things at one side now, let us resolve these issues and not make it bigger. IMO this is in scope. A next available hold is shown as Available in opac and staff until it is confirmed. I think that is fine. Does not need a change as proposed here; there may be a hold already for a far future! It is available until we check it in. After confirming, it is On Hold or Waiting.. in staff. Fine too. An item level hold is now Available in opac and marked as item-level hold in staff while pending. Small discrepancy. Note that this item level hold can also be still far away! Although I can understand your wish to put it on hold in display, I still think that it is actually available until we check it in. After confirming, there is no change anymore with the next available hold. So, if we want to change this status, the least thing we can do is first look at the reserve date before saying that it is not available. Setting to Failed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9253 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think Marcel managed to describe the problem quite well. I still feel like for the OPAC user a hold does not exist, until he can't check out the book or the book has been pulled and is no longer on the shelf. For staff it might make sense to give a bit more information. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9253 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart@biblibre.co |oleonard@myacpl.org |m | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9253 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |mirko@abunchofthings.net -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9253 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|mirko@abunchofthings.net |oleonard@myacpl.org --- Comment #9 from Mirko Tietgen <mirko@abunchofthings.net> --- Not sure why this bug was assigned to me, I am not working on this so I reset it to default -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9253 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9253 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=3333 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9253 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7012 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9253 jdemuth@roseville.ca.us <jdemuth@roseville.ca.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdemuth@roseville.ca.us -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9253 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart@bugs.koha-c |oleonard@myacpl.org |ommunity.org | Status|Failed QA |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org