[Bug 8547] New: Enabling star ratings causes javascript errors that cause IE to have a boo boo
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8547 Priority: P5 - low Change sponsored?: --- Bug ID: 8547 Assignee: oleonard@myacpl.org Summary: Enabling star ratings causes javascript errors that cause IE to have a boo boo Severity: enhancement Classification: Unclassified OS: All Reporter: robin@catalyst.net.nz Hardware: All Status: NEW Version: rel_3_8 Component: OPAC Product: Koha I think this is due to a trailing comma in a list. Real browser are OK with it, but IE is dumb. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8547 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P2 Status|NEW |ASSIGNED Change sponsored?|--- |Sponsored Assignee|oleonard@myacpl.org |robin@catalyst.net.nz Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8547 --- Comment #1 from Robin Sheat <robin@catalyst.net.nz> --- Seeing this issue seems to be a bit hit and miss, I haven't worked out the combination of parameters that causes it, just that sometimes it'll happen and sometimes it won't (even with the same browser.) I suspect it's to do with the order that certain ajax loads take place relative to JS rendering. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8547 --- Comment #2 from Robin Sheat <robin@catalyst.net.nz> --- Created attachment 11251 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11251&action=edit Bug 8547 - JS error in star ratings breaks IE Writing code with best practices in mind breaks IE. Thanks Internet Explorer. Now go DiaF. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8547 --- Comment #3 from Robin Sheat <robin@catalyst.net.nz> --- This patch is based on a hunch of what the issue is and is still waiting for someone who has IE to test it for me, but if anyone else is interested, here's what it looks like when it's going bad: http://i.imgur.com/Jhc3z.jpg -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8547 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|OPAC |Browser compatibility --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- For what it's worth, I don't see this problem in IE9 on Windows 7. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8547 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I was testing IE 8 on Windows 7 and saw it sometimes. Most of the time it happened after closing the browser completely and going to the detail page directly following a link from my bookmarks. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8547 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #6 from Robin Sheat <robin@catalyst.net.nz> --- Confirmed from client that this solves the issue. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8547 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #7 from Marc Véron <veron@veron.ch> --- Bug confirmeed with IE 7.0.5730.13 on Windows XP -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8547 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11251|0 |1 is obsolete| | --- Comment #8 from Marc Véron <veron@veron.ch> --- Created attachment 11361 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11361&action=edit [SIGNED-OFF] Bug 8547 - JS error in star ratings breaks IE Writing code with best practices in mind breaks IE. Thanks Internet Explorer. Now go DiaF. Signed-off-by: Marc Veron <veron@veron.ch> Tested with with IE 7.0.5730.13 on Windows XP, no JS errors, stars display and behave as expected -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8547 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8547 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA Comments: This patch fixes a "Trailing comma of death" (see http://www.enterprisedojo.com/2010/12/19/beware-the-trailing-comma-of-death/) for IE Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8547 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #10 from Chris Cormack <chris@bigballofwax.co.nz> --- Have picked this into 3.8.x, will be in 3.8.4, safe change, fixes broken IE. (Well fixes one small symptom of its huge pile of brokenness anyway) Leaving as Passed QA, so Paul can push to master when he gets back. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8547 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8547 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com --- Comment #11 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed today (checked it does not break FF) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8547 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org