[Bug 16203] New: item plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16203 Bug ID: 16203 Summary: item plugins Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt@gmail.com Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16203 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 49913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49913&action=edit Bug 16203: item plugins (W-I-P) -rwxr-xr-x 1 master-koha master-koha 3082 Nov 19 10:04 barcode_manual.pl -rwxr-xr-x 1 master-koha master-koha 3896 Nov 19 10:04 barcode.pl -rwxr-xr-x 1 master-koha master-koha 4292 Nov 19 10:04 callnumber-KU.pl -rwxr-xr-x 1 master-koha master-koha 3406 Nov 19 10:04 callnumber.pl -rwxr-xr-x 1 master-koha master-koha 4424 Nov 19 10:04 cn_browser.pl -rwxr-xr-x 1 master-koha master-koha 2058 Nov 19 10:04 dateaccessioned.pl -rwxr-xr-x 1 master-koha master-koha 6777 Jan 4 10:34 macles.pl -rwxr-xr-x 1 master-koha master-koha 3409 Nov 19 10:04 stocknumberam123.pl -rwxr-xr-x 1 master-koha master-koha 3525 Nov 19 10:04 stocknumberAV.pl -rwxr-xr-x 1 master-koha master-koha 1646 Nov 19 10:04 stocknumber.pl Added license statement to cn_browser.pl. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16203 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|item plugins |Convert item plugins to new | |style (see bug 10480) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16203 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16203 --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 50066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50066&action=edit Bug 16203: Convert item plugins to new style (see bug 10480) Converts item plugins to new style (with builder and launcher). See also bugs 10480 and 13437. The following plugins have been adjusted: barcode_manual.pl barcode.pl callnumber-KU.pl callnumber.pl cn_browser.pl (Added license statement too) dateaccessioned.pl macles.pl stocknumberam123.pl stocknumberAV.pl stocknumber.pl Test plan: Connect the plugin to an item field. Verify that the plugin still works. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Tested if all plugins compile okay. Ran most of them thru FrameworkPlugin.t. Tested them in the item editor. Note: the form for macles.pl comes up, further hard to test. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16203 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |m.de.rooy@rijksmuseum.nl Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16203 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49913|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16203 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |josef.moravec@gmail.com --- Comment #3 from Josef Moravec <josef.moravec@gmail.com> --- Looks good, all plugins are working but QA tool says: FAIL cataloguing/value_builder/barcode.pl FAIL valid "my" variable $DEBUG masks earlier declaration in same scope FAIL cataloguing/value_builder/barcode_manual.pl FAIL valid "my" variable $DEBUG masks earlier declaration in same scope -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16203 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Thanks, Josef, for testing. You can safely ignore these warnings. They are not coming from the changes in this patch set, but from a (unmodified) module used by these plugins. This is the source: $ perl -cw C4/Barcodes/ValueBuilder.pm "my" variable $DEBUG masks earlier declaration in same scope at C4/Barcodes/ValueBuilder.pm line 43. "my" variable $DEBUG masks earlier declaration in same scope at C4/Barcodes/ValueBuilder.pm line 85. C4/Barcodes/ValueBuilder.pm syntax OK If you look at that module, you will see that it actually contains multiple packages and each one having a $DEBUG variable. A construction like that is not recommended and fortunately an exception in Koha, but it should work. The warning is actually dubious. All ready for a signoff ? :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16203 --- Comment #5 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Marcel de Rooy from comment #4)
All ready for a signoff ? :)
I think so ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16203 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16203 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50066|0 |1 is obsolete| | --- Comment #6 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 57956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57956&action=edit [SIGNED-OFF] Bug 16203: Convert item plugins to new style (see bug 10480) Converts item plugins to new style (with builder and launcher). See also bugs 10480 and 13437. The following plugins have been adjusted: barcode_manual.pl barcode.pl callnumber-KU.pl callnumber.pl cn_browser.pl (Added license statement too) dateaccessioned.pl macles.pl stocknumberam123.pl stocknumberAV.pl stocknumber.pl Test plan: Connect the plugin to an item field. Verify that the plugin still works. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Tested if all plugins compile okay. Ran most of them thru FrameworkPlugin.t. Tested them in the item editor. Note: the form for macles.pl comes up, further hard to test. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16203 --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Josef Moravec from comment #6)
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Great! Thx. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16203 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- FAIL cataloguing/value_builder/barcode.pl FAIL valid "my" variable $DEBUG masks earlier declaration in same scope FAIL cataloguing/value_builder/barcode_manual.pl FAIL valid "my" variable $DEBUG masks earlier declaration in same scope -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16203 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #8)
FAIL cataloguing/value_builder/barcode.pl FAIL valid "my" variable $DEBUG masks earlier declaration in same scope
FAIL cataloguing/value_builder/barcode_manual.pl FAIL valid "my" variable $DEBUG masks earlier declaration in same scope
Please read comment4. Back to SO -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16203 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16203 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57956|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 58185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58185&action=edit Bug 16203: Convert item plugins to new style (see bug 10480) Converts item plugins to new style (with builder and launcher). See also bugs 10480 and 13437. The following plugins have been adjusted: barcode_manual.pl barcode.pl callnumber-KU.pl callnumber.pl cn_browser.pl (Added license statement too) dateaccessioned.pl macles.pl stocknumberam123.pl stocknumberAV.pl stocknumber.pl Test plan: Connect the plugin to an item field. Verify that the plugin still works. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Tested if all plugins compile okay. Ran most of them thru FrameworkPlugin.t. Tested them in the item editor. Note: the form for macles.pl comes up, further hard to test. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16203 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #9)
(In reply to Jonathan Druart from comment #8)
FAIL cataloguing/value_builder/barcode.pl FAIL valid "my" variable $DEBUG masks earlier declaration in same scope
FAIL cataloguing/value_builder/barcode_manual.pl FAIL valid "my" variable $DEBUG masks earlier declaration in same scope
Please read comment4. Back to SO
Sorry about that. Yes it's because we now "use" intead of "require". These DEBUG variables are completely useless and could be removed, but it's outside the scope of this bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16203 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Marcel! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16203 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |katrin.fischer@bsz-bw.de Resolution|--- |FIXED --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This won't get backported to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16203 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19595 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19595 [Bug 19595] Clicking plugin link does not fill item's date acquired field -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org