[Bug 41147] New: Counts in bulkmarcimport.pl are incorrect
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41147 Bug ID: 41147 Summary: Counts in bulkmarcimport.pl are incorrect Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: robin@catalyst.net.nz We are incrementing the record_number counter twice for every record -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41147 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41147 --- Comment #1 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 188705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188705&action=edit Bug 41147: Don't double count records This patch prevents double counting records as we process them To test: 1 - Export a single record from Koha in marcxml format 2 - perl misc/migration_tools/bulkmarcimport.pl -b -v -m MARCXML --file record.marcxml 3 - Note it says "3 MARC records processed" 4 - Apply patch 5 - Repeat 6 - 1 record processed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41147 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41147 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |roman.dolny@jezuici.pl --- Comment #2 from Roman Dolny <roman.dolny@jezuici.pl> --- Can confirm, that count of records processed after applying a patch is not doubled. But there is still +1 in count... I tried with 1/2/4 records in file and get "2/3/5 MARC records done". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41147 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=41681 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41147 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bibliothek@th-wildau.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41147 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41147 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188705|0 |1 is obsolete| | --- Comment #3 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 194694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194694&action=edit Bug 41147: Don't double count records This patch prevents double counting records as we process them To test: 1 - Export a single record from Koha in marcxml format 2 - perl misc/migration_tools/bulkmarcimport.pl -b -v -m MARCXML --file record.marcxml 3 - Note it says "3 MARC records processed" 4 - Apply patch 5 - Repeat 6 - 1 record processed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41147 --- Comment #4 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 194695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194695&action=edit Bug 41147: (follow-up) Fix wrong record count Record_number gets increased every cycle before batch->next is called even when batch->next returns undef. This fix decreases record_number by 1 to ignore that last cycle in order to display the right number of records processed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41147 --- Comment #5 from Roman Dolny <roman.dolny@jezuici.pl> --- Isn't it duplicate for Bug 41681? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41147 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |DUPLICATE --- Comment #6 from Jan Kissig <bibliothek@th-wildau.de> --- (In reply to Roman Dolny from comment #5)
Isn't it duplicate for Bug 41681?
you are completely right. I also found my follow up not working properly. *** This bug has been marked as a duplicate of bug 41681 *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org