[Bug 14240] New: Add '(All libraries)' to notice deletion confirmation page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14240 Bug ID: 14240 Summary: Add '(All libraries)' to notice deletion confirmation page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: indradg@gmail.com Reporter: indradg@gmail.com QA Contact: testopia@bugs.koha-community.org Notices that are applicable to all libraries do not show '(All libraries)' in the deletion confirmation form (tools/letter.pl?op=delete_confirm). The proposed patch adds that. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14240 --- Comment #1 from Indranil Das Gupta <indradg@gmail.com> --- Created attachment 39355 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39355&action=edit Bug 14240 - Add '(All libraries)' to notice deletion form Trivial patch that shows (All libraries) instead of an empty cell for notices that are applicable across all libraries. Test plan ========= 1/ Apply the patch 2/ Attempt to delete a notice that is defined for all libraries You should be able to see '(All libraries)' in the table cell instead of a blank cell -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14240 Indranil Das Gupta <indradg@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14240 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14240 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39355|0 |1 is obsolete| | --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 39931 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39931&action=edit Bug 14240 - Add '(All libraries)' to notice deletion form Trivial patch that shows (All libraries) instead of an empty cell for notices that are applicable across all libraries. Test plan ========= 1) Log in to staff client 2) Tools->Notices & slips 3) Add a dummy notice for all libraries -- test code, test description, email - test subject, test content Click Submit 4) Click Delete -- note that the Library column value is blank. 5) Click the no option 6) Apply this patch 7) Click Delete -- note that the Library column value is (All Libraries). 8) run koha qa test tools. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14240 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14240 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39931|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 39960 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39960&action=edit [PASSED QA] Bug 14240 - Add '(All libraries)' to notice deletion form Trivial patch that shows (All libraries) instead of an empty cell for notices that are applicable across all libraries. Test plan ========= 1) Log in to staff client 2) Tools->Notices & slips 3) Add a dummy notice for all libraries -- test code, test description, email - test subject, test content Click Submit 4) Click Delete -- note that the Library column value is blank. 5) Click the no option 6) Apply this patch 7) Click Delete -- note that the Library column value is (All Libraries). 8) run koha qa test tools. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14240 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Indranil! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14240 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org