[Bug 18670] New: RewriteLog and RewriteLogLevel unavailable in Apache 2.4
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18670 Bug ID: 18670 Summary: RewriteLog and RewriteLogLevel unavailable in Apache 2.4 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org We have a few commented out RewriteLog and RewriteLogLevel directives in various Apache configuration files and templates. These directives aren't used in Apache 2.4. They've been replaced with the LogLevel directive. Since they're commented out, I don't think it matters too much for production systems, but it could lead to confusion if people tried uncommenting them and they don't work (yep that was me). We could wrap the two different styles in IfVersion directives to make things easier for people. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18670 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The lines still appear: debian/templates/apache-site-https.conf.in:# RewriteLog /var/log/koha/__KOHASITE__/opac-rewrite.log debian/templates/apache-site-https.conf.in:# RewriteLog /var/log/koha/__KOHASITE__/intranet-rewrite.log debian/templates/apache-site.conf.in:# RewriteLog /var/log/koha/__KOHASITE__/opac-rewrite.log debian/templates/apache-site.conf.in:# RewriteLog /var/log/koha/__KOHASITE__/intranet-rewrite.log etc/koha-httpd.conf: #RewriteLog __LOG_DIR__/koha-opac-rewrite.log etc/koha-httpd.conf: #RewriteLogLevel 1 etc/koha-httpd.conf: #RewriteLog __LOG_DIR__/koha-intranet-rewrite.log etc/koha-httpd.conf: #RewriteLogLevel 1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18670 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|gmcharlt@gmail.com |katrin.fischer@bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I'll attach a patch removing the commented lines to get this moving, but others might be able to tell better than me if this is a good idea or not :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18670 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18670 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 103212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103212&action=edit Bug 18670: Remove RewriteLog and RewriteLogLevel from sample config files It looks like RewriteLog will no longer work with Apache 2.4 and later. RewriteLog Those familiar with earlier versions of mod_rewrite will no doubt be looking for the RewriteLog and RewriteLogLevel directives. This functionality has been completely replaced by the new per-module logging configuration mentioned above. http://httpd.apache.org/docs/current/mod/mod_rewrite.html All lines removed were commented out, so there should be no change in behaviour or side effects. To test. - Verify every mention of RewriteLog has been removed from Koha - Verify patch by reading it -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18670 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18670 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103212|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 103224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103224&action=edit Bug 18670: Remove RewriteLog and RewriteLogLevel from sample config files It looks like RewriteLog will no longer work with Apache 2.4 and later. RewriteLog Those familiar with earlier versions of mod_rewrite will no doubt be looking for the RewriteLog and RewriteLogLevel directives. This functionality has been completely replaced by the new per-module logging configuration mentioned above. http://httpd.apache.org/docs/current/mod/mod_rewrite.html All lines removed were commented out, so there should be no change in behaviour or side effects. To test. - Verify every mention of RewriteLog has been removed from Koha - Verify patch by reading it Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18670 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18670 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103224|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 104279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104279&action=edit Bug 18670: Remove RewriteLog and RewriteLogLevel from sample config files It looks like RewriteLog will no longer work with Apache 2.4 and later. RewriteLog Those familiar with earlier versions of mod_rewrite will no doubt be looking for the RewriteLog and RewriteLogLevel directives. This functionality has been completely replaced by the new per-module logging configuration mentioned above. http://httpd.apache.org/docs/current/mod/mod_rewrite.html All lines removed were commented out, so there should be no change in behaviour or side effects. To test. - Verify every mention of RewriteLog has been removed from Koha - Verify patch by reading it Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18670 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18670 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18670 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.06 released in| | CC| |joy@bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #7 from Joy Nelson <joy@bywatersolutions.com> --- Backported to 19.11.x for 19.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18670 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00, 19.11.06 |20.05.00, 19.11.06, released in| |19.05.11 Status|Pushed to stable |Pushed to oldstable CC| |lucas@bywatersolutions.com --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 19.05.x for 19.05.11 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org