https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #483 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Martin Renvoize from comment #480)

Fair enough, if you feel we should move the check back to the two controllers I'm OK with that.. I've DRY'd the code in other regards now so that bit of refactoring can get undone. You're incorrect in saying that the search query would have ever been executed twice though.. we do not use the 'Details' templates for the display of the component parts when inlined, so the block with the query within it would not have been executed.

Never say never: [2021/10/26 07:31:06] [WARN] components: C4::XSLT at /usr/share/koha/Koha/Biblio.pm line 503. [2021/10/26 07:31:06] [WARN] components: CGI::Compile::ROOT::usr_share_koha_opac_opac_2ddetail_2epl at /usr/share/koha/Koha/Biblio.pm line 503. Without the last follow-up. One view of opac-detail. First warn comes from XSLT as expected. Second call from opac-detail line 664 (really, as expected too). Just read the code. Ha, who really DRYed here? :)

Regarding having the 'Show analytics' link regardless of the preference.. that's fine too; Though personally, I feel it perhaps confuses the end-user with two links to display the same information.. one without a re-fetch and one with.

No time left for a debate here ;) If this would really be so confusing, we can remove it later or just css it away. Dont think so.

I feel this bug has gone on long enough and any further refinements should be in their own bugs.. it worries me that so much is still going on at the end of the development cycle of the bug personally.

Don't you also need to remove some XSLT tests if you're moving the code back out into the Controllers?

Was already done. -- You are receiving this mail because: You are watching all bug changes.