https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35134 Sarah Cornell <sbcornell@cityofportsmouth.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sbcornell@cityofportsmouth. | |com --- Comment #1 from Sarah Cornell <sbcornell@cityofportsmouth.com> --- *raises hand* That's us. The call number browser popup needs to require fewer, if any, user interactions to show the searched-for call number in the range. It currently returns 30 results with the search term in the center, at row 16. The results are always longer than the current popup size. As a result, every lookup requires scrolling down to see the results. Rather than pick a larger size that hopes to serve most monitor sizes, it would be better to make the popup size configurable or responsive to the monitor size. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35134 --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 159169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159169&action=edit Bug 35134: Make cn_browser popup responsive to screen size To test: 1. Use the cn_browser.pl plugin for the 952$o ( call number ) 2. Add or edit an item and select the `...` to the right of the call number field. 3. The pop-up is hardcoded as 500px x 400px pop-up. 4. APPLY PATCH 5. Clear browser cache and try again. The window width should now be half of the current screen size. The window height should be 100% of the screen height. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35134 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35134 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org --- Comment #4 from Phil Ringnalda <phil@chetcolibrary.org> --- Sizing relative to screen width/height gives reasonable results on a laptop screen (where I'm typically using window size close to screen size), but on a decent size monitor it gets pretty comical. I don't have a monitor quite big enough to catalog in a window that's less than half the screen width, but plenty of people do, which would result in a popup that completely covers the parent window. And since the plugin only displays a fixed number of results, screen height makes it look like a mistake, with two-thirds of the window height just blank. Half the parent window width and the parent window height would eliminate covering the parent window, and give people with more space who need it bigger an easy way to get it: just increase the size of the window you are cataloging in and the popups will be bigger. Makes me wonder what screen height is for a Safari window in VisionOS. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35134 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@ptfs-europe.co | |m --- Comment #6 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Hey guys, looking here. My goal is to contribute (not block) so if the following doesn't make sense or you disagree, please ignore. I'm not a fan of the proposed solution because it's changing arbitrary values for different arbitrary values (although relative to the screen) -> it does not look like a definitive fix. Having said that, I understand it and I believe the reason behind is that window popups are a bit of a wild west, in my opinion (see bug 36143). As an alternative proof of concept, I'm proposing we use a default window size but also save whatever resize the user applies to the pop-up and use that going forward. This way, ideally, any user can resize to whatever size feels comfortable to them and when they open the popup again it'll open the window using those size values instead. My suggestion is not meant to be the end all be all for window pop ups, but rather to stimulate discussion and brainstorming around this. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35134 --- Comment #8 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Lucas Gass from comment #7)

(In reply to Pedro Amorim from comment #6)

...

Hey guys, looking here. My goal is to contribute (not block) so if the following doesn't make sense or you disagree, please ignore.

I'm not a fan of the proposed solution because it's changing arbitrary values for different arbitrary values (although relative to the screen) -> it does not look like a definitive fix. Having said that, I understand it and I believe the reason behind is that window popups are a bit of a wild west, in my opinion (see bug 36143).

As an alternative proof of concept, I'm proposing we use a default window size but also save whatever resize the user applies to the pop-up and use that going forward. This way, ideally, any user can resize to whatever size feels comfortable to them and when they open the popup again it'll open the window using those size values instead.

My suggestion is not meant to be the end all be all for window pop ups, but rather to stimulate discussion and brainstorming around this.

I'm for this idea. I didn't test because your alternative patch doesn't seem to apply.

Sorry, was built on top of yours. It should perhaps have been it's own standalone thing but wanted to keep your patch as the default initial size, and extend it. Try applying both, it should work. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35134 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165381|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35134 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> ---

Sorry, was built on top of yours. It should perhaps have been it's own standalone thing but wanted to keep your patch as the default initial size, and extend it. Try applying both, it should work.

I've applied both and I like how this works, I am resetting this to NSO. Thanks Pedro! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35134 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159171|0 |1 is obsolete| | --- Comment #10 from David Nind <david@davidnind.com> --- Created attachment 167261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167261&action=edit Bug 35134: Make cn_browser popup responsive to screen size To test: 1. Use the cn_browser.pl plugin for the 952$o ( call number ) 2. Add or edit an item and select the `...` to the right of the call number field. 3. The pop-up is hardcoded as 500px x 400px pop-up. 4. APPLY PATCH 5. Clear browser cache and try again. The window width should now be half of the current screen size. The window height should be 100% of the screen height. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35134 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #12 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. Change the framework to add the cn_browser.pl as a plugin for 952$o (I edit the BKS framework) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35134 --- Comment #14 from Lucas Gass <lucas@bywatersolutions.com> --- I like how this works and don't have a problem with it being cookies vs local storage. I wrote the initial patch so I'll excuse myself from QAing. :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35134 --- Comment #16 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 178699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178699&action=edit Bug 35134: Use localStorage instead of a cookie -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35134 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36143 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36143 [Bug 36143] Pop-up window sizes are not consistent -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35134 --- Comment #18 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 179139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179139&action=edit Bug 35134: Save popup size to cookies and use that instead Follow the original test-plan, open the pop-up and resize to whatever size. Close the pop-up, open again, notice it opens to the same size it was previously closed. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35134 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35134 --- Comment #20 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Whilst this doesn't depend on bug 39299, it's only testable once that bug is pushed as that bug fixes issues with the popup displaying at all. Passing QA here -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35134 --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35134 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|With this feature it's |With this enhancement, it's release notes|possible to re-size the |now possible to manually |pop-up generated by the |re-size the pop-up |call number browser |generated by the call |(cn_browser.pl) manually |number browser |with the chosen size being |(cn_browser.pl) - the |remembered for the next |chosen size is then |time the pop-up is opened. |remembered the next time | |the pop-up is opened. -- You are receiving this mail because: You are watching all bug changes.