https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34598 --- Comment #1 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 154712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154712&action=edit Bug 34598: Improve handling of not found ILL request 1) Enable ILLmodule and install FreeForm, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.s...) 2) Visit a request that doesn't exist (assuming empty illrequests table): INTRA/cgi-bin/koha/ill/ill-requests.pl?method=illview&illrequest_id=1 3) Verify an error 500 is returned with message "Can't call method "backend_illview"" 4) Apply patch 5) Repeat steps 1-3. Verify that a "ILL request not found." message is now displayed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34598 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154712|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 154733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154733&action=edit Bug 34598: Improve handling of not found ILL request 1) Enable ILLmodule and install FreeForm, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.s...) 2) Visit a request that doesn't exist (assuming empty illrequests table): INTRA/cgi-bin/koha/ill/ill-requests.pl?method=illview&illrequest_id=1 3) Verify an error 500 is returned with message "Can't call method "backend_illview"" 4) Apply patch 5) Repeat steps 1-3. Verify that a "ILL request not found." message is now displayed Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34598 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154733|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 154737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154737&action=edit Bug 34598: Improve handling of not found ILL request 1) Enable ILLmodule and install FreeForm, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.s...) 2) Visit a request that doesn't exist (assuming empty illrequests table): INTRA/cgi-bin/koha/ill/ill-requests.pl?method=illview&illrequest_id=1 3) Verify an error 500 is returned with message "Can't call method "backend_illview"" 4) Apply patch 5) Repeat steps 1-3. Verify that a "ILL request not found." message is now displayed Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34598 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34598 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.