[Bug 39883] New: NEW_SUGGESTION email notices end up in the patrons notice tab (members/notices.pl) when they should not
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39883 Bug ID: 39883 Summary: NEW_SUGGESTION email notices end up in the patrons notice tab (members/notices.pl) when they should not Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org To recreate: 1. Turn on EmailPurchaseSuggestions and add an email address to EmailAddressForSuggestions. 2. Create a new suggestion and set the " Created by:" field to a patron with an email address 3. Check the message queue ( select * from message_queue where letter_code = "NEW_SUGGESTION" ) 4. There is a NEW_SUGGESTION queued, the to_address should be the email you entered in EmailAddressForSuggestions. 5. The borrowernumber is the borrower who made the suggestion. This shouldn't end up in the notice tab for the borrower since these notices are for staff. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39883 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39883 --- Comment #1 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 182315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182315&action=edit Bug 39883: Do not pass the borrowernumber for NEW_SUGGESTION notices 1. Turn on EmailPurchaseSuggestions and add an email address to EmailAddressForSuggestions. 2. Create a new suggestion and set the " Created by:" field to a patron with an email address 3. Check the message queue ( select * from message_queue where letter_code = "NEW_SUGGESTION" ) 4. There is a NEW_SUGGESTION queued, the to_address should be the email you entered in EmailAddressForSuggestions. 5. The borrowernumber is the borrower who made the suggestion. 6. APPLY PATCH, restart_all 7. Repeat steps 2 - 4. 8. This time a NEW_SUGGESTION should be queued, but the borrowernumber will be undef 9. Check in the patron's notice tab, there should be nothing queued. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39883 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39883 Michael Adamyk <michael.adamyk@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michael.adamyk@bywatersolut | |ions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39883 George Williams (NEKLS) <george@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george@nekls.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39883 Lin Wei <lin-wei.li@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39883 Lin Wei <lin-wei.li@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182315|0 |1 is obsolete| | --- Comment #2 from Lin Wei <lin-wei.li@inLibro.com> --- Created attachment 182391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182391&action=edit Bug 39883: Do not pass the borrowernumber for NEW_SUGGESTION notices 1. Turn on EmailPurchaseSuggestions and add an email address to EmailAddressForSuggestions. 2. Create a new suggestion and set the " Created by:" field to a patron with an email address 3. Check the message queue ( select * from message_queue where letter_code = "NEW_SUGGESTION" ) 4. There is a NEW_SUGGESTION queued, the to_address should be the email you entered in EmailAddressForSuggestions. 5. The borrowernumber is the borrower who made the suggestion. 6. APPLY PATCH, restart_all 7. Repeat steps 2 - 4. 8. This time a NEW_SUGGESTION should be queued, but the borrowernumber will be undef 9. Check in the patron's notice tab, there should be nothing queued. Signed-off-by: Lin Wei Li <lin-wei.li@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39883 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |pedro.amorim@openfifth.co.u |y.org |k CC| |pedro.amorim@openfifth.co.u | |k -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39883 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39883 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182391|0 |1 is obsolete| | --- Comment #3 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 185133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185133&action=edit Bug 39883: Do not pass the borrowernumber for NEW_SUGGESTION notices 1. Turn on EmailPurchaseSuggestions and add an email address to EmailAddressForSuggestions. 2. Create a new suggestion and set the " Created by:" field to a patron with an email address 3. Check the message queue ( select * from message_queue where letter_code = "NEW_SUGGESTION" ) 4. There is a NEW_SUGGESTION queued, the to_address should be the email you entered in EmailAddressForSuggestions. 5. The borrowernumber is the borrower who made the suggestion. 6. APPLY PATCH, restart_all 7. Repeat steps 2 - 4. 8. This time a NEW_SUGGESTION should be queued, but the borrowernumber will be undef 9. Check in the patron's notice tab, there should be nothing queued. Signed-off-by: Lin Wei Li <lin-wei.li@inLibro.com> Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39883 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39883 --- Comment #4 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39883 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |The patch makes it so release notes| |NEW_SUGGESTION email | |notices do not show up in a | |patron's notice history. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39883 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39883 --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 185467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185467&action=edit Bug 39883: ( follow-up ) Adjust tests to not rely on borrowernumber -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39883 --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Actually, a better way to get the data I want is to replace the search by borrowernumber with letter_code => 'NEW_SUGGESTION -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39883 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185467|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39883 --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 185471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185471&action=edit Bug 39883: (follow-up) Retrieve messages by letter_code -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39883 --- Comment #8 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- follow-up pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39883 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39883 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00 |25.11.00,25.05.04 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39883 --- Comment #9 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39883 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 24.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org