[Bug 3239] New: Declare default style/script w/ HTTP headers
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3239 Summary: Declare default style/script w/ HTTP headers Product: Koha Version: HEAD Platform: PC URL: http://www.w3.org/TR/html401/present/styles.html#h- 14.2.1 OS/Version: All Status: NEW Severity: trivial Priority: P5 Component: Architecture, internals, and plumbing AssignedTo: galen.charlton@liblime.com ReportedBy: joe.atzberger@liblime.com Estimated Hours: 0.0 Change sponsored?: --- Because we use inline style="..." and event attributes like onclick="...", the Total Validator plugin reports errors, since we have not declared default script language and stylesheet type. In practice, I believe all browsers will handle this fine, but as a technical point, TV is correct. output_html_with_http_headers should probably send headers: Content-Style-Type: text/css Content-Script-Type: text/javascript http://www.w3.org/TR/html401/present/styles.html#h-14.2.1 http://www.w3.org/TR/html401/interact/scripts.html#h-18.2.2.1 This would be a broader fix that could still be overridden by META tags if, in some unlikely future, a page actually uses a different default script or style. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3239 Galen Charlton <galen.charlton@liblime.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |galen.charlton@liblime.com AssignedTo|galen.charlton@liblime.com |joe.atzberger@liblime.com --- Comment #1 from Galen Charlton <galen.charlton@liblime.com> 2009-05-20 17:33:06 --- I agree with having output_html_with_http_headers set the Content-Style-Type and Content-Script-Type headers. Please prepare a patch to do this. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3239 Galen Charlton <galen.charlton@liblime.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3239 --- Comment #2 from Joe Atzberger <joe.atzberger@liblime.com> 2009-05-21 19:31:37 --- CGI.pm actually is non-canonical about the output, losing capitalization after the hyphens. perl -e 'use CGI; my $x=CGI->new; my $z= { "Content-Script-Type"=>"text/css"}; print $x->header($z);' Content-script-type: text/css Content-Type: text/html; charset=ISO-8859-1 So I filed a bug against CGI. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3239 MJR <mjr@ttllp.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mjr@ttllp.co.uk --- Comment #3 from MJR <mjr@ttllp.co.uk> 2009-05-22 09:28:52 --- CGI bug is https://rt.cpan.org/Public/Bug/Display.html?id=46283 Please link references when possible. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3239 Galen Charlton <galen.charlton@liblime.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent --- Comment #4 from Galen Charlton <galen.charlton@liblime.com> 2009-05-22 13:40:53 --- Pushed patch. I notice that Total Validator does accept the non-canonical form of the header names. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3239 --- Comment #5 from Joe Atzberger <joe.atzberger@liblime.com> 2009-05-22 15:25:19 --- Actually, while TotalValidator accepts the headers, it doesn't recognize the non-canonical forms for their intended purpose. So I still get an error like the following (from the INTRANET home page): problemE649 The default scripting language must be specified for an intrinsic event: <a href="/cgi-bin/koha/help.pl" id="helper" onclick="window.open('/cgi-bin/koha/help.pl','Koha_Help','width=600,height=600,toolbar=false,scrollbars=yes'); return false;"> -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠liblime.com