http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11502 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11502 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- Created attachment 24047 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24047&action=edit Bug 11502 - Branch filter in "Holds To Pull" is too fuzzy This patch uses regex checking via the DataTables fnFilter API method to make the branch filter more precise on the "Holds to Pull" page. The ability to use regex is built into DataTables so this just adds the actual expression. _TEST PLAN_ Before applying: 1) Add library (branches) with codes of NM, NMH, and NB 2) Add items (that can be placed on hold) at all these branches 3) Place a hold on an item that is only available at NM 4) Place a hold on an item that is only available at NMH 5) Place a hold on an item that is only available at NM and NB 6) Go to "Holds to Pull" in the Circulation module 7) Filter by these three different values 8) Note that filtering by "NM" will incorrectly bring up all three holds, while "NMH" and "NB" will only pull up one (like they should). Apply the patch. 9) Shift+refresh the page so that your Javascript refreshes 10) Repeat step 7 (filtering by the different branch values) 11) Note that filtering by "NM" will now only bring up the hold for "NM" and the hold for "NM" and "NB", while the others still only bring up one hold. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11502 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24047|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 24048 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24048&action=edit Bug 11502 - Branch filter in "Holds To Pull" is too fuzzy This patch uses regex checking via the DataTables fnFilter API method to make the branch filter more precise on the "Holds to Pull" page. The ability to use regex is built into DataTables so this just adds the actual expression. _TEST PLAN_ Before applying: 1) Add library (branches) with codes of NM, NMH, and NB 2) Add items (that can be placed on hold) at all these branches 3) Place a hold on an item that is only available at NM 4) Place a hold on an item that is only available at NMH 5) Place a hold on an item that is only available at NM and NB 6) Go to "Holds to Pull" in the Circulation module 7) Filter by these three different values 8) Note that filtering by "NM" will incorrectly bring up all three holds, while "NMH" and "NB" will only pull up one (like they should). Apply the patch. 9) Shift+refresh the page so that your Javascript refreshes 10) Repeat step 7 (filtering by the different branch values) 11) Note that filtering by "NM" will now only bring up the hold for "NM" and the hold for "NM" and "NB", while the others still only bring up one hold. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11502 --- Comment #4 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #3)

Hi David, Could you explain why you match the < and >? The ^$ are not enough?

Sure, Jonathan. It's because DataTables interprets all the data in a table cell as one long string. Sometimes, your string might be <td>BRANCH</td>. Other times, it might be <td>BRANCH<br/>BRANCH1<br/>BRANCH2</td>. If you were to only use ^$, 'BRANCH' would only match the first scenario. It wouldn't match the second, because the string ends with BRANCH2 - not BRANCH. However, we want it to match both scenarios, so we need to include < and >. In fact, there are 4 scenarios I see: 1) ^BRANCH$ (i.e. the string is only BRANCH) 2) ^BRANCH< (i.e. the string begins with BRANCH) 3) >BRANCH< (i.e. the string contains BRANCH in the middle somewhere) 4) >BRANCH$ (i.e. the string ends with BRANCH) Does that answer your question? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11502 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24048|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 24272 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24272&action=edit Bug 11502 - Branch filter in "Holds To Pull" is too fuzzy This patch uses regex checking via the DataTables fnFilter API method to make the branch filter more precise on the "Holds to Pull" page. The ability to use regex is built into DataTables so this just adds the actual expression. _TEST PLAN_ Before applying: 1) Add library (branches) with codes of NM, NMH, and NB 2) Add items (that can be placed on hold) at all these branches 3) Place a hold on an item that is only available at NM 4) Place a hold on an item that is only available at NMH 5) Place a hold on an item that is only available at NM and NB 6) Go to "Holds to Pull" in the Circulation module 7) Filter by these three different values 8) Note that filtering by "NM" will incorrectly bring up all three holds, while "NMH" and "NB" will only pull up one (like they should). Apply the patch. 9) Shift+refresh the page so that your Javascript refreshes 10) Repeat step 7 (filtering by the different branch values) 11) Note that filtering by "NM" will now only bring up the hold for "NM" and the hold for "NM" and "NB", while the others still only bring up one hold. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11502 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers@biblibre.co | |m --- Comment #8 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Patch pushed to 3.14.x, will be in 3.14.5 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11502 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.12.x will be in 3.12.12 -- You are receiving this mail because: You are watching all bug changes.