[Bug 22130] New: Batch checkout : authorized value description is never shown with notforloan status.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22130 Bug ID: 22130 Summary: Batch checkout : authorized value description is never shown with notforloan status. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Circulation Assignee: pierre-marc.thibault@inlibro.com Reporter: pierre-marc.thibault@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com, philippe.blouin@inlibro.com Target Milestone: --- There is an error when document status is shown. When the text information is "Item is normally not for loan", the text in brackets is always the authorized value even if there is a description for that. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22130 --- Comment #1 from Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> --- Created attachment 83986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83986&action=edit Bug 22130: Correct parameter to get authorized value description. This patch corrects the error that shows an authorized value instead of the obvious description of the document status. TEST PLAN 1) In Koha administration, search "BatchCheckouts". 2) Make sure "BatchCheckouts" is set at "Allow". 3) Make sure "BatchCheckoutsValidCategories" contains at least one patron category. 5) Copy the barcode of an item and change the status document so it cannot be loaned. 4) Choose a patron which belongs to the patron category at 3). (their account should not be expired and they should not have active fees preferably) 5) Go to the patron details page. 6) Click on "Batch check out". 7) Enter the item barcode. 8) Notice a number is in brackets under the column "Information". 9) Apply patch. 10) Notice the status description has replaced the number. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22130 Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22130 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22130 Devinim <kohadevinim@devinim.com.tr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kohadevinim@devinim.com.tr --- Comment #2 from Devinim <kohadevinim@devinim.com.tr> --- Hi Pierre-Marc, We went through your steps but we didn't see any number under the column "Information" We saw "! Item not for loan" message there. Thanks. Devinim Koha Team -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22130 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83986|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 85013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85013&action=edit Bug 22130: Correct parameter to get authorized value description. This patch corrects the error that shows an authorized value instead of the obvious description of the document status. TEST PLAN 1) In Koha administration, search "BatchCheckouts". 2) Make sure "BatchCheckouts" is set at "Allow". 3) Make sure "BatchCheckoutsValidCategories" contains at least one patron category. 5) Copy the barcode of an item and change the status document so it cannot be loaned. 4) Choose a patron which belongs to the patron category at 3). (their account should not be expired and they should not have active fees preferably) 5) Go to the patron details page. 6) Click on "Batch check out". 7) Enter the item barcode. 8) Notice a number is in brackets under the column "Information". 9) Apply patch. 10) Notice the status description has replaced the number. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22130 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.renvoize@ptfs-europe | |.com --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This worked for me... Signing off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22130 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22130 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85013|0 |1 is obsolete| | --- Comment #5 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85027&action=edit Bug 22130: Correct parameter to get authorized value description. This patch corrects the error that shows an authorized value instead of the obvious description of the document status. TEST PLAN 1) In Koha administration, search "BatchCheckouts". 2) Make sure "BatchCheckouts" is set at "Allow". 3) Make sure "BatchCheckoutsValidCategories" contains at least one patron category. 5) Copy the barcode of an item and change the status document so it cannot be loaned. 4) Choose a patron which belongs to the patron category at 3). (their account should not be expired and they should not have active fees preferably) 5) Go to the patron details page. 6) Click on "Batch check out". 7) Enter the item barcode. 8) Notice a number is in brackets under the column "Information". 9) Apply patch. 10) Notice the status description has replaced the number. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22130 --- Comment #6 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85028&action=edit Bug 22130: (follow-up) Show not for loan authorised values in batch checkout TEST PLAN 1) In Koha administration, search "BatchCheckouts". 2) Make sure "BatchCheckouts" is set at "Allow". 3) Make sure "BatchCheckoutsValidCategories" contains at least one patron category. 5) Copy the barcode of an item and change the status document so it cannot be loaned. 4) Choose a patron which belongs to the patron category at 3). (their account should not be expired and they should not have active fees preferably) 5) Go to the patron details page. 6) Click on "Batch check out". 7) Enter the item barcode. 8) Notice a number is in brackets under the column "Information". 9) Apply patch. 10) Notice the status description has replaced the number. 11) Try it with both: AllowNotForLoanOverride on and off Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22130 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Confused by the status of this one.. accidental set back to NSO rather than PQA perhaps? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22130 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22130 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85027|0 |1 is obsolete| | Attachment #85028|0 |1 is obsolete| | --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 85169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85169&action=edit Bug 22130: Correct parameter to get authorized value description. This patch corrects the error that shows an authorized value instead of the obvious description of the document status. TEST PLAN 1) In Koha administration, search "BatchCheckouts". 2) Make sure "BatchCheckouts" is set at "Allow". 3) Make sure "BatchCheckoutsValidCategories" contains at least one patron category. 5) Copy the barcode of an item and change the status document so it cannot be loaned. 4) Choose a patron which belongs to the patron category at 3). (their account should not be expired and they should not have active fees preferably) 5) Go to the patron details page. 6) Click on "Batch check out". 7) Enter the item barcode. 8) Notice a number is in brackets under the column "Information". 9) Apply patch. 10) Notice the status description has replaced the number. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22130 --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 85170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85170&action=edit Bug 22130: (follow-up) Show not for loan authorised values in batch checkout TEST PLAN 1) In Koha administration, search "BatchCheckouts". 2) Make sure "BatchCheckouts" is set at "Allow". 3) Make sure "BatchCheckoutsValidCategories" contains at least one patron category. 5) Copy the barcode of an item and change the status document so it cannot be loaned. 4) Choose a patron which belongs to the patron category at 3). (their account should not be expired and they should not have active fees preferably) 5) Go to the patron details page. 6) Click on "Batch check out". 7) Enter the item barcode. 8) Notice a number is in brackets under the column "Information". 9) Apply patch. 10) Notice the status description has replaced the number. 11) Try it with both: AllowNotForLoanOverride on and off Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22130 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | --- Comment #10 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Martin Renvoize from comment #7)
Confused by the status of this one.. accidental set back to NSO rather than PQA perhaps?
True, sorry. Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22130 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22130 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Batch checkout : authorized |Batch checkout: authorized |value description is never |value description is never |shown with notforloan |shown with notforloan |status. |status CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22130 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22130 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #13 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 18.05.x for 18.05.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22130 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org