[Bug 8680] New: Z39.50 searches for ISBN/ISSN problematic in the Acquistions Module
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8680 Priority: P5 - low Change sponsored?: --- Bug ID: 8680 Assignee: koha-bugs@lists.koha-community.org Summary: Z39.50 searches for ISBN/ISSN problematic in the Acquistions Module Severity: normal Classification: Unclassified OS: All Reporter: jbalway@gmail.com Hardware: All Status: NEW Version: rel_3_8 Component: Acquisitions Product: Koha "Copy cataloging via Z39.50 is often done by searching on ISBN or ISSN. Unfortunately, the code for doing this is... problematic, and may cause problems with some Z39.50 servers." (Description from Bug 8550). This Bug is the Exact Same bug as 8550. Except it is in the Z39.50 Search Script located in the Acquisitions Module. /usr/share/koha/intranet/cgi-bin/acqui/z3950_search.pl The z3950_search.pl script for the Acquisitions Module has a few extra lines of code to handle Ordering of the item. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8680 --- Comment #1 from Joseph Alway <jbalway@gmail.com> --- Created attachment 12401 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12401&action=edit Z39.50 ISBN Search is problematic and there is a missing ISSN field. The changes made a duplicate fixes. Bug 8550 was for the Cataloguing module. Bug 8680 is for the Acquisitions module. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8680 Joseph Alway <jbalway@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8680 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12401|0 |1 is obsolete| | --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 12609 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12609&action=edit [SIGNED-OFF] Bug 8680 Z39.50 ISBN Search is problematic and there is a missing ISSN field. The changes here are duplicate fixes. The cataloguing directory had the same bugs as the acqui directory. The bugs in the cataloguing files of the same name were fixed in Bug 8550. The bugs in the acqui files had not been fixed. This will fix Bug 8680 which is in the Acquisitions Module. Changes to the z3950_search.pl file: Rather than treating ISBN and ISSN as the same, this patch breaks them out into separate parts of the query, as well as changing the truncation attribute to enable right truncation (the correct behavior for the ISBN field in MARC21, and valid behavior in UNIMARC). Changes to the z3950_search.tt file: Sometime in 2009 or so, the ISSN field was removed from the Z39.50 search page, and the ISBN field replaced with a combined ISBN/ISSN field. Since this breaks ISBN search for most Z39.50 targets (due to the differing treatment of ISBN vs. ISSN), this is a bug not a feature. Signed-off-by: Marc Veron <veron@veron.ch> Works as expected. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8680 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron@veron.ch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8680 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj@kohaaloha.com QA Contact| |mtj@kohaaloha.com --- Comment #3 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #2)
Created attachment 12609 [details] [SIGNED-OFF] Bug 8680 Z39.50 ISBN Search is problematic and there is a missing ISSN field.
Signed-off-by: Marc Veron <veron@veron.ch>
Works as expected.
tested works as expected, passing QA... $ koha-qa.pl -c 1 testing 1 commit(s) (applied to commit 6c18204) * 76fc1dc Bug 8680 Z39.50 ISBN Search is problematic and there is a missing ISSN field. acqui/z3950_search.pl koha-tmpl/intranet-tmpl/prog/en/modules/acqui/z3950_search.tt * acqui/z3950_search.pl OK * koha-tmpl/intranet-tmpl/prog/en/modules/acqui/z3950_search.tt OK -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8680 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com --- Comment #4 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed to master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8680 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x, will be in 3.8.6 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8680 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9369 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org