[Bug 40255] New: Allow custom debit descriptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40255 Bug ID: 40255 Summary: Allow custom debit descriptions Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Bug 24865 made it possible to use a notice to replace the default wording of the description for overdue fines. It would be helpful to expand that functionality to all debit types, both system-defined and local. It might make more sense to put this within the Debit Type setup than to continue using notices, though. These custom descriptions would allow Template Toolkit as notices do, however, for formatting, logic, and value transformation -- for example, one library wants the description to tell what portion of the fee goes to local tax. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40255 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40255 --- Comment #1 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Weird clarifying note here: this suggestion is to allow customization of what goes into the accountlines.description field when a debit is recorded in the patron's account. This suggestion is *not* to change the value in account_debit_types.description, which is the display value used when selecting a debit type to be used when creating a debit on a patron's account. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40255 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40255 --- Comment #2 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 188174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188174&action=edit Bug 40255: Allow for custom debit descriptions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40255 --- Comment #3 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 188176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188176&action=edit Bug 40255: (follow-up) Fix errors in letter.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40255 --- Comment #4 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 188177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188177&action=edit Bug 40255: Unit test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40255 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188176|0 |1 is obsolete| | --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 188178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188178&action=edit Bug 40255: (follow-up) Fix errors in letter.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40255 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188174|0 |1 is obsolete| | --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 188179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188179&action=edit Bug 40255: Allow for custom debit descriptions To test: 1. Apply patch, restart all 2. Go to debit types and click "Show all debit types" and pick a system defined debit type to test with. I worked mainly with ACCOUNT ( Account creation fee ) but we should test with as many debit types as possible 3. Note the account_debit_types.code you are working with 4. Now go to Tools > Notices and Slips and create a new notice 5. Choose the "Debit description (custom)" module as your module. 6. Use the code from step 2 and 3. 7. In the "email" part of the noctice add something like: $[% accountline.amount %] (includes $[% accountline.amount * 0.1 %] tax) 8. Now go to Administration > Patron categories and configure a patron category to have a "Enrollment fee". ( I set mine to 100 ) 9. Now create a patron in that category. 10. Once created, visit the accounting tab for that patron. 11. You should see a description like "$100.00 (includes $10.00 tax)" 12. Try with other debit types to ensure this works with all. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40255 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188177|0 |1 is obsolete| | --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 188180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188180&action=edit Bug 40255: Unit test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40255 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188178|0 |1 is obsolete| | --- Comment #8 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 188181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188181&action=edit Bug 40255: (follow-up) Fix errors in letter.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40255 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40255 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #9 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- the tests revealed a problem, setting back to ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40255 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- How will this work with TranslateNotices? Would it be an option to make the language used follow the patron's preferred language? And do we want that or would it be a burden to staff having to deal with descriptions in multiple languages? My feeling here would be that customization is nice, but I am wondering if we are going the wrong way by saving strings into the database for this purpose. Maybe if we could have a more flexible system that translates on the fly using templates and variables pulled from the db, it would be much better down the road. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40255 --- Comment #11 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #10)
How will this work with TranslateNotices? Would it be an option to make the language used follow the patron's preferred language? And do we want that or would it be a burden to staff having to deal with descriptions in multiple languages?
The existing patches here already work this way. If TranslateNotices is on and the patron has set a preferred language and the library has a translation of their description for that language, we will record the description in the patron's preferred language. Just as Koha will currently record the text of a patron's notices in their preferred language (or use the default if no translation exists).
My feeling here would be that customization is nice, but I am wondering if we are going the wrong way by saving strings into the database for this purpose. Maybe if we could have a more flexible system that translates on the fly using templates and variables pulled from the db, it would be much better down the road.
This seems like a good idea, but also a large idea that needs more fleshing out and should be handled in its own bug and apply to notices more broadly. I'd rather not have this accountlines description functionality stuck behind a project that's not really underway yet. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40255 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40255 --- Comment #12 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 189641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189641&action=edit Bug 40255: Fixes for translations and updated unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40255 --- Comment #13 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Update test plan to include the testing on translated notices: To test: 1. Apply patch, restart all 2. Go to debit types and click "Show all debit types" and pick a system defined debit type to test with. I worked mainly with ACCOUNT ( Account creation fee ) but we should test with as many debit types as possible 3. Note the account_debit_types.code you are working with 4. Now go to Tools > Notices and Slips and create a new notice 5. Choose the "Debit description (custom)" module as your module. 6. Use the code from step 2 and 3. 7. In the "email" part of the noctice add something like: $[% accountline.amount %] (includes $[% accountline.amount * 0.1 %] tax) 8. Now go to Administration > Patron categories and configure a patron category to have a "Enrollment fee". ( I set mine to 100 ) 9. Now create a patron in that category. 10. Once created, visit the accounting tab for that patron. 11. You should see a description like "$100.00 (includes $10.00 tax)" 12. Try with other debit types to ensure this works with all. Test translatability 13. Turn on "Translate notices" 14. Install at least 1 additional language pack 15. Make a similar ACCOUNT notice similar to the one above, in your choosen language. 16. If using the ACCOUNT notice make sure you set the patron's preffered language when setting up the patron 17. Make sure the patron gets a custom accountline description in the preffered language. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40255 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40255 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40255 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188179|0 |1 is obsolete| | --- Comment #14 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 189807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189807&action=edit Bug 40255: Allow for custom debit descriptions To test: 1. Apply patch, restart all 2. Go to debit types and click "Show all debit types" and pick a system defined debit type to test with. I worked mainly with ACCOUNT ( Account creation fee ) but we should test with as many debit types as possible 3. Note the account_debit_types.code you are working with 4. Now go to Tools > Notices and Slips and create a new notice 5. Choose the "Debit description (custom)" module as your module. 6. Use the code from step 2 and 3. 7. In the "email" part of the noctice add something like: $[% accountline.amount %] (includes $[% accountline.amount * 0.1 %] tax) 8. Now go to Administration > Patron categories and configure a patron category to have a "Enrollment fee". ( I set mine to 100 ) 9. Now create a patron in that category. 10. Once created, visit the accounting tab for that patron. 11. You should see a description like "$100.00 (includes $10.00 tax)" 12. Try with other debit types to ensure this works with all. Signed-off-by: Scott Aylett <saylett@spanishfork.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40255 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188180|0 |1 is obsolete| | --- Comment #15 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 189808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189808&action=edit Bug 40255: Unit test Signed-off-by: Scott Aylett <saylett@spanishfork.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40255 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188181|0 |1 is obsolete| | --- Comment #16 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 189809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189809&action=edit Bug 40255: (follow-up) Fix errors in letter.tt Signed-off-by: Scott Aylett <saylett@spanishfork.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40255 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189641|0 |1 is obsolete| | --- Comment #17 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 189810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189810&action=edit Bug 40255: Fixes for translations and updated unit tests Signed-off-by: Scott Aylett <saylett@spanishfork.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40255 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette@bywatersolutions.co | |m QA Contact|testopia@bugs.koha-communit |lisette@bywatersolutions.co |y.org |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40255 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed Status|Signed Off |Failed QA --- Comment #18 from Lisette Scheer <lisette@bywatersolutions.com> --- When creating a manual invoice, description is still shown but doesn't save (example LOST) Ideally it would either - be hidden if all libraries/your library has a letter code and still show if that's not the case and work as expected - Show the TT? and allow for changes if needed? I think removing it entirely would not work for some libraries, although notes could be used, but I think if it doesn't work when something's defined we need a change. Additionally for LOST, the title shows even if it's not in the description template. This may be a problem for libraries that want to fully customize. I think that Debit code in the dropdown for adding a notice should be in alphabetical order. I'll file a bug to put Booking in alphabetical order as well since it's the only one that's not. Also noting that the HTML checkbox doesn't work (correct but should maybe be in the release notes) For reference the following objects are available/populate when I use the template here (as of posting the template doesn't include accountlines but I'm updating the article today) https://help.bywatersolutions.com/portal/en/kb/articles/data-availability-vi... accountline borrower branch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40255 --- Comment #19 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Thanks Lisette,
Ideally it would either - be hidden if all libraries/your library has a letter code and still show if that's not the case and work as expected - Show the TT? and allow for changes if needed?
I think removing it entirely would not work for some libraries, although notes could be used, but I think if it doesn't work when something's defined we need a change.
Maybe, if you want to write a new description when creating a manual invoice it should overwrite the debit description template?
Additionally for LOST, the title shows even if it's not in the description template. This must be fixed, I will look into it.
This may be a problem for libraries that want to fully customize.
I think that Debit code in the dropdown for adding a notice should be in alphabetical order. I'll file a bug to put Booking in alphabetical order as well since it's the only one that's not. Yes, it should.
Also noting that the HTML checkbox doesn't work (correct but should maybe be in the release notes) IMO, this must be fixed. One should be able to use HTML,
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40255 --- Comment #20 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 193655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193655&action=edit Bug 40255: Alphabetize dropdown list -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40255 --- Comment #21 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Lucas Gass (lukeg) from comment #19)
Thanks Lisette,
Ideally it would either - be hidden if all libraries/your library has a letter code and still show if that's not the case and work as expected - Show the TT? and allow for changes if needed?
I think removing it entirely would not work for some libraries, although notes could be used, but I think if it doesn't work when something's defined we need a change.
Maybe, if you want to write a new description when creating a manual invoice it should overwrite the debit description template?
Actually not sure if that is correct either. I think maybe a hint/tooltip to let the user know if they have a description defined in notices/slips it will be used. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40255 --- Comment #22 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> ---
Additionally for LOST, the title shows even if it's not in the description template. This must be fixed, I will look into it.
In the template there is: >[% IF ( account.itemnumber ) %] <a href="/cgi-bin/koha/catalogue/moredetail.pl?itemnumber=[% account.itemnumber | uri %]&biblionumber=[% account.item.biblionumber | uri %]#item[% account.itemnumber | uri %]" >[% account.item.barcode | html %]</a > [% END %]</td > I don't think we should change this behavior. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40255 --- Comment #23 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 193666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193666&action=edit Bug 40255: Allow scrubbed HTML to be used -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40255 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40255 --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Lucas Gass (lukeg) from comment #20)
Created attachment 193655 [details] [review] Bug 40255: Alphabetize dropdown list
Please don't do it like this. It only makes sense in English, in every other langauge it will still be very messy. We need to sort by description using code or maybe could have a "function" based sorting. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40255 --- Comment #25 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #24)
(In reply to Lucas Gass (lukeg) from comment #20)
Created attachment 193655 [details] [review] [review] Bug 40255: Alphabetize dropdown list
Please don't do it like this. It only makes sense in English, in every other langauge it will still be very messy. We need to sort by description using code or maybe could have a "function" based sorting.
We can drop this patch that alphabetizes but what your describing here is a seperate bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40255 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193655|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40255 --- Comment #26 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #24)
(In reply to Lucas Gass (lukeg) from comment #20)
Created attachment 193655 [details] [review] [review] Bug 40255: Alphabetize dropdown list
Please don't do it like this. It only makes sense in English, in every other langauge it will still be very messy. We need to sort by description using code or maybe could have a "function" based sorting.
I have filed a bug: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41910 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40255 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|lisette@bywatersolutions.co |andrew@bywatersolutions.com |m | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40255 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40255 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189807|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40255 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189808|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40255 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189809|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40255 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189810|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40255 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193666|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40255 --- Comment #27 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 196604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196604&action=edit Bug 40255: Allow for custom debit descriptions To test: 1. Apply patch, restart all 2. Go to debit types and click "Show all debit types" and pick a system defined debit type to test with. I worked mainly with ACCOUNT ( Account creation fee ) but we should test with as many debit types as possible 3. Note the account_debit_types.code you are working with 4. Now go to Tools > Notices and Slips and create a new notice 5. Choose the "Debit description (custom)" module as your module. 6. Use the code from step 2 and 3. 7. In the "email" part of the noctice add something like: $[% accountline.amount %] (includes $[% accountline.amount * 0.1 %] tax) 8. Now go to Administration > Patron categories and configure a patron category to have a "Enrollment fee". ( I set mine to 100 ) 9. Now create a patron in that category. 10. Once created, visit the accounting tab for that patron. 11. You should see a description like "$100.00 (includes $10.00 tax)" 12. Try with other debit types to ensure this works with all. Signed-off-by: Scott Aylett <saylett@spanishfork.gov> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40255 --- Comment #28 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 196605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196605&action=edit Bug 40255: Unit test Signed-off-by: Scott Aylett <saylett@spanishfork.gov> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40255 --- Comment #29 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 196606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196606&action=edit Bug 40255: (follow-up) Fix errors in letter.tt Signed-off-by: Scott Aylett <saylett@spanishfork.gov> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40255 --- Comment #30 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 196607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196607&action=edit Bug 40255: Fixes for translations and updated unit tests Signed-off-by: Scott Aylett <saylett@spanishfork.gov> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40255 --- Comment #31 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 196608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196608&action=edit Bug 40255: Allow scrubbed HTML to be used Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40255 --- Comment #32 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 196609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196609&action=edit Bug 40255: (QA follow-up) Adjust test count Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40255 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40255 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40255 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196604|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40255 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196605|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40255 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196606|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40255 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196607|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40255 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196608|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40255 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196609|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40255 --- Comment #33 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 197454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197454&action=edit Bug 40255: Allow for custom debit descriptions To test: 1. Apply patch, restart all 2. Go to debit types and click "Show all debit types" and pick a system defined debit type to test with. I worked mainly with ACCOUNT ( Account creation fee ) but we should test with as many debit types as possible 3. Note the account_debit_types.code you are working with 4. Now go to Tools > Notices and Slips and create a new notice 5. Choose the "Debit description (custom)" module as your module. 6. Use the code from step 2 and 3. 7. In the "email" part of the noctice add something like: $[% accountline.amount %] (includes $[% accountline.amount * 0.1 %] tax) 8. Now go to Administration > Patron categories and configure a patron category to have a "Enrollment fee". ( I set mine to 100 ) 9. Now create a patron in that category. 10. Once created, visit the accounting tab for that patron. 11. You should see a description like "$100.00 (includes $10.00 tax)" 12. Try with other debit types to ensure this works with all. Signed-off-by: Scott Aylett <saylett@spanishfork.gov> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40255 --- Comment #34 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 197455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197455&action=edit Bug 40255: Unit test Signed-off-by: Scott Aylett <saylett@spanishfork.gov> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40255 --- Comment #35 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 197456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197456&action=edit Bug 40255: (follow-up) Fix errors in letter.tt Signed-off-by: Scott Aylett <saylett@spanishfork.gov> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40255 --- Comment #36 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 197457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197457&action=edit Bug 40255: Fixes for translations and updated unit tests Signed-off-by: Scott Aylett <saylett@spanishfork.gov> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40255 --- Comment #37 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 197458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197458&action=edit Bug 40255: Allow scrubbed HTML to be used Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40255 --- Comment #38 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 197459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197459&action=edit Bug 40255: (QA follow-up) Adjust test count Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40255 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patchset allows for release notes| |the ability to set custom | |debit descriptions via | |Notices and Slips by adding | |a new module called "Debit | |description (custom)" to | |notices/slips.. By using a | |Debit description (custom) | |notice/slip with the same | |name as a debit type, a | |custom debit description | |will be used instead of the | |default. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40255 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40255 --- Comment #39 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40255 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40255 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40255 --- Comment #40 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- add_debit tests are now failing here: https://jenkins.koha-community.org/job/Koha_Main_D11/lastCompletedBuild/test... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40255 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com --- Comment #41 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Lucas Gass (lukeg) from comment #40)
add_debit tests are now failing here:
https://jenkins.koha-community.org/job/Koha_Main_D11/lastCompletedBuild/ testReport/
If I revert this change, the tests are passing again: - if ( $self->is_debit && !$self->in_storage && !$self->description ) { + if ( $self->is_debit && !$self->in_storage ) { But it's not clear to me if it's the correct fix. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40255 --- Comment #42 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Jonathan Druart from comment #41)
(In reply to Lucas Gass (lukeg) from comment #40)
add_debit tests are now failing here:
https://jenkins.koha-community.org/job/Koha_Main_D11/lastCompletedBuild/ testReport/
If I revert this change, the tests are passing again: - if ( $self->is_debit && !$self->in_storage && !$self->description ) { + if ( $self->is_debit && !$self->in_storage ) {
But it's not clear to me if it's the correct fix.
But then it breaks another one: # Failed test 'Notice overrides manual description' # at t/db_dependent/Koha/Account/Line.t line 1675. # got: 'Manual description' # expected: 'From notice' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40255 --- Comment #43 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 197807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197807&action=edit Bug 40255: (follow-up) Fix failure in add_debit tests Patch from commit 4eabe56 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40255 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #44 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- follow-up pushed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40255 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting --- Comment #45 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- This will not be backported to 25.11.x due to it being deemed an enhancement or a dependancy not being met -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org