[Bug 10678] New: Allow framework selection when creating from Z39.50
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10678 Bug ID: 10678 Summary: Allow framework selection when creating from Z39.50 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt@gmail.com Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10678 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9742 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10678 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10678 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 20081 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20081&action=edit Bug 10678 - Allow framework selection when creating from Z39.50 If we are creating a new record, we are forced to use the default framework and then change it after we have the cataloguing form filled. This patch adds the option to choose (from a splitted button dropdown) which framework to use. To test: - Apply the patch. - Go to More > Cataloguing - Check there's a nice split button that says "New from Z39.50" a) Click the button, the usual Z39.50 search popup should appear and work as expected (check the URL parameters and see frameworkcode= has no value b) Click on the dropdown arrow, choose a framework and the usual Z39.50 search popup should appear, this time frameworkcode= should have the chosen value. Regards To+ Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10678 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|gmcharlt@gmail.com |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10678 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 20082 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20082&action=edit Snapshot -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10678 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Everything looks good and works well with one exception: If I click the button without choosing one of the menu choices the framworkcode is passed as "undefined" instead of being empty. With "undefined" the default framework isn't loaded and I get an MARC edit screen with no fields. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10678 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10678 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20081|0 |1 is obsolete| | --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 20085 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20085&action=edit Bug 10678 - Allow framework selection when creating from Z39.50 If we are creating a new record, we are forced to use the default framework and then change it after we have the cataloguing form filled. This patch adds the option to choose (from a splitted button dropdown) which framework to use. To test: - Apply the patch. - Go to More > Cataloguing - Check there's a nice split button that says "New from Z39.50" a) Click the button, the usual Z39.50 search popup should appear and work as expected (check the URL parameters and see frameworkcode= has no value b) Click on the dropdown arrow, choose a framework and the usual Z39.50 search popup should appear, this time frameworkcode= should have the chosen value. Regards To+ Edit: fixed a small bug that prevented the default framework to be called. Thanks Owen for testing. Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10678 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 20088 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20088&action=edit Bug 10678 - Update addbooks help page The button's name changed, and a caret was added. Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10678 Melia Meggs <melia@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20085|0 |1 is obsolete| | --- Comment #6 from Melia Meggs <melia@bywatersolutions.com> --- Created attachment 20261 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20261&action=edit [Signed off] Bug 10678 - Allow framework selection when creating from Z39.50 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10678 Melia Meggs <melia@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20088|0 |1 is obsolete| | CC| |melia@bywatersolutions.com --- Comment #7 from Melia Meggs <melia@bywatersolutions.com> --- Created attachment 20262 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20262&action=edit [Signed off] Bug 10678 - Update addbooks help page -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10678 Melia Meggs <melia@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20262|0 |1 is patch| | Attachment #20262|application/mbox |text/plain mime type| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10678 Melia Meggs <melia@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #8 from Melia Meggs <melia@bywatersolutions.com> --- After applying these patches, I can see the "New from Z39.50" button with the arrow for a dropdown of frameworks. I tested this by just clicking the button, going through the usual Z39.50 search and import, and my record was imported with the default framework. I then chose a different framework from the dropdown, went through the usual Z39.50 search and import, and my record was imported with the framework I had selected. I read the update to the help page, and I think everything looks good, so I am signing off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10678 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10678 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20261|0 |1 is obsolete| | Attachment #20262|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 20890 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20890&action=edit [PASSED QA] Bug 10678 - Allow framework selection when creating from Z39.50 If we are creating a new record, we are forced to use the default framework and then change it after we have the cataloguing form filled. This patch adds the option to choose (from a splitted button dropdown) which framework to use. To test: - Apply the patch. - Go to More > Cataloguing - Check there's a nice split button that says "New from Z39.50" a) Click the button, the usual Z39.50 search popup should appear and work as expected (check the URL parameters and see frameworkcode= has no value b) Click on the dropdown arrow, choose a framework and the usual Z39.50 search popup should appear, this time frameworkcode= should have the chosen value. Regards To+ Edit: fixed a small bug that prevented the default framework to be called. Thanks Owen for testing. Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Melia Meggs <melia@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Notes on second patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10678 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 20891 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20891&action=edit [PASSED QA] Bug 10678 - Update addbooks help page The button's name changed, and a caret was added. Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Melia Meggs <melia@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. If you click the button directly, the default framework is still used. If you use the split button functionality to select another framework, this framework will be used for the imported record. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10678 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #11 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Tomás! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10678 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.5. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org