[Bug 9498] New: Update encoding for Norwegian sample Z39.50 servers
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9498 Bug ID: 9498 Summary: Update encoding for Norwegian sample Z39.50 servers Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: magnus@enger.priv.no Reporter: magnus@enger.priv.no CC: gmcharlt@gmail.com As described in Bug 9497 the encoding for BIBSYS should be ISO 8859-1. I'll check if other Norwegian sample servers need updating too. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9498 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |9497 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9498 --- Comment #1 from Magnus Enger <magnus@enger.priv.no> --- Created attachment 15296 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15296&action=edit Bug 9498 - Update encoding for Norwegian sample Z39.50 servers The encoding for sample Z39.50 servers loaded when doing a nb-NO install has been wrong all along, resulting in "norwegian vowels" (æøå) being displayed as weird chars when records are fetched via Z39.50. This patch - Updates the sample servers installed by the web installer - Does a database upgrade that changes the encoding for the servers in question To test: - Do a Norwegian installation and make sure to choose the optional sample Z39.50 targets - Check that encodings for the Norwegian targets (BIBSYS, SAMBOK, NORBOK and DEICHMAN) are all set to ISO_6937 (which is the wrong encoding) - Apply this patch and make sure updatadatabase.pl is run - Check that the encoding for the four targets mentioned above are now ISO_8859-1 - Do one search against each target and check that there are no "strange" chars in the result list. Searching each of the targets for "hessen" should give results that include "norwegian vowels" - Log on to the MySQL of the test installation and empty the table of Z39.50 targets: mysql> delete from z3950servers; - Load this file into MySQL from the command line: installer/data/mysql/nb-NO/2-Valgfritt/z3950servers.sql and check that it loads without errors and that the four Norwegian targets are still set to have encoding = ISO_8859-1 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9498 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9498 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko@abunchofthings.net -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9498 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15296|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 15423 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15423&action=edit [SIGNED-OFF] Bug 9498 - Update encoding for Norwegian sample Z39.50 servers The encoding for sample Z39.50 servers loaded when doing a nb-NO install has been wrong all along, resulting in "norwegian vowels" (æøå) being displayed as weird chars when records are fetched via Z39.50. This patch - Updates the sample servers installed by the web installer - Does a database upgrade that changes the encoding for the servers in question To test: - Do a Norwegian installation and make sure to choose the optional sample Z39.50 targets - Check that encodings for the Norwegian targets (BIBSYS, SAMBOK, NORBOK and DEICHMAN) are all set to ISO_6937 (which is the wrong encoding) - Apply this patch and make sure updatadatabase.pl is run - Check that the encoding for the four targets mentioned above are now ISO_8859-1 - Do one search against each target and check that there are no "strange" chars in the result list. Searching each of the targets for "hessen" should give results that include "norwegian vowels" - Log on to the MySQL of the test installation and empty the table of Z39.50 targets: mysql> delete from z3950servers; - Load this file into MySQL from the command line: installer/data/mysql/nb-NO/2-Valgfritt/z3950servers.sql and check that it loads without errors and that the four Norwegian targets are still set to have encoding = ISO_8859-1 Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work as described. No errors. Test: 1) NOTE: I didn't do a Norwegian install, only tested z39.50 servers output 2) Removed default z39 targets, installed norwegian ones 3) Checked previous z39.50 servers encoding 4) Pre-patch sample search "hessen" BIBSYS Hessen im Frþhmittelalter BIBSYS System der Gemeindebesteuerung in Hessen, Wþrttemberg, Baden, Elsa⅞-Lothringen, Bayern, Sachsen, Preu⅞en DEICHMAN De danske troppers h�derskrands. Eller det danske auxiliair-corps under anf. af prinds Frederik af Hessen NORBOK �tte-tavle for l�rer Johan P. Eidsvig og g�rdbr. Nikolai Nikolaisen Hessen SAMBOK ErlĦuterungen zur Geologischen Karte von Hessen 5) Applied patch, run updatedatabase 6) Checked sample servers encoding Ok 7) Post-patch sample search "hessen" BIBSYS Hessen im Frühmittelalter BIBSYS System der Gemeindebesteuerung in Hessen, Württemberg, Baden, Elsaß-Lothringen, Bayern, Sachsen, Preußen DEICHMAN De danske troppers hæderskrands. Eller det danske auxiliair-corps under anf. af prinds Frederik af Hessen NORBOK Ætte-tavle for lærer Johan P. Eidsvig og gårdbr. Nikolai Nikolaisen Hessen SAMBOK Erläuterungen zur Geologischen Karte von Hessen 8) Sample servers deleted and installed from command line, same result as 6) and 7) No koha-qa errors -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9498 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9498 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy@rijksmuseum.nl --- Comment #3 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- QA Comment: Currently, you have encoding errors in the signed patch :) Could you resolve them please? Thanks. When you are looking again, I would suggest to narrow down the update statements when upgrading. Now you only check name=xxx. But I could have used this name unfortunately (may be bit fictitious).. If you add name=xxx and host=yyy, we are even more complete. Thanks. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9498 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9498 --- Comment #4 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to comment #3)
QA Comment: Currently, you have encoding errors in the signed patch :) Could you resolve them please?
Could you tell me which ones? There are errors in the comment, but that was me showing the result before applying the patch. I could remove that comments if that's the problem :) Thanks -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9498 --- Comment #5 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to comment #4)
(In reply to comment #3)
QA Comment: Currently, you have encoding errors in the signed patch :) Could you resolve them please?
Could you tell me which ones? There are errors in the comment, but that was me showing the result before applying the patch. I could remove that comments if that's the problem :)
Thanks
Maybe you could correct the patch manually (without git bz). Get rid also of the line Content-Transfer-Encoding: 8bit. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9498 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15423|0 |1 is obsolete| | --- Comment #6 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 16904 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16904&action=edit [SIGNED-OFF] Bug 9498 - Update encoding for Norwegian sample Z39.50 servers Manually added patch. Removed strange vowels. Removed encoding line. May be now is well :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9498 --- Comment #7 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to comment #6)
Created attachment 16904 [details] [review] [SIGNED-OFF] Bug 9498 - Update encoding for Norwegian sample Z39.50 servers
Manually added patch. Removed strange vowels. Removed encoding line. May be now is well :)
Thanks! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9498 --- Comment #8 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 16927 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16927&action=edit Bug 9498 QA Followup for updatedatabase Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9498 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16927|0 |1 is obsolete| | --- Comment #9 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 16928 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16928&action=edit Bug 9498 QA Followup for updatedatabase Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9498 --- Comment #10 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Magnus, Could you confirm please if both Norwegian targets NORBOK and SAMBOK have the same host? Why add them both? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9498 --- Comment #11 from Magnus Enger <magnus@enger.priv.no> --- (In reply to comment #10)
Magnus, Could you confirm please if both Norwegian targets NORBOK and SAMBOK have the same host? Why add them both?
They are two different databases ("catalogues") on the same host, so they give different results for the same search. Thanks for the followup whoch makes sense. Ill see if I can sign off on it soon. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9498 --- Comment #12 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to comment #11)
They are two different databases ("catalogues") on the same host, so they give different results for the same search.
Thanks for the followup whoch makes sense. Ill see if I can sign off on it soon.
That makes sense too. I try to have a look tomorrow and sign off on the small change myself if you do not beat me to it :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9498 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16928|0 |1 is obsolete| | --- Comment #13 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 16937 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16937&action=edit [SIGNED-OFF] Bug 9498 QA Followup for updatedatabase Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Small followup to update servers. No errors -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9498 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9498 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16904|0 |1 is obsolete| | Attachment #16937|0 |1 is obsolete| | --- Comment #14 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 16939 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16939&action=edit Bug 9498 QA Followup for updatedatabase Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Small followup to update servers. No errors -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9498 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16939|0 |1 is obsolete| | --- Comment #15 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 16940 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16940&action=edit Bug 9498 - Update encoding for Norwegian sample Z39.50 servers This patch - Updates the sample servers installed by the web installer - Does a database upgrade that changes the encoding for the servers in question To test: - Do a Norwegian installation and make sure to choose the optional sample Z39.50 targets - Check that encodings for the Norwegian targets (BIBSYS, SAMBOK, NORBOK and DEICHMAN) are all set to ISO_6937 (which is the wrong encoding) - Apply this patch and make sure updatadatabase.pl is run - Check that the encoding for the four targets mentioned above are now ISO_8859-1 - Do one search against each target and check that there are no "strange" chars in the result list. Searching each of the targets for "hessen" should give results that include "norwegian vowels" - Log on to the MySQL of the test installation and empty the table of Z39.50 targets: mysql> delete from z3950servers; - Load this file into MySQL from the command line: installer/data/mysql/nb-NO/2-Valgfritt/z3950servers.sql and check that it loads without errors and that the four Norwegian targets are still set to have encoding = ISO_8859-1 Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work as described. No errors. No koha-qa errors Passed-QA-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9498 --- Comment #16 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 16941 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16941&action=edit Bug 9498 QA Followup for updatedatabase Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Small followup to update servers. No errors -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9498 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #17 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Thanks, Bernardo. No further comments necessary. Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9498 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #18 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9498 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #19 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.10.x will be 3.10.5 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9498 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED --- Comment #20 from Magnus Enger <magnus@enger.priv.no> --- Works as expected (tested with packages built off current master). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9498 Bug 9498 depends on bug 9497, which changed state. Bug 9497 Summary: Make it easier to add to the the list of possible encodings for Z39.50 servers and add ISO 8859-1 http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9497 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org