[Bug 11885] New: Inconsistent HTML in MARC Details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11885 Bug ID: 11885 Summary: Inconsistent HTML in MARC Details Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: pasi.kallinen@pttk.fi QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Created attachment 25770 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25770&action=edit Make MARC Details tab HTML consistent In Catalog > MARC Details, the HTML in the different tabs is slightly inconsistent and doesn't differentiate different elements, making CSS styling complicated or impossible: * tab 0 has <p class="subfield_line"> whereas all the other tabs have just <p> * all other tabs wrap the subfield character in <b> tags, except for tab 0 * the MARC tag title is a single div with the tag, the indicators and the field description. Attached patch folds all the tab outputs into a single TT BLOCK, which is then reused. It also marks the separate parts of the tag title in their own spans. The output should be nearly identical to previous behaviour, minus a dash from the tag title descriptions - it was used to separate the tag from the description. The description can now be styled separately from the tag itself, so the dash can be added with CSS, if necessary. To test: 1) Look at some MARC details in the staff client, noting the contents of each tab. 2) Install patch 3) Compare the MARC details output to what was shown in step 1. Should be the same, minus a dash in each of the tag title descriptions. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11885 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Component|Staff Client |Templates Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11885 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |pasi.kallinen@pttk.fi -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11885 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11885 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25770|0 |1 is obsolete| | --- Comment #1 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 26462 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26462&action=edit [SIGNED OFF] Bug 11885 - Inconsistent HTML in MARC Details In Catalog > MARC Details, the HTML in the different tabs is slightly inconsistent and doesn't differentiate different elements, making CSS styling complicated or impossible: * tab 0 has <p class="subfield_line"> whereas all the other tabs have just <p> * all other tabs wrap the subfield character in <b> tags, except for tab 0 * the MARC tag title is a single div with the tag, the indicators and the field description. Attached patch folds all the tab outputs into a single TT BLOCK, which is then reused. It also marks the separate parts of the tag title in their own spans. The output should be nearly identical to previous behaviour, minus a dash from the tag title descriptions - it was used to separate the tag from the description. The description can now be styled separately from the tag itself, so the dash can be added with CSS, if necessary. Revised test: 1) Find a biblio 2) Edit the record so that there is something in every tab (0-9). 3) Save and then click 'MARC' in the left pane to view the MARC details. 4) Note the contents of each tab. 5) Apply patch 6) Compare the MARC details output to what was noted. Should be the same, minus a dash in each of the tag title descriptions. http://bugs.koha-community.org/show_bug.cgi?id=11885 NOTE: It's so elegant! Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11885 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: I didn't find any regression (tag missing, etc.) but 3 smalls things differ from master: 1/ subtags was bold 2/ 1 dash existed between tag and tag name 3/ A space has been added ("606 #1 - Sujet nom commun" becomes "606 # 1 Sujet nom commun", "101 ## - Langue" becomes "101 # # Langue") I am going to provide screenshots. Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11885 --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 26468 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26468&action=edit with patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11885 --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 26469 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26469&action=edit without patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11885 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11885 --- Comment #5 from paxed <pasi.kallinen@pttk.fi> --- (In reply to Jonathan Druart from comment #2)
QA comment:
I didn't find any regression (tag missing, etc.) but 3 smalls things differ from master: 1/ subtags was bold 2/ 1 dash existed between tag and tag name 3/ A space has been added ("606 #1 - Sujet nom commun" becomes "606 # 1 Sujet nom commun", "101 ## - Langue" becomes "101 # # Langue")
I am going to provide screenshots.
Marked as Failed QA.
If you really want the exact same behaviour as before, add the following CSS to your IntranetUserCSS: .tag_title .tag_desc:before { content: " - "; } .tag_title .tag_ind2 { margin-left:-4px; } .subfield-label { font-weight: bold; } div[id=tab0XX] .subfield-label, .subfield-label .desc { font-weight: normal; } -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11885 --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to paxed from comment #5)
If you really want the exact same behaviour as before, add the following CSS to your IntranetUserCSS:
I don't think it is the good answer :) Was it expected? If yes, why? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11885 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11885 --- Comment #7 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 26773 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26773&action=edit Bug 11885 - Follow-up to address issues raised Jonathan Druart raised the following three issues: 1/ subtags was bold before patch 2/ 1 dash existed between tag and tag name 3/ A space has been added ("606 #1 - Sujet nom commun" becomes "606 # 1 Sujet nom commun", "101 ## - Langue" becomes "101 # # Langue") This patch addresses them in the following way: 1/ You will note that @ was not bold on the 0 tab. Every other tab were bold. By making the similar template into a procedure based on the 0XX tab, bolding was lost. This patch bolds all subtags including the @, so that the visible change is minimized. 2/ The dash was programmatically added in at the code stage previously. This bug fix splits the the single concatenation mess into parts which can be styled. This puts the dash back into the template. However, it should be noted that the spacing for the 0 tab's tag and tag description will have an extra space after the hypen that was lacking before. 3/ <span>...</span><span>...</span> is different than <span>...</span> <span>...</span> The later puts that extra space. This patch fixes that. See comment 1 for the test plan. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11885 --- Comment #8 from paxed <pasi.kallinen@pttk.fi> --- (In reply to M. Tompsett from comment #7)
Created attachment 26773 [details] [review] Bug 11885 - Follow-up to address issues raised
This patch addresses them in the following way: 1/ You will note that @ was not bold on the 0 tab. Every other tab were bold. By making the similar template into a procedure based on the 0XX tab, bolding was lost. This patch bolds all subtags including the @, so that the visible change is minimized.
Why hard-coded <b> tags? Isn't there some good reason to separate presentation and content?
2/ The dash was programmatically added in at the code stage previously. This bug fix splits the the single concatenation mess into parts which can be styled. This puts the dash back into the template. However, it should be noted that the spacing for the 0 tab's tag and tag description will have an extra space after the hypen that was lacking before.
Wrap the dash and the spaces before the description in <span class="dashwrapper"> or something, so it'll be easier to hide with css.
3/ <span>...</span><span>...</span> is different than <span>...</span> <span>...</span> The later puts that extra space. This patch fixes that.
This one is good. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11885 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #9 from M. Tompsett <mtompset@hotmail.com> --- (In reply to paxed from comment #8)
(In reply to M. Tompsett from comment #7)
Created attachment 26773 [details] [review] [review] Bug 11885 - Follow-up to address issues raised
This patch addresses them in the following way: 1/ ...
Why hard-coded <b> tags? Isn't there some good reason to separate presentation and content?
Because that is the way it was done before. I'm not saying it was the best way to do it, but it reduces visible differences.
2/ ...
Wrap the dash and the spaces before the description in <span class="dashwrapper"> or something, so it'll be easier to hide with css.
Sure, why not. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11885 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26773|0 |1 is obsolete| | --- Comment #10 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 26853 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26853&action=edit Bug 11885 - Follow-up to address issues raised Jonathan Druart raised the following three issues: 1/ subtags was bold before patch 2/ 1 dash existed between tag and tag name 3/ A space has been added ("606 #1 - Sujet nom commun" becomes "606 # 1 Sujet nom commun", "101 ## - Langue" becomes "101 # # Langue") This patch addresses them in the following way: 1/ You will note that @ was not bold on the 0 tab. Every other tab were bold. By making the similar template into a procedure based on the 0XX tab, bolding was lost. This patch bolds all subtags including the @, so that the visible change is minimized. 2/ The dash was programmatically added in at the code stage previously. This bug fix splits the the single concatenation mess into parts which can be styled. This puts the dash back into the template. However, it should be noted that the spacing for the 0 tab's tag and tag description will have an extra space after the hypen that was lacking before. 3/ <span>...</span><span>...</span> is different than <span>...</span> <span>...</span> The later puts that extra space. This patch fixes that. See comment 1 for the test plan. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11885 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26462|0 |1 is obsolete| | --- Comment #11 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 26917 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26917&action=edit [SIGNED-OFF] Bug 11885 - Inconsistent HTML in MARC Details In Catalog > MARC Details, the HTML in the different tabs is slightly inconsistent and doesn't differentiate different elements, making CSS styling complicated or impossible: * tab 0 has <p class="subfield_line"> whereas all the other tabs have just <p> * all other tabs wrap the subfield character in <b> tags, except for tab 0 * the MARC tag title is a single div with the tag, the indicators and the field description. Attached patch folds all the tab outputs into a single TT BLOCK, which is then reused. It also marks the separate parts of the tag title in their own spans. The output should be nearly identical to previous behaviour, minus a dash from the tag title descriptions - it was used to separate the tag from the description. The description can now be styled separately from the tag itself, so the dash can be added with CSS, if necessary. Revised test: 1) Find a biblio 2) Edit the record so that there is something in every tab (0-9). 3) Save and then click 'MARC' in the left pane to view the MARC details. 4) Note the contents of each tab. 5) Apply patch 6) Compare the MARC details output to what was noted. Should be the same, minus a dash in each of the tag title descriptions. http://bugs.koha-community.org/show_bug.cgi?id=11885 Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11885 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26853|0 |1 is obsolete| | --- Comment #12 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 26918 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26918&action=edit [SIGNED-OFF] Bug 11885 - Follow-up to address issues raised Jonathan Druart raised the following three issues: 1/ subtags was bold before patch 2/ 1 dash existed between tag and tag name 3/ A space has been added ("606 #1 - Sujet nom commun" becomes "606 # 1 Sujet nom commun", "101 ## - Langue" becomes "101 # # Langue") This patch addresses them in the following way: 1/ You will note that @ was not bold on the 0 tab. Every other tab were bold. By making the similar template into a procedure based on the 0XX tab, bolding was lost. This patch bolds all subtags including the @, so that the visible change is minimized. 2/ The dash was programmatically added in at the code stage previously. This bug fix splits the the single concatenation mess into parts which can be styled. This puts the dash back into the template. However, it should be noted that the spacing for the 0 tab's tag and tag description will have an extra space after the hypen that was lacking before. 3/ <span>...</span><span>...</span> is different than <span>...</span> <span>...</span> The later puts that extra space. This patch fixes that. See comment 1 for the test plan. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work as described. Small koha-qa errors fixed in followup -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11885 --- Comment #13 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 26919 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26919&action=edit Bug 11885 - followup to remove tabs Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11885 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11885 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26917|0 |1 is obsolete| | Attachment #26918|0 |1 is obsolete| | Attachment #26919|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 26992 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26992&action=edit Bug 11885 - Inconsistent HTML in MARC Details In Catalog > MARC Details, the HTML in the different tabs is slightly inconsistent and doesn't differentiate different elements, making CSS styling complicated or impossible: * tab 0 has <p class="subfield_line"> whereas all the other tabs have just <p> * all other tabs wrap the subfield character in <b> tags, except for tab 0 * the MARC tag title is a single div with the tag, the indicators and the field description. Attached patch folds all the tab outputs into a single TT BLOCK, which is then reused. It also marks the separate parts of the tag title in their own spans. The output should be nearly identical to previous behaviour, minus a dash from the tag title descriptions - it was used to separate the tag from the description. The description can now be styled separately from the tag itself, so the dash can be added with CSS, if necessary. Revised test: 1) Find a biblio 2) Edit the record so that there is something in every tab (0-9). 3) Save and then click 'MARC' in the left pane to view the MARC details. 4) Note the contents of each tab. 5) Apply patch 6) Compare the MARC details output to what was noted. Should be the same, minus a dash in each of the tag title descriptions. http://bugs.koha-community.org/show_bug.cgi?id=11885 Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11885 --- Comment #15 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 26993 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26993&action=edit Bug 11885 - Follow-up to address issues raised Jonathan Druart raised the following three issues: 1/ subtags was bold before patch 2/ 1 dash existed between tag and tag name 3/ A space has been added ("606 #1 - Sujet nom commun" becomes "606 # 1 Sujet nom commun", "101 ## - Langue" becomes "101 # # Langue") This patch addresses them in the following way: 1/ You will note that @ was not bold on the 0 tab. Every other tab were bold. By making the similar template into a procedure based on the 0XX tab, bolding was lost. This patch bolds all subtags including the @, so that the visible change is minimized. 2/ The dash was programmatically added in at the code stage previously. This bug fix splits the the single concatenation mess into parts which can be styled. This puts the dash back into the template. However, it should be noted that the spacing for the 0 tab's tag and tag description will have an extra space after the hypen that was lacking before. 3/ <span>...</span><span>...</span> is different than <span>...</span> <span>...</span> The later puts that extra space. This patch fixes that. See comment 1 for the test plan. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work as described. Small koha-qa errors fixed in followup Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11885 --- Comment #16 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 26994 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26994&action=edit Bug 11885 - followup to remove tabs Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11885 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11885 --- Comment #17 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 26995 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26995&action=edit Bug 11885: Add a css class to set subfield code bold Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11885 --- Comment #18 from Jonathan Druart <jonathan.druart@biblibre.com> --- All looks good, no regression found. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11885 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch QA Contact|testopia@bugs.koha-communit |jonathan.druart@biblibre.co |y.org |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11885 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #19 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Pasi! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11885 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #20 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14.x, will be in 3.14.10 (code real improvement, nice job) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11885 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #21 from Kyle M Hall <kyle@bywatersolutions.com> --- Picked for 3.12.15 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11885 paxed <pasi.kallinen@pttk.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13406 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org