http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15298 Chloe Alabaster <chloealabaster@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15298 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15298 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Some good possible follow-ups (or new bugs I guess): 1. Validate the HTML to identify some issues with duplicate IDs in the markup. I signed off on the patch because the page already had some duplicate IDs, so it didn't seem fair to hold it up for that. But we should make the page validate. 2. Eliminate the use of 'href="javascript:void(0);"' Progressive-enhancement best practices say that ideally a real URL should be used instead, one which is a fallback for non-JavaScript users. However, we don't require that the staff client be fully functional without JS turned on, so the accepted alternative is to use 'href="#"' The ConfirmDelete() function already returns false, so clicking the link won't result in the page jumping around. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15298 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46901|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 46922 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46922&action=edit Bug 15298 - z39.50 admin setup, options column suggested changes To Test- 1-first look at the orginal Z39.50/SRU servers administration page (/cgi-bin/koha/admin/z3950servers.pl?op=delete_confirmed&id=6) 2-apply patch 3-now see the new styling of the "action" drop down tab like the one on the saved reports page 4-check that each link works (for delete i reccommend copying one then deleting the copy) Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.