[Bug 34462] New: Bug 25299 seems to have been reintroduced in more recent versions.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34462 Bug ID: 34462 Summary: Bug 25299 seems to have been reintroduced in more recent versions. Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: david.roberts@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com On the details screen of a patron record, if the patron is due to expire the alert at the top of the screen reads: Expiration: Patron's card will expire soon. Patron's card expires on The date is missing from this alert. This was originally fixed in Bug 25299, but seems to have been reintroduced. I can replicate this at 21.11 and 22.11. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34462 --- Comment #1 from David Roberts <david.roberts@ptfs-europe.com> --- See https://snipboard.io/t5034G.jpg for a screenshot -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34462 Marie-Luce Laflamme <marie-luce.laflamme@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marie-luce.laflamme@inlibro | |.com --- Comment #2 from Marie-Luce Laflamme <marie-luce.laflamme@inlibro.com> --- We do have this issue too in 23.05 and in earlier version 22.05. Test plan 1. Add a new patron with a date expiry less < than 30 days in the future. 2. Go to the "details" tab of this account 3. Check the expiration message: --> notice the date is missing after "expires on": "Expiration: Patron's card will expire soon. Patron's card expires on Renew or Edit details" 4. Then, compare with the "check out" tab warning --> this one is showing the expiration date correctly "Expiration: Patron's card will expire soon. Patron's card expires on 2023-10-15 Renew or Edit details" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34462 Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily-rose.francoeur@inLibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34462 --- Comment #3 from Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com> --- Created attachment 156337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156337&action=edit Bug 34462 : Display the patron's expiration date The problem is in the patron_messages.inc file on line 25. The variable "expiry" is used, but it should be "patron.dateexpiry" because the patron's card isn't expired yet. TEST PLAN 1) Go to “Patrons > + New patron” 2) Create a patron with an expiry date that is less than 30 days in the future 3) Go to the "details" tab of this account 4) Notice that the date is missing after "expires on": "Expiration: Patron's card will expire soon. Patron's card expires on Renew or Edit details" 5) Apply the patch 6) Reload the page; the expiry date should now be displayed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34462 Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |emily-rose.francoeur@inLibr |ity.org |o.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34462 Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34462 Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com, | |philippe.blouin@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34462 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34462 --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 156359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156359&action=edit Bug 34462: Display the patron's expiration date The problem is in the patron_messages.inc file on line 25. The variable "expiry" is used, but it should be "patron.dateexpiry" because the patron's card isn't expired yet. TEST PLAN 1) Go to “Patrons > + New patron” 2) Create a patron with an expiry date that is less than 30 days in the future 3) Go to the "details" tab of this account 4) Notice that the date is missing after "expires on": "Expiration: Patron's card will expire soon. Patron's card expires on Renew or Edit details" 5) Apply the patch 6) Reload the page; the expiry date should now be displayed Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34462 --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 156360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156360&action=edit Bug 34462: (follow-up) Shorten card experiation message Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34462 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Attachment #156337|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Comment on attachment 156337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156337 Bug 34462 : Display the patron's expiration date Not sure what I did when signing off, obsoleting patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34462 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the display of release notes| |the card expiration message | |on a patron's page so that | |it now includes the date | |that their card will | |expire. --- Comment #7 from David Nind <david@davidnind.com> --- Hi Émily-Rose. I amended your patch (I perhaps should have done this as a follow-up): 1. Removed the extra space in the commit message bug title, so that it now reads as "Bug 34462: Display..." instead of "Bug 34462 : Display...". 2. I added a full stop after the date, so the message displays as "... Patron's card expires on 10/18/2023. Renew or Edit details". I also added a follow-up patch to shorten the message to make it more succinct, as there is a bit of duplication. So the expiration message now reads as "Expiration: Patron's card expires on 10/18/2023. Renew or Edit details". Feel free to obsolete this patch if you disagree 8-). David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34462 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34462 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34462 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156359|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 157239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157239&action=edit Bug 34462: Display the patron's expiration date The problem is in the patron_messages.inc file on line 25. The variable "expiry" is used, but it should be "patron.dateexpiry" because the patron's card isn't expired yet. TEST PLAN 1) Go to “Patrons > + New patron” 2) Create a patron with an expiry date that is less than 30 days in the future 3) Go to the "details" tab of this account 4) Notice that the date is missing after "expires on": "Expiration: Patron's card will expire soon. Patron's card expires on Renew or Edit details" 5) Apply the patch 6) Reload the page; the expiry date should now be displayed Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34462 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156360|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 157240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157240&action=edit Bug 34462: (follow-up) Shorten card experiation message Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34462 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for the fix.. all working as expected and I like the follow-up too. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34462 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34462 --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34462 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25299 CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34462 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27873 --- Comment #12 from Fridolin Somers <fridolin.somers@biblibre.com> --- Looks its dates back to Bug 27873 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27873 [Bug 27873] Make display of patron restrictions, charges, notes, etc. consistent for check out and patron details screens -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34462 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.11.00 |23.11.00,23.05.05 released in| | --- Comment #13 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34462 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.11.00,23.05.05 |23.11.00,23.05.05,22.11.12 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34462 --- Comment #14 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org